February 2008 - seam-issues - Jboss List Archives

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1745) SpringTransaction fails with HibernateJpaDialect and FlushMode.MANUAL

by Darryl Smith (JIRA)

SpringTransaction fails with HibernateJpaDialect and FlushMode.MANUAL ---------------------------------------------------------------------- Key: JBSEAM-1745 URL: http://jira.jboss.com/jira/browse/JBSEAM-1745 Project: JBoss Seam Issue Type: Bug Components: Spring Reporter: Darryl Smith When using flushMode = MANUAL with org.springframework.orm.jpa.vendor.HibernateJpaDialect, the flushMode is changed to AUTO when beginning transaction SessionImpl.setFlushMode(FlushMode) line: 1286 HibernateSessionProxy.setFlushMode(FlushMode) line: 381 SeamHibernateJpaDialect(HibernateJpaDialect).beginTransaction(EntityManager, TransactionDefinition) line: 60 JpaTransactionManager.doBegin(Object, TransactionDefinition) line: 326 JpaTransactionManager(AbstractPlatformTransactionManager).getTransaction(TransactionDefinition) line: 350 SpringTransaction.begin() line: 74 Unless the transaction definition is set to readOnly spring will change the flushMode to manual HibernateJpaDialect:45 -------------------------------- public Object beginTransaction(EntityManager entityManager, TransactionDefinition definition) throws PersistenceException, SQLException, TransactionException { super.beginTransaction(entityManager, definition); Session session = getSession(entityManager); FlushMode flushMode = session.getFlushMode(); FlushMode previousFlushMode = null; if (definition.isReadOnly()) { // We should suppress flushing for a read-only transaction. session.setFlushMode(FlushMode.MANUAL); previousFlushMode = flushMode; } else { // We need AUTO or COMMIT for a non-read-only transaction. if (flushMode.lessThan(FlushMode.COMMIT)) { session.setFlushMode(FlushMode.AUTO); previousFlushMode = flushMode; } } return new SessionTransactionData(session, previousFlushMode); } Perhaps SpringTransaction should set should pass readOnly transaction def to Spring when the flushMode is manual. Current Workaround: use DefaultJpaDialect -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 10 months

2
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2668) @In(value="selectedCountry",create=true) private Country editedCountry;

by Bernard Labno (JIRA)

@In(value="selectedCountry",create=true) private Country editedCountry; ----------------------------------------------------------------------- Key: JBSEAM-2668 URL: http://jira.jboss.com/jira/browse/JBSEAM-2668 Project: JBoss Seam Issue Type: Bug Components: Core Affects Versions: 2.0.1.CR1 Environment: linux Reporter: Bernard Labno @In(value="selectedCountry",create=true) private Country editedCountry; When bean is invoked, then "editedCountry" is null ! Of course there is no "selectedCountry" in any context. This happens only if "value" is set to something different than "editedCountry" (so the name of property). Following for example works : @In(value="editedCountry",create=true) private Country editedCountry; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 10 months

2
2
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2423) checkEntityPermission only checks one method

by Andrew (JIRA)

checkEntityPermission only checks one method -------------------------------------------- Key: JBSEAM-2423 URL: http://jira.jboss.com/jira/browse/JBSEAM-2423 Project: JBoss Seam Issue Type: Bug Components: Security Affects Versions: 2.0.1.CR1 Environment: JPA on tomcat6 Reporter: Andrew Priority: Critical If an entity has more than one method marked as @PrePersist, only one method is used to check for security. All methods should be considered and the result "anded" together. Code in the Identity bean only checks for a @Restrict on the first method found. In my case, I extend an object with a @PrePersist with no @Restrict. My entity has a method: @PrePersist @PreUpdate @PreRemove @Restrict public void beforeChange() {} (everything is restricted except for read access) According to the PrePersist documentation, multiple PrePersist methods are valid. There are workarounds, but this is dangerous code. If it were not for my unit tests it could have slipped through. The seam documentation does not mention this limitation I marked this as critical as it creates security holes in the application. Here is the relevant code: public void checkEntityPermission(Object entity, EntityAction action) { isLoggedIn(true); PersistenceProvider provider = PersistenceProvider.instance(); Class beanClass = provider.getBeanClass(entity); if (beanClass != null) { String name = Seam.getComponentName(entity.getClass()); if (name == null) name = beanClass.getName(); Method m = null; switch (action) { case READ: m = provider.getPostLoadMethod(beanClass); break; case INSERT: m = provider.getPrePersistMethod(beanClass); break; case UPDATE: m = provider.getPreUpdateMethod(beanClass); break; case DELETE: m = provider.getPreRemoveMethod(beanClass); } Restrict restrict = null; if (m != null && m.isAnnotationPresent(Restrict.class)) { restrict = m.getAnnotation(Restrict.class); } else if (entity.getClass().isAnnotationPresent(Restrict.class)) { restrict = entity.getClass().getAnnotation(Restrict.class); } if (restrict != null) { if (Strings.isEmpty(restrict.value())) { checkPermission(name, action.toString(), entity); } else { checkRestriction(restrict.value()); } } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 10 months

3
5
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2586) Green arrows to hide/show the FAQ browser control are *very* nonintuitive

by Gavin King (JIRA)

Green arrows to hide/show the FAQ browser control are *very* nonintuitive ------------------------------------------------------------------------- Key: JBSEAM-2586 URL: http://jira.jboss.com/jira/browse/JBSEAM-2586 Project: JBoss Seam Issue Type: Bug Components: Wiki Reporter: Gavin King Assigned To: Christian Bauer Priority: Trivial The green arrow that shows/hides the browser *looks* like a navigation control (the left/right green arrows are!), it doesnt look at all like a show/hide button. Took me minutes to figure out what it does! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 10 months

2
1
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2653) Posted timestamp comes from creating document and not saving

by Nicklas Karlsson (JIRA)

Posted timestamp comes from creating document and not saving ------------------------------------------------------------ Key: JBSEAM-2653 URL: http://jira.jboss.com/jira/browse/JBSEAM-2653 Project: JBoss Seam Issue Type: Bug Components: Wiki Reporter: Nicklas Karlsson Assigned To: Christian Bauer Minor one here: The posted timestamp from forum postings (and other documents?) should be updated when save is clicked. Now it is populated at creation time which means that a long post might end up fifth or sixth in the list. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 11 months

2
1
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2625) Avoid rescanning taglib.xml (and logging) for Seam mail rendering

by Christian Bauer (JIRA)

Avoid rescanning taglib.xml (and logging) for Seam mail rendering ----------------------------------------------------------------- Key: JBSEAM-2625 URL: http://jira.jboss.com/jira/browse/JBSEAM-2625 Project: JBoss Seam Issue Type: Task Components: Mail Reporter: Christian Bauer Assigned To: Pete Muir Priority: Minor Stop Seam Mail doing the whole rescan for taglib.xml each time it sends an email. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 11 months

3
6
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2617) "Solved" concept in threads

by Nicklas Karlsson (JIRA)

"Solved" concept in threads --------------------------- Key: JBSEAM-2617 URL: http://jira.jboss.com/jira/browse/JBSEAM-2617 Project: JBoss Seam Issue Type: Feature Request Components: Wiki Reporter: Nicklas Karlsson Assigned To: Christian Bauer Addition of a boolean field "solved" to threads that would be toggleable by the original poster to indicate that a solution has been found. Solved threads would have some sort of "!" or other similar icon in thread list. This feature could be used to indicate that help is still (or no longer) required. It could also be convinient to be able to use the solved field in searches -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 11 months

3
8
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2647) Consider making User summary page a wikitext document

by Gavin King (JIRA)

Consider making User summary page a wikitext document ----------------------------------------------------- Key: JBSEAM-2647 URL: http://jira.jboss.com/jira/browse/JBSEAM-2647 Project: JBoss Seam Issue Type: Feature Request Components: Wiki Reporter: Gavin King Assigned To: Christian Bauer Priority: Minor I think the /user/gavin page should actually be /User/gavin, ie. a wiki document in the User area that is automagically created when the user account is registered. ie. a bit like the blog homepage on in.relation.to. That way people can customize it like we do for our blog homepages. They could even syndicate their blog onto their user summary page, which would be very cool! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 11 months

2
3
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2632) Posting replies to a forum comment in flat view breaks threading

by Gavin King (JIRA)

Posting replies to a forum comment in flat view breaks threading ----------------------------------------------------------------- Key: JBSEAM-2632 URL: http://jira.jboss.com/jira/browse/JBSEAM-2632 Project: JBoss Seam Issue Type: Bug Components: Wiki Reporter: Gavin King Assigned To: Christian Bauer If you post a reply to a forum comment in flat view, and then go back to threaded view, the thread is broken. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 11 months

2
1
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2623) Hide member search from non-logged-in users

by Gavin King (JIRA)

Hide member search from non-logged-in users ------------------------------------------- Key: JBSEAM-2623 URL: http://jira.jboss.com/jira/browse/JBSEAM-2623 Project: JBoss Seam Issue Type: Feature Request Components: Wiki Reporter: Gavin King Assigned To: Christian Bauer userList page should be only for logged-in users. Guests don't have any reason to need to search our user db! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 11 months

2
2
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

seam-issues February 2008