[JBoss JIRA] (JBSEAM-5073) Programmatic redirect always add conversation id
by Marek Schmidt (JIRA)
[ https://issues.jboss.org/browse/JBSEAM-5073?page=com.atlassian.jira.plugi... ]
Marek Schmidt commented on JBSEAM-5073:
---------------------------------------
Sorry, must have missed it... I like your patch better.
> Programmatic redirect always add conversation id
> ------------------------------------------------
>
> Key: JBSEAM-5073
> URL: https://issues.jboss.org/browse/JBSEAM-5073
> Project: Seam 2
> Issue Type: Bug
> Components: JSF Integration
> Affects Versions: 2.3.1.CR1
> Environment: Seam 2.3.1-SNAPSHOT (2013-01-31)
> Reporter: Marek Schmidt
> Assignee: Marek Novotny
> Priority: Critical
> Fix For: 2.3.1.CR1
>
>
> Seam redirect always propagates conversation, even when explicitly told not to. The following code works in Seam 2.2, but now it redirects with the conversation id:
> {code}
> Redirect redirect = Redirect.instance();
> redirect.setConversationPropagationEnabled(false);
> redirect.setViewId("/output.xhtml");
> redirect.execute();
> {code}
> This also propagates conversation:
> {code}
> FacesManager.instance().redirect("/output.xhtml", null, false, false);
> {code}
> The problem is likely in SeamViewHandler, which adds the cids. even with redirects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBSEAM-5073) Programmatic redirect always add conversation id
by Tiago Peruzzo (JIRA)
[ https://issues.jboss.org/browse/JBSEAM-5073?page=com.atlassian.jira.plugi... ]
Tiago Peruzzo commented on JBSEAM-5073:
---------------------------------------
Marek, I created an issue with a bug like this and attached a patch and class tests.
https://issues.jboss.org/browse/JBSEAM-5066
> Programmatic redirect always add conversation id
> ------------------------------------------------
>
> Key: JBSEAM-5073
> URL: https://issues.jboss.org/browse/JBSEAM-5073
> Project: Seam 2
> Issue Type: Bug
> Components: JSF Integration
> Affects Versions: 2.3.1.CR1
> Environment: Seam 2.3.1-SNAPSHOT (2013-01-31)
> Reporter: Marek Schmidt
> Assignee: Marek Novotny
> Priority: Critical
> Fix For: 2.3.1.CR1
>
>
> Seam redirect always propagates conversation, even when explicitly told not to. The following code works in Seam 2.2, but now it redirects with the conversation id:
> {code}
> Redirect redirect = Redirect.instance();
> redirect.setConversationPropagationEnabled(false);
> redirect.setViewId("/output.xhtml");
> redirect.execute();
> {code}
> This also propagates conversation:
> {code}
> FacesManager.instance().redirect("/output.xhtml", null, false, false);
> {code}
> The problem is likely in SeamViewHandler, which adds the cids. even with redirects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBSEAM-5073) Programmatic redirect always add conversation id
by Marek Schmidt (JIRA)
[ https://issues.jboss.org/browse/JBSEAM-5073?page=com.atlassian.jira.plugi... ]
Marek Schmidt commented on JBSEAM-5073:
---------------------------------------
a possible solution could perhaps be to check for Contexts.getEventContext().isSet(REDIRECT_FROM_MANAGER) in the SeamViewHandler and modify FacesManager to set the REDIRECT_FROM_MANAGER before calling getViewHandler().getActionURL
(similar to RedirectFilter)
> Programmatic redirect always add conversation id
> ------------------------------------------------
>
> Key: JBSEAM-5073
> URL: https://issues.jboss.org/browse/JBSEAM-5073
> Project: Seam 2
> Issue Type: Bug
> Components: JSF Integration
> Affects Versions: 2.3.1.CR1
> Environment: Seam 2.3.1-SNAPSHOT (2013-01-31)
> Reporter: Marek Schmidt
> Assignee: Marek Novotny
> Priority: Critical
> Fix For: 2.3.1.CR1
>
>
> Seam redirect always propagates conversation, even when explicitly told not to. The following code works in Seam 2.2, but now it redirects with the conversation id:
> {code}
> Redirect redirect = Redirect.instance();
> redirect.setConversationPropagationEnabled(false);
> redirect.setViewId("/output.xhtml");
> redirect.execute();
> {code}
> This also propagates conversation:
> {code}
> FacesManager.instance().redirect("/output.xhtml", null, false, false);
> {code}
> The problem is likely in SeamViewHandler, which adds the cids. even with redirects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBSEAM-3901) Conversation id is always propagated on redirects
by Marek Schmidt (JIRA)
[ https://issues.jboss.org/browse/JBSEAM-3901?page=com.atlassian.jira.plugi... ]
Marek Schmidt edited comment on JBSEAM-3901 at 1/31/13 11:51 AM:
-----------------------------------------------------------------
comment deleted, wrong issue :)
was (Author: maschmid):
a possible solution could perhaps be to check for Contexts.getEventContext().isSet(REDIRECT_FROM_MANAGER) in the SeamViewHandler and modify FacesManager to set the REDIRECT_FROM_MANAGER before calling getViewHandler().getActionURL
(similar to RedirectFilter)
> Conversation id is always propagated on redirects
> -------------------------------------------------
>
> Key: JBSEAM-3901
> URL: https://issues.jboss.org/browse/JBSEAM-3901
> Project: Seam 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.1.GA
> Reporter: Preben Ludviksen
> Labels: conversations, redirect
>
> According to the documentation, propagation of conversation id's on redirects is controlled by the redirect-filter:
> http://docs.jboss.com/seam/2.1.1.GA/reference/en-US/html/configuration.ht...
> However, the id propagates even if the filter is swithced off in components.xml:
>
> <web:redirect-filter disabled="true" installed="false"/>
> When redirecting using pages.xml:
>
> <page view-id="/login.xhtml">
> <navigation>
> <rule if-outcome="success">
> <redirect view-id="/servers.xhtml" />
> </rule>
> </navigation>
> </page>
> According to the Seam user Peter Hilton in the referenced forum thread:
> "The <redirect/> results in a call to org.jboss.seam.faces.FacesManager.redirect(String viewId, Map<String, Object> parameters, boolean includeConversationId)
> This is called from the following code in org.jboss.seam.faces.Navigator which sets includeConversationId to true:
> FacesManager.instance().redirect(viewId, parameters, true);"
> The propagation should be possible to disable for use cases where you don't really rely on conversations, and don't want to clutter the URL. I have also posted a feature request to allow disabling of the propagation on a per-redirect basis:
> https://jira.jboss.org/jira/browse/JBSEAM-3902
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBSEAM-3901) Conversation id is always propagated on redirects
by Marek Schmidt (JIRA)
[ https://issues.jboss.org/browse/JBSEAM-3901?page=com.atlassian.jira.plugi... ]
Marek Schmidt edited comment on JBSEAM-3901 at 1/31/13 11:49 AM:
-----------------------------------------------------------------
a possible solution could perhaps be to check for Contexts.getEventContext().isSet(REDIRECT_FROM_MANAGER) in the SeamViewHandler and modify FacesManager to set the REDIRECT_FROM_MANAGER before calling getViewHandler().getActionURL
(similar to RedirectFilter)
was (Author: maschmid):
a possible solution could perhaps be to check for Contexts.getEventContext().isSet(REDIRECT_FROM_MANAGER) in the SeamViewHandler and modify FacesManager to set the REDIRECT_FROM_MANAGER before calling getViewHandler().getActionURL
> Conversation id is always propagated on redirects
> -------------------------------------------------
>
> Key: JBSEAM-3901
> URL: https://issues.jboss.org/browse/JBSEAM-3901
> Project: Seam 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.1.GA
> Reporter: Preben Ludviksen
> Labels: conversations, redirect
>
> According to the documentation, propagation of conversation id's on redirects is controlled by the redirect-filter:
> http://docs.jboss.com/seam/2.1.1.GA/reference/en-US/html/configuration.ht...
> However, the id propagates even if the filter is swithced off in components.xml:
>
> <web:redirect-filter disabled="true" installed="false"/>
> When redirecting using pages.xml:
>
> <page view-id="/login.xhtml">
> <navigation>
> <rule if-outcome="success">
> <redirect view-id="/servers.xhtml" />
> </rule>
> </navigation>
> </page>
> According to the Seam user Peter Hilton in the referenced forum thread:
> "The <redirect/> results in a call to org.jboss.seam.faces.FacesManager.redirect(String viewId, Map<String, Object> parameters, boolean includeConversationId)
> This is called from the following code in org.jboss.seam.faces.Navigator which sets includeConversationId to true:
> FacesManager.instance().redirect(viewId, parameters, true);"
> The propagation should be possible to disable for use cases where you don't really rely on conversations, and don't want to clutter the URL. I have also posted a feature request to allow disabling of the propagation on a per-redirect basis:
> https://jira.jboss.org/jira/browse/JBSEAM-3902
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBSEAM-3901) Conversation id is always propagated on redirects
by Marek Schmidt (JIRA)
[ https://issues.jboss.org/browse/JBSEAM-3901?page=com.atlassian.jira.plugi... ]
Marek Schmidt commented on JBSEAM-3901:
---------------------------------------
a possible solution could perhaps be to check for Contexts.getEventContext().isSet(REDIRECT_FROM_MANAGER) in the SeamViewHandler and modify FacesManager to set the REDIRECT_FROM_MANAGER before calling getViewHandler().getActionURL
> Conversation id is always propagated on redirects
> -------------------------------------------------
>
> Key: JBSEAM-3901
> URL: https://issues.jboss.org/browse/JBSEAM-3901
> Project: Seam 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.1.GA
> Reporter: Preben Ludviksen
> Labels: conversations, redirect
>
> According to the documentation, propagation of conversation id's on redirects is controlled by the redirect-filter:
> http://docs.jboss.com/seam/2.1.1.GA/reference/en-US/html/configuration.ht...
> However, the id propagates even if the filter is swithced off in components.xml:
>
> <web:redirect-filter disabled="true" installed="false"/>
> When redirecting using pages.xml:
>
> <page view-id="/login.xhtml">
> <navigation>
> <rule if-outcome="success">
> <redirect view-id="/servers.xhtml" />
> </rule>
> </navigation>
> </page>
> According to the Seam user Peter Hilton in the referenced forum thread:
> "The <redirect/> results in a call to org.jboss.seam.faces.FacesManager.redirect(String viewId, Map<String, Object> parameters, boolean includeConversationId)
> This is called from the following code in org.jboss.seam.faces.Navigator which sets includeConversationId to true:
> FacesManager.instance().redirect(viewId, parameters, true);"
> The propagation should be possible to disable for use cases where you don't really rely on conversations, and don't want to clutter the URL. I have also posted a feature request to allow disabling of the propagation on a per-redirect basis:
> https://jira.jboss.org/jira/browse/JBSEAM-3902
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
[JBoss JIRA] (JBSEAM-5073) Programmatic redirect always add conversation id
by Marek Schmidt (JIRA)
Marek Schmidt created JBSEAM-5073:
-------------------------------------
Summary: Programmatic redirect always add conversation id
Key: JBSEAM-5073
URL: https://issues.jboss.org/browse/JBSEAM-5073
Project: Seam 2
Issue Type: Bug
Components: JSF Integration
Affects Versions: 2.3.1.CR1
Environment: Seam 2.3.1-SNAPSHOT (2013-01-31)
Reporter: Marek Schmidt
Assignee: Marek Novotny
Priority: Critical
Fix For: 2.3.1.CR1
Seam redirect always propagates conversation, even when explicitly told not to. The following code works in Seam 2.2, but now it redirects with the conversation id:
{code}
Redirect redirect = Redirect.instance();
redirect.setConversationPropagationEnabled(false);
redirect.setViewId("/output.xhtml");
redirect.execute();
{code}
This also propagates conversation:
{code}
FacesManager.instance().redirect("/output.xhtml", null, false, false);
{code}
The problem is likely in SeamViewHandler, which adds the cids. even with redirects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months