[seam-issues] [JBoss JIRA] Commented: (SEAMINTL-1) TimeZone handling based on Seam 2

[ https://jira.jboss.org/jira/browse/SEAMINTL-1?page=com.atlassian.jira.plu... ] Pete Muir commented on SEAMINTL-1: ---------------------------------- The line between preventing conflicts and becoming hard to use is fine - that is why review is there :-) The difference between @Inject and @PostConstruct is semantic in this case only (though @PostConstruct is run after all injections, including method injection). The reason I made this comment is that it looks very odd to have a method marked @Inject that doesn't perform injection. IOW the difference is just around code clarity. With TimeZoneWrapper, I suggest creating a ForwardingTimeZone class (take a look at the Weld code base or Google Collections for what this should look like) which is just responsible for the "wrapping" aspect of the work, then create (e.g.) a PrettyTimeZone class which extends it and applies the extra logic. I mean the package of the test should not be one of the packages used in runtime code - it is confusing to read and to browse classes e.g. in Eclipse find class view otherwise. You can apply qualifiers to raised events. Just raise an event like: @Inject @Changed Event<TimeZone> event; event.fire(newTimeZone); BTW make sure you are in contact with Lincoln on this, as I know he wants to bring PrettyTime into the mix too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira