[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2598) Exception handling - Never log and handle an exception, do one or the other
[
https://jira.jboss.org/jira/browse/JBSEAM-2598?page=com.atlassian.jira.pl...
]
Christian Bauer commented on JBSEAM-2598:
-----------------------------------------
Coming back to the last case:
GET request, exception during rendering in value binding getter
-------------------------------------------------------------
ERROR [STDERR] Feb 19, 2008 10:32:12 AM com.sun.facelets.FaceletViewHandler
handleRenderException [stacktrace of ELException]
ERROR [STDERR] tions.invoke(Reflections.java:21) [obscure stacktrace and THIS IS ALWAYS
RANDOMLY CUT OFF, WHY?!]
WARN [javax.enterprise.resource.webcontainer.jsf.lifecycle] executePhase(RENDER_RESPONSE
6,com.sun.faces.context.FacesContextImpl@64a989) threw exception [same stacktrace as first
message]
ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/wiki].[Faces
Servlet]] Servlet.service() for servlet Faces Servlet threw exception [just the root cause
stacktrace]
WARN [org.jboss.seam.web.ExceptionFilter] handling uncaught exception [again the full
stacktrace]
WARN [org.jboss.seam.web.ExceptionFilter] exception root cause [and again the full
stacktrace]
WARN [org.jboss.seam.web.ExceptionFilter] running exception handlers
ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/wiki].[default]]
Servlet.service() for servlet default threw exception [just the root cause stacktrace]
The first ERROR line I got rid of by overriding
FaceletViewHandler.handleRenderException(), which logs and rethrows. This code should be
fixed in Facelets.
The second ERROR line no longer occurs, fine by me.
The third ERROR line is very mysterious, apparently Tomcat thinks it also needs to log and
handle the exception. I can't find the code responsible for this. Same for the last
ERROR line.
The WARNs are no problem, we can disable it in the applications log4j.xml.
Exception handling - Never log and handle an exception, do one or the
other
---------------------------------------------------------------------------
Key: JBSEAM-2598
URL: https://jira.jboss.org/jira/browse/JBSEAM-2598
Project: Seam
Issue Type: Feature Request
Components: Exception Handling
Reporter: Shane Bryzak
Assignee: Christian Bauer
Fix For: The future
Either I see my exception in the log (because it is one of the VERY
RARE silently recoverable exceptions - I would not know a single one)
or it is handled by my exception handler. Actually, I should never see
an exception in my log unless I say so in my exception handler. I've
seen Shane doing some commits about this but he only made logging
configurable in Exceptions.handle(), which runs AFTER
SeamPhaseListener already dumps a log.error("Uncaught exception", e).
So basically, you can now configure if you want an exception logged
twice or just once. This is btw killing me in production because my
log fills up with login-password failures if someone makes a typo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira