[seam-issues] [JBoss JIRA] Commented: (SOLDER-85) Better separation of i18n and logging concerns
[
https://issues.jboss.org/browse/SOLDER-85?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-85:
---------------------------------
The TypedCategory does not get moved from api to impl. That was an incorrect statement. It
was the TypedLogger and TypedMessageBundle that needed to be moved, which has already
happened.
Please move the test to
org.jboss.seam.solder.test.messages.MesageBundleAndLoggerInjectionTest
I would like to fix the names of the extension and the producers too, but only after
final, as that's a purely internal change.
Better separation of i18n and logging concerns
----------------------------------------------
Key: SOLDER-85
URL: https://issues.jboss.org/browse/SOLDER-85
Project: Seam Solder
Issue Type: Enhancement
Components: Core, Documentation, Logging
Affects Versions: 3.0.0.CR2
Reporter: Ken Finnigan
Assignee: Ken Finnigan
Fix For: 3.0.0.Final
Currently we have the following classes within the api:
org.jboss.seam.solder.log.Category
org.jboss.seam.solder.log.Locale
org.jboss.seam.solder.log.Suffix
org.jboss.seam.solder.log.TypedCategory
org.jboss.seam.solder.logging.Cause
org.jboss.seam.solder.logging.FormatWith
org.jboss.seam.solder.logging.LogMessage
org.jboss.seam.solder.logging.Message
org.jboss.seam.solder.logging.MessageBundle
org.jboss.seam.solder.logging.MessageBundleInvocationHandler
org.jboss.seam.solder.logging.MessageLogger
org.jboss.seam.solder.logging.MessageLoggerInvocationHandler
org.jboss.seam.solder.logging.Messages
org.jboss.seam.solder.logging.StatusMessage
And in the impl we have:
org.jboss.seam.solder.log.LoggerExtension
org.jboss.seam.solder.log.LoggerProducers
org.jboss.seam.solder.log.TypedLogger
org.jboss.seam.solder.log.TypedMessageBundle
The proposal is the following:
- Rename package in impl to be org.jboss.seam.solder.logging
- Move TypedCategory from api to impl
- Remove org.jboss.seam.solder.logging.StatusMessage, as this will be implemented within
Seam i18n
- Rename FormatWith to Formatter
- Rename LogMessage to Log
- Move/Rename packages to result in the following contents of the api:
org.jboss.seam.solder.logging.Category
org.jboss.seam.solder.logging.Cause
org.jboss.seam.solder.logging.Log
org.jboss.seam.solder.logging.MessageLogger
org.jboss.seam.solder.logging.MessageLoggerInvocationHandler
org.jboss.seam.solder.logging.Suffix
org.jboss.seam.solder.messages.Formatter
org.jboss.seam.solder.messages.Locale
org.jboss.seam.solder.messages.Message
org.jboss.seam.solder.messages.MessageBundle
org.jboss.seam.solder.messages.MessageBundleInvocationHandler
org.jboss.seam.solder.messages.Messages
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira