[
https://jira.jboss.org/jira/browse/JBSEAM-3120?page=com.atlassian.jira.pl...
]
Pete Muir closed JBSEAM-3120.
-----------------------------
Resolution: Done
Thanks Alex, I applied your patch.
In future (as I am lazy :-P) please make sure you minimize white space changes in your
patch, keep coding style consistent, and don't depend on commons-stuff :-)
SeamCollectionModel in Seam-Trinidad example is not handling the
sorting in the most efficient way
--------------------------------------------------------------------------------------------------
Key: JBSEAM-3120
URL:
https://jira.jboss.org/jira/browse/JBSEAM-3120
Project: Seam
Issue Type: Bug
Components: Examples
Affects Versions: 2.0.3.CR1
Reporter: Alex Savitsky
Assignee: Pete Muir
Priority: Optional
Fix For: The future
Attachments: patch.txt
The way the sorting is handled in SeamCollectionModel, is not anywhere near optimal. I
undernstand that this is only an example, but since people often just paste this into the
real apps, it might as well be a little more polished. The way the setSortCriteria is
coded up, a new query will be issued every time this method is called, as Query.setOrder
triggers an automatic refresh(), which wipes out the data model in the process - thus
forcing the creation of a new one, which won't have the criteria property set.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira