[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
2:13 p.m.
Ending nested conversation causes issues with pages.xml and rendering the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=all ]
Andrew updated JBSEAM-1243:
---------------------------
Attachment: JBSEAM-1243.zip
Here are the necessary files to reproduce the issue. It isn't a full project, but can
easily be put into any JSF1.1/A4J/Seam/Facelets project.
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:52 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=all ]
Gavin King closed JBSEAM-1243.
------------------------------
Fix Version/s: 1.3.0.BETA1
Resolution: Done
Assignee: Gavin King
Thanks, fixed in CVS, please test.
The fix was this in Pages:
private boolean isNoConversationRedirectRequired(Page page)
{
return page.isConversationRequired() &&
!Manager.instance().isLongRunningOrNestedConversation();
}
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:30 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=all ]
Andrew reopened JBSEAM-1243:
----------------------------
I'm not sure how this can fix the issue. In 1.1.6, the code is:
if ( page.isConversationRequired() &&
!Manager.instance().isLongRunningConversation() )
{
Manager.instance().redirectToNoConversationView();
return result;
}
This looks like the same code in your comment above. This is the broken code. The problem
that I found was not in Pages.java, but rather in Manager.java.
The problem is that "Manager.instance().isLongRunningConversation() " returns
false if a nested conversation has been ended when it shouldn't. It should only return
false if the parent conversation has been ended.
Please correct me if I am in error.
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:37 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=comments#action_12361186 ]
Andrew commented on JBSEAM-1243:
--------------------------------
Code from Manager.java in CVS:
739: public void endConversation(boolean beforeRedirect)
740: {
741: log.debug("Ending long-running conversation");
742: if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.endConversation");
743: setLongRunningConversation(false);
744: destroyBeforeRedirect = beforeRedirect;
745: endNestedConversations( getCurrentConversationId() );
746: storeConversationToViewRootIfNecessary();
747: }
The problem is from line 743. It never checks to see if the conversation it is ending is a
nested conversation. It always sets that there is no conversation.
Perhaps it should be:
743: setLongRunningConversation(!isNestedConversation());
And then somewhere on a new line after this, the parent conversation should be restored I
think.
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:49 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=all ]
Gavin King closed JBSEAM-1243.
------------------------------
Resolution: Done
Re-read the code I wrote. It is NOT the same.
please don't reopen issues without taking the time to properly investigate. Thanks.
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=comments#action_12362188 ]
Andrew commented on JBSEAM-1243:
--------------------------------
Gavin, my sincerest apologies for the over-sight. I did investigate the fix, but somehow
missed the significance of the change. I was able to confirm that the fix also works in
1.1.6 by changing "Manager.instance().isLongRunningConversation()" to
"!Manager.instance().isLongRunningOrNestedConversation()"
Thank you and sorry again for the extra trouble
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again
[ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=comments#action_12362593 ]
Gavin King commented on JBSEAM-1243:
------------------------------------
np, thanks.
Ending nested conversation causes issues with pages.xml and rendering
the same view again
-----------------------------------------------------------------------------------------
Key: JBSEAM-1243
URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.6.GA
Reporter: Andrew
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1243.zip
See JBoss Forum Reference of this bug.
Will try to attach reproduce code in a bit.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6444
days inactive
6469
days old
7 comments
2 participants
participants (2)
-
Andrew (JIRA) -
Gavin King (JIRA)