[JBoss JIRA] Created: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
10:10 p.m.
UIInputContainer should accept ValueExpression for the label attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 a.m.
New subject: [JBoss JIRA] Assigned: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
[
https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plu...
]
José Freitas reassigned SEAMFACES-133:
--------------------------------------
Assignee: José Freitas
UIInputContainer should accept ValueExpression for the label
attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
Assignee: José Freitas
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:47 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
[
https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plu...
]
José Freitas commented on SEAMFACES-133:
----------------------------------------
It seems to be a Mojarra bug. For some reason, it is not filling the UIComponentBase
Attribute Map with "label" key if label attr has an EL value.
I believe the issue below is related:
http://java.net/jira/browse/JAVASERVERFACES-1782
I've made a workaround and it's working, but I'll first make sure that
it's a mojarra bug before pulling a request.
UIInputContainer should accept ValueExpression for the label
attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
Assignee: José Freitas
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:16 p.m.
New subject: [JBoss JIRA] Resolved: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
[
https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plu...
]
Brian Leathem resolved SEAMFACES-133.
-------------------------------------
Fix Version/s: 3.0.2
Resolution: Done
UIInputContainer should accept ValueExpression for the label
attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
Assignee: José Freitas
Fix For: 3.0.2
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:54 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
[
https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plu...
]
Alt Avatar commented on SEAMFACES-133:
--------------------------------------
The workaround is better, but not ideal IMO.
In some, albeit rare, cases, you could want to specify an empty string label explicitly
like, and not want the auto label generation to run.
x:input label=""
IIRC, this use-case was supported previously, but doesn't work with the workaround.
I can workaround this issue with a disableLabel cc.attrs, but it might still be worth
considering this regression.
UIInputContainer should accept ValueExpression for the label
attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
Assignee: José Freitas
Fix For: 3.0.2
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
[
https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plu...
]
Alt Avatar commented on SEAMFACES-133:
--------------------------------------
Also, labelHasEmptyValue() should handle the case of there being no label at all.
Currently, it will fail with a NPE.
I was also getting cases were labelValue in the same method would be null. I fixed both
issues by replacing the body of UIInputContainer.java#labelHasEmptyValue() with:
HtmlOutputLabel label = elements.getLabel();
if (label==null)
return false;
Object labelValue = label.getValue();
if (labelValue==null)
return false;
return (labelValue.toString().trim().equals(":") || labelValue.toString()
.trim().equals(""));
UIInputContainer should accept ValueExpression for the label
attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
Assignee: José Freitas
Fix For: 3.0.2
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:02 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.
[
https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plu...
]
José Freitas commented on SEAMFACES-133:
----------------------------------------
yes, you're right, there's the case where a user won't use our compcomp and it
might be built without a label. thanks.
about the empty label, I guess that filling the value even if its empty is a nice
feature.
we might develop another attribute like emptylabel = "true" to force it to be
empty though. if you like the idea, could you fire a jira issue as an enhancement?
UIInputContainer should accept ValueExpression for the label
attribute.
-----------------------------------------------------------------------
Key: SEAMFACES-133
URL: https://issues.jboss.org/browse/SEAMFACES-133
Project: Seam Faces
Issue Type: Bug
Components: UI Components
Affects Versions: 3.0.0.Final
Environment: Ubuntu 10.10 64bit, JBoss 6
Reporter: Alt Avatar
Assignee: José Freitas
Fix For: 3.0.2
UIInputContainer should evaluate ValueExpressions for the "label" attribute.
This is especially useful for internationalization, where the component could be included
as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
Currently, ValueExpressions are ignored and only String literals work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4956
days inactive
5012
days old
6 comments
3 participants
participants (3)
-
Alt Avatar (JIRA) -
Brian Leathem (JIRA)
-
José Freitas (JIRA)