[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] Nicklas Karlsson commented on SEAMINTL-15: ------------------------------------------ One way of doing this would perhaps to @Inject an Instance of something into Bundles and then have a @PostConstruct or @Inject constructor check if there is something injected that would then be assimilated. This something could perhaps be a Map<String, ResourceBundle> that would be passed along to putAll. Users could then write producers for resource bundles they'd like automatically made available. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] Ken Finnigan updated SEAMINTL-15: --------------------------------- Fix Version/s: (was: 3.0.0.Beta2) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] Nicklas Karlsson edited comment on SEAMINTL-15 at 8/3/11 3:51 AM: ------------------------------------------------------------------ It could be done quite cheap with a {code} public interface BundleLoader { public ResourceBundle loadBundle(Locale locale, String key); } {code} And in ApplicationBundles {code} @Inject BundleLoader loader; {code} {code} public ResourceBundle get(final Locale locale, final Object key) { containsLocaleMap(locale); if (!bundles.get(locale).containsKey(key)) { ResourceBundle bundle = loader.loadBundle(locale, key.toString()); put(locale, key.toString(), bundle); } return bundles.get(locale).get(key); } {code} with the default implementation being the ResouceBundle.load(...) and people could then @Specialize this and have DB-based bundles, lazy loading etc... was (Author: nickarls): It could be done quite cheap with a public interface BundleLoader { public ResourceBundle loadBundle(Locale locale, String key); } And in ApplicationBundles @Inject BundleLoader loader; public ResourceBundle get(final Locale locale, final Object key) { containsLocaleMap(locale); if (!bundles.get(locale).containsKey(key)) { ResourceBundle bundle = loader.loadBundle(locale, key.toString()); put(locale, key.toString(), bundle); } return bundles.get(locale).get(key); } with the default implementation being the ResouceBundle.load(...) and people could then @Specialize this and have DB-based bundles, lazy loading etc... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] Nicklas Karlsson commented on SEAMINTL-15: ------------------------------------------ Perhaps the BundleLoader should be a Instance<BundleLoader> that would be used if the user has provided one and then the fallback would be the ResourceBundle.loadBundle() -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] José Freitas edited comment on SEAMINTL-15 at 8/4/11 8:44 AM: -------------------------------------------------------------- I like the first solution (the one with a class responsible only for loading bundles. 'loader.loadBundle'). It's quite simple and it will help a lot on extending the way we could load data for our resourcebundle. was (Author: spinner): I like the first solution (the one with a class responsible only for loading bundles. -loader.loadBundle-). It's quite simple and it will help a lot on extending the way we could load data for our resourcebundle. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] Ken Finnigan commented on SEAMINTL-15: -------------------------------------- That's fine Nicklas, are you putting together a pull request for this JIRA? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMINTL-15?page=com.atlassian.jira.plugi... ] Nicklas Karlsson updated SEAMINTL-15: ------------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/seam/international/pull/23 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira