[ https://issues.jboss.org/browse/SEAMFACES-165?page=com.atlassian.jira.plu... ] Christian Kaltepoth commented on SEAMFACES-165: ----------------------------------------------- I did some more research on this. Actually this seems to be a bug in Weld 1.1.0 and not in Seam Faces. Let me explain: {{SeamApplicationWrapper}} waits for the {{PostConstructApplicationEvent}} and then obtains the {{ApplicationFactory}} from the {{FactoryFinder}}. Then it calls {{ApplicationFactory.setApplication()}} to install the Seam Faces wrapper. With MyFaces the {{SeamApplicationWrapper}} gets the {{WeldApplicationFactory}} from the {{FactoryFinder}}. Unfortunately {{SeamApplicationWrapper}} ignores calls to {{setApplication()}} and simply delegates them to the underlying {{ApplicationFactory}}. The problem here is that {{SeamApplicationWrapper}} already holds a reference to the {{Application}} instance that it returns for {{getApplication()}} and doesn't update this reference when {{setApplication()}} is called. Therefore {{SeamApplicationWrapper}} will return the old {{Application}} instance on future calls to {{getApplication()}}. See the code of {{WeldApplicationFactory}}: https://github.com/weld/core/blob/master/environments/servlet/core/src/ma... For Mojarra the situation is a bit different. When using Mojarra Seam Faces calls {{setApplication()}} on Mohjarra's {{InjectionApplicationFactory}}, which wraps {{SeamApplicationWrapper}}. As {{InjectionApplicationFactory}} implements {{setApplication()}} correctly, the bug doesn't occur on Mojarra. Does this sound reasonable? If you agree to my explanation I could open a ticket for Weld regarding this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-165?page=com.atlassian.jira.plu... ] Christian Kaltepoth commented on SEAMFACES-165: ----------------------------------------------- Just a small update for everyone who gets hit by this. I'm currently using another {{ApplicationFactory}} wrapper as a workaround for this bug: {code} public class WeldBugfixApplicationFactory extends ApplicationFactory { private final ApplicationFactory delegate; private Application application; public WeldBugfixApplicationFactory(ApplicationFactory delegate) { this.delegate = delegate; } @Override public Application getApplication() { if(application == null) { application = delegate.getApplication(); } return application; } @Override public void setApplication(Application application) { this.application = application; delegate.setApplication(application); } } {code} This factory has to be added to your {{faces-config.xml}} like this: {code} <?xml version="1.0" encoding="UTF-8"?> <faces-config ....> <factory> <application-factory>com.example.WeldBugfixApplicationFactory</application-factory> </factory> </faces-config> {code} This works fine for me. Not a very nice workaround but now the injection also works with MyFaces. :) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-165?page=com.atlassian.jira.plu... ] Christian Kaltepoth commented on SEAMFACES-165: ----------------------------------------------- I think it should work fine with Mojarra. I see no reason why it shouldn't. The only important thing is that this factory must decorate {{WeldApplicationFactory}} and not the other way around. However I'm not sure if it is a good idea to include such a workaround in Seam Faces. Wouldn't it be nicer to simply add a {{SeamFacesApplicationFactory}} that creates wrapped {{Application}} instances in its {{getApplication()}} method? Just like {{SeamExternalContextFactory}} and {{CatchExceptionHandlerFactory}} do it? This way there would be no need to call {{setApplication()}} and so we won't be affected by the Weld bug any more. I'll build a prototype for this at the weekend. I think it will work fine this way. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-165?page=com.atlassian.jira.plu... ] Jason Porter commented on SEAMFACES-165: ---------------------------------------- I tried Faces 3.1.0.Beta2 with Mojarra (2.0.4) and MyFaces (2.0.6) and Tomcat (7.0.20) and this solution does not work. The ApplicationFactory is called before CDI finishes bootstrapping and the application dies trying to get a handle on the BeanManager. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-165?page=com.atlassian.jira.plu... ] Jason Porter updated SEAMFACES-165: ----------------------------------- Comment: was deleted (was: I tried Faces 3.1.0.Beta2 with Mojarra (2.0.4) and MyFaces (2.0.6) and Tomcat (7.0.20) and this solution does not work. The ApplicationFactory is called before CDI finishes bootstrapping and the application dies trying to get a handle on the BeanManager.) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira