[ http://jira.jboss.com/jira/browse/JBSEAM-1574?page=all ] Michael Youngstrom reopened JBSEAM-1574: ---------------------------------------- Ok, so I looked and I was unable to find the issue that broke this functionality so I went ahead and created a patch that fixes the problem for me. All I'm doing in this patch is executing page actions after the s:link s:button action/navigation which I think is the more correct way to handle this anyway since that is the same order h:commandLink/Button would work call the actions in. I threw in something to not call the actions if getResponseComplete since that is also how things would react if h:commandLink/Button were called. Go ahead and re-close if this solution still has the problem you mentioned about but I would like a little more information if you have it. Index: src/main/org/jboss/seam/navigation/Pages.java =================================================================== RCS file: /cvsroot/jboss/jboss-seam/src/main/org/jboss/seam/navigation/Pages.java,v retrieving revision 1.6 diff -u -r1.6 Pages.java --- src/main/org/jboss/seam/navigation/Pages.java 26 Jun 2007 16:54:13 -0000 1.6 +++ src/main/org/jboss/seam/navigation/Pages.java 5 Jul 2007 23:00:46 -0000 @@ -283,19 +283,22 @@ return false; } } - - //run the page actions, check permissions, - //handle conversation begin/end - boolean result = false; - for ( Page page: pageStack ) - { - result = page.preRender(facesContext) || result; - } - + //run the s:link / s:button action after checking the //conversation existence! - result = callAction(facesContext) || result; + boolean result = callAction(facesContext); + //run the page actions, check permissions, + //handle conversation begin/end + //If responseComplete then we're probably doing a redirect so don't call the page actions now. + if(!facesContext.getResponseComplete()) { + String newViewId = getViewId(facesContext); + for ( Page page: getPageStack(newViewId) ) + { + result = page.preRender(facesContext) || result; + } + } + return result; } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-1574?page=comments#action_12370201 ] Michael Youngstrom commented on JBSEAM-1574: -------------------------------------------- Ok, so here is a new patch taking into account Norman's comments: So now redirect and render will function the same with regard to page elements. Always the first thing executed would be the s:link action and then based on there result if we do a "render" then "no-conversation-view" will be checked for the new view id, "login-required" will be checked, and page actions will be executed. If the result is a "redirect" then none of that will occur for the old view id but it will all occur for the new view id. It appeared that this used to function in a buggy way. When a user would click on an s:link action and a redirect were to take place then all of these operations would happen twice once for the old view id and once for the new view id. I think this fixes this problem so page actions, login-required, and no-conversation-view now only take place once per action being processed and take place always for the new view-id. Much better in IMHO? Thoughts? Index: src/main/org/jboss/seam/navigation/Pages.java =================================================================== RCS file: /cvsroot/jboss/jboss-seam/src/main/org/jboss/seam/navigation/Pages.java,v retrieving revision 1.11 diff -u -r1.11 Pages.java --- src/main/org/jboss/seam/navigation/Pages.java 25 Jul 2007 14:40:31 -0000 1.11 +++ src/main/org/jboss/seam/navigation/Pages.java 26 Jul 2007 22:38:11 -0000 @@ -272,32 +270,36 @@ //redirect if necessary List<Page> pageStack = getPageStack(viewId); - for ( Page page: pageStack ) - { - if ( isNoConversationRedirectRequired(page) ) - { - redirectToNoConversationView(); - return false; + + //run the s:link / s:button action after checking the + //conversation existence! + boolean result = callAction(facesContext); + + //If responseComplete then we're probably doing a redirect so don't call the page actions now. + if(!facesContext.getResponseComplete()) { + for ( Page page: pageStack ) + { + if ( isNoConversationRedirectRequired(page) ) + { + redirectToNoConversationView(); + return false; + } + else if ( isLoginRedirectRequired(viewId, page) ) + { + redirectToLoginView(); + return false; + } } - else if ( isLoginRedirectRequired(viewId, page) ) - { - redirectToLoginView(); - return false; + + //run the page actions, check permissions, + //handle conversation begin/end + String newViewId = getViewId(facesContext); + for ( Page page: getPageStack(newViewId) ) + { + result = page.preRender(facesContext) || result; } } - //run the page actions, check permissions, - //handle conversation begin/end - boolean result = false; - for ( Page page: pageStack ) - { - result = page.preRender(facesContext) || result; - } - - //run the s:link / s:button action after checking the - //conversation existence! - result = callAction(facesContext) || result; - return result; } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira