[ http://jira.jboss.com/jira/browse/JBSEAM-2994?page=comments#action_12416884 ] Marcell Barbacena commented on JBSEAM-2994: ------------------------------------------- Could you detail what you want and I may be able to submit a patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2994?page=comments#action_12418500 ] Marcell Barbacena commented on JBSEAM-2994: ------------------------------------------- @In and @Out is already working right? Where would you want the @Begin and @End to be placed in a wicket component? Something like: new Link("bookHotel") { @Begin @Override public void onClick() { hotelBooking.bookHotel(); setResponsePage(Book.class); } }); And: @End @Restrict public class Hotel extends WebPage { ... } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2994?page=comments#action_12418535 ] Marcell Barbacena commented on JBSEAM-2994: ------------------------------------------- I know the @Target locations.... what I do not know is what you consider to be a wicket component in the context of seam for this annotations to wok. Is all methods in Page, Link, Panel, Border, etc., to be considered available to place Seam annotations? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2994?page=comments#action_12418633 ] Marcell Barbacena commented on JBSEAM-2994: ------------------------------------------- Well, maybe we do not need a classloader... We can attach a proxy of WebRequestCycleProcessor that the resolver method dynamically creates a proxy of the same type returned and that load the triggered method annotations. I do not know if it is possible to create this proxy with CGLib... Like: public class ProxyRequestCycleProcessor implements IRequestCycleProcessor { private IRequestCycleProcessor proxy; public IRequestTarget resolve(RequestCycle requestCycle, RequestParameters requestParameters) { IRequestTarget target = proxy.resolve(requestCycle, requestParameters); return createSeamProxy(target); } private IRequestTarget createSeamProxy(IRequestTarget target) { // creates a proxy using this cglib method interceptor // public Object intercept(Object object, Method method, Object[] args, MethodProxy proxy) throws Throwable { // method.isAnnotationPresent(Begin.class) --> do begin // other annotations... // } } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2994?page=comments#action_12418643 ] Pete Muir commented on JBSEAM-2994: ----------------------------------- Ok. Do you have a POC? Because I don't see how you plan to process annotations on component classes. Also, you need to maintain the correct semantics for the annotations (e.g. outjection occurs after a method invocation on a component, not at the end of component instantiation). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2994?page=com.atlassian.jira.pl... ] Pete Muir closed JBSEAM-2994. ----------------------------- Resolution: Done It works, but there is some work to improve performance and reduce reflection calls -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira