Method org.jboss.seam.remoting.Call.findMethod(String, Class) makes inefficient use of keySet iterator instead of entrySet iterator
-----------------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-3794
URL: https://jira.jboss.org/jira/browse/JBSEAM-3794
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
for (Method m : candidates.keySet())
{
int thisScore = candidates.get(m).intValue(); <-- HERE!
if (bestMethod == null || thisScore > bestScore)
{
bestMethod = m;
bestScore = thisScore;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
AsynchronousMailProcessor.scheduleSend should be using logging API
------------------------------------------------------------------
Key: JBSEAM-3799
URL: https://jira.jboss.org/jira/browse/JBSEAM-3799
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
} catch (Exception e) {
e.printStackTrace();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Invocation of toString on args in org.jboss.seam.util.DelegatingInvocationHandler.invoke
----------------------------------------------------------------------------------------
Key: JBSEAM-3792
URL: https://jira.jboss.org/jira/browse/JBSEAM-3792
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
nvocation of toString on args in org.jboss.seam.util.DelegatingInvocationHandler.invoke(Object, Method, Object[]):
if (log.isTraceEnabled())
{
log.trace("Delegating method " + method.getName() + " with args " + args);
}
args will not be logged as something nice to read.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Useless conditional in SeamComponentPostProcessor.postProcessAfterInitialization
--------------------------------------------------------------------------------
Key: JBSEAM-3787
URL: https://jira.jboss.org/jira/browse/JBSEAM-3787
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
instanceof will always return true in org.jboss.seam.ioc.spring.SeamComponentPostProcessor.postProcessAfterInitialization(Object, String), since all org.jboss.seam.ioc.spring.SpringComponent are instances of org.jboss.seam.ioc.spring.SpringComponent
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Useless conditional in MailResponseWriter.write
-----------------------------------------------
Key: JBSEAM-3789
URL: https://jira.jboss.org/jira/browse/JBSEAM-3789
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
Method org.jboss.seam.mail.ui.context.MailResponseWriter.write(String) uses the same code for two branches
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
ConversationInterceptor.aroundInvoke broken stacktrace
------------------------------------------------------
Key: JBSEAM-3797
URL: https://jira.jboss.org/jira/browse/JBSEAM-3797
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
catch (Exception e)
{
if ( isEndConversationRequired(e) )
{
endConversation(false, false);
}
throw e; //<---HERE!
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Support Hibernate in IdentityManager
------------------------------------
Key: JBSEAM-3424
URL: https://jira.jboss.org/jira/browse/JBSEAM-3424
Project: Seam
Issue Type: Feature Request
Affects Versions: 2.1.0.BETA1
Reporter: Scott Olcott
Attachments: seamspaceChanges.txt, securityChanges.txt, securityXsdChanges.txt
The JpaIdentityStore could easily work with hibernate also. If you abstracted out the EntityManager and the hiberate Session from the JpaIdentityStore kind of like the AbstractEntityLoader does for the EntityConverter, you could continue to use the JpaIdentityStore for both JPA and Hibernate. Although you would probably want to rename JpaIdentityStore
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Conversation leak with UIChart
------------------------------
Key: JBSEAM-3000
URL: http://jira.jboss.com/jira/browse/JBSEAM-3000
Project: Seam
Issue Type: Bug
Components: JSF Controls
Affects Versions: 2.0.1.CR2
Environment: NA
Reporter: Tom Goring
Priority: Minor
Added a chart on a page generates a long running conversation due to a bug in UIChart:
UIChart
public void encodeEnd(FacesContext context)
..
Manager.instance().beforeRedirect();
beforeRedirect is creating a redirect conversation.. however I don't see why it needs todo this. The chart is rendered to the graphic store and then is pulled out when requiested from the browser.
I think Manager.instance().beforeRedirect(); should be deleted ... but I'm not sure.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nullcheck too soon in UIChartSeries.encodeEnd
---------------------------------------------
Key: JBSEAM-3785
URL: https://jira.jboss.org/jira/browse/JBSEAM-3785
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
Nullcheck of chart at line 144 of value previously dereferenced in org.jboss.seam.pdf.ui.UIChartSeries.encodeEnd(FacesContext) jboss-seam/src
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nullcheck too late in SpringTaskExecutorDispatcher.scheduleDispatcher
----------------------------------------------------------------------
Key: JBSEAM-3786
URL: https://jira.jboss.org/jira/browse/JBSEAM-3786
Project: Seam
Issue Type: Bug
Reporter: Francisco Jose Peredo Noguez
Nullcheck of SpringTaskExecutorDispatcher.scheduleDispatcher at line 64 of value previously dereferenced in org.jboss.seam.ioc.spring.SpringTaskExecutorDispatcher.getScheduleDispatcher()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira