[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2931) CLONE -Support protection against SQL injection in Query order parameter

[ http://jira.jboss.com/jira/browse/JBSEAM-2931?page=comments#action_12410934 ] Felix Ho?feld commented on JBSEAM-2931: --------------------------------------- Sorry, I could not reopen JBSEAM-2099 so I have cloned it. The fix for JBSEAM-2099 does not work as expected because the regular expression is too restrictive. When I suggested the regex for input filtering I did not think of funtion based order clauses which are quite common in the real world, e.g. <framework:entity-query name="qry_allPersons" ejbql="SELECT p FROM Person p" entity-manager="#{entityManager}" order="UPPER(p.lastname)"> </framework:entity-query> The query will raise an invalid argument exception "invalid order clause" because the order clause does not match the regular expression "^[\\w\\.,\\s]*$" defined in ORDER_CLAUSE_PATTERN). (http://fisheye.jboss.com/browse/Seam/trunk/src/main/org/jboss/seam/framew...). I suggest changing this to ^(\\w+\\([\\w\\.\\s]+\\)\\s*,\\s*|[\\w\\.]+\\s*,\\s*)*(\\w+\\([\\w\\.\\s]+\\)|[\\w\\.]+) which will alo match something like: UPPER(p.lastname), p.age, LOWER(p.country). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira