[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1593) New processing for stateful bean @Destroy and @Remove causes problems.

[ http://jira.jboss.com/jira/browse/JBSEAM-1593?page=comments#action_12367437 ] Chris Rudd commented on JBSEAM-1593: ------------------------------------ Here is a potential fix. It only sets the defaultRemoveMethod to the first scanned (instead of last) but will "override" with the @Destroy method, if it is also an @Remove method. Additionally Component.callDefaultRemoveMethod is modified to only call the default remove if it is NOT the @Destroy method as well (as it stands now a lone @Destroy @Remove method would be called twice, which is probably not a good thing) Component.java line 539 private void scanMethod(Context applicationContext, Map<Method, Annotation> selectionSetters, Set<String> dataModelNames, Method method) { if ( method.isAnnotationPresent(REMOVE) ) { removeMethods.put( method.getName(), method ); if ( method.getParameterTypes().length==0 ) { + // prefer the @Destroy method as the default remove method + if( defaultRemoveMethod == null || method.isAnnotationPresent(Destroy.class) + { defaultRemoveMethod = method; + } lifecycleMethods.add(method); } } Component.java line 1866 private void callDefaultRemoveMethod(Object instance) { + if( getDefaultRemoveMethod() != getDestroyMethod() ) callComponentMethod( instance, getDefaultRemoveMethod() ); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira