[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-2881) Conversation Switcher doesn't work with natural conversations

Conversation Switcher doesn't work with natural conversations ------------------------------------------------------------- Key: JBSEAM-2881 URL: https://jira.jboss.org/jira/browse/JBSEAM-2881 Project: Seam Issue Type: Bug Components: JSF Controls, JSF Integration Affects Versions: 2.0.2.CR1 Environment: Seam 2.0.2.CR1, Mac OS X 10.5, Java 1.5.0_13 Reporter: Caleb Land Assignee: Shane Bryzak Fix For: 2.1.1.CR1 The Switcher component's (org.jboss.seam.faces.Switcher) switch() method does not work correctly when using natural conversations. The issue is related to line 102 (in trunk and in 2.0.2.CR1) where seam tests whether the selected item is an outcome or a conversation id: boolean isOutcome = conversationIdOrOutcome==null || !Character.isDigit( conversationIdOrOutcome.charAt(0) ); The problem is that with natural conversations, the value of conversationIdOrOutcome is something like "accountEdit:4" so the switcher thinks it's a view. I copied the code from the Switcher and created a new component and replaced that line with: boolean isOutcome = conversationIdOrOutcome==null || (!Character.isDigit(conversationIdOrOutcome.charAt(0)) && conversationIdOrOutcome.indexOf(':') < 0); and it works correctly. Of course this approach is naive, but it seems to work for me.