[jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3340) StatusMessages: addition of ConfigRedirectHandler messages is broken

StatusMessages: addition of ConfigRedirectHandler messages is broken -------------------------------------------------------------------- Key: JBSEAM-3340 URL: https://jira.jboss.org/jira/browse/JBSEAM-3340 Project: Seam Issue Type: Bug Components: Core Environment: Seam 2.1.0 Rev 8823 Reporter: Wolfgang Schwendt Assignee: Pete Muir Priority: Critical Fix For: 2.1.0.CR1 Attachments: StatusMessages.patch.diff.txt XML schema Pages-2.1.xsd allows the specification of an error message for any declared exception handler: Example: <exception class="org.jboss.seam.framework.EntityNotFoundException"> <end-conversation/> <redirect view-id="/error.xhtml"> <message>#{messages['notFoundMsg']}</message> </redirect> </exception> Right now as of Seam 2.1.0 Rev 8823, however, the error message is not added to the FacesContext, whereas with previous versions of Seam the functionality worked fine. org.jboss.seam.exception.RedirectHandler is not the problem. The bug is in org.jboss.seam.international.StatusMessages. StatusMessages.add(Severity severity, String messageTemplate, Object... params) calls StatusMessages.add(severity, null, null, messageTemplate, null, params), setting the key-Parameter (resourceBundleKey) to null. The implementation of StatusMessages.add(Severity severity, String key, String detailKey, String messageTemplate, String messageDetailTemplate, final Object... params) checks whether the key is empty. if (!Strings.isEmpty(key)) ... But because the supplied key is null, the error message is never added to the FacesContext! Further, there is another bug in the logic which calls the message interpolation.