[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
4:03 p.m.
Major reentrancy problem with "Application Scope" components and
injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Priority: Blocker
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing Application
Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set the
"reentrant" attribute of the instance of BijectionInterceptor attached to C1 to
"true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod( invocation.getMethod()
);
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:10 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Pete Muir updated JBSEAM-3295:
------------------------------
Fix Version/s: 2.0.3.CR2
2.1.0.BETA1
Assignee: Shane Bryzak
Shane, can you verify whether this is the case asap (by tomorrow)? Thanks :)
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Shane Bryzak
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:19 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Shane Bryzak closed JBSEAM-3295.
--------------------------------
Resolution: Done
Fixed in SVN. Denis could you please confirm that this fixes your issue, thanks.
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Shane Bryzak
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:47 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Denis Forveille reopened JBSEAM-3295:
-------------------------------------
Shane,
the correction you made changes drastically the logic of the Interceptor.
Before, the injection/disinjection was only done on the first method call for a component.
Now you are doing it in for every call, not only the first one. ie when a method of C1
calls another method of C1, you inject/disinject where it was not the case before
This is very different, at least in terms of performance
In your code, the inject/disinject should only be called when reentrantCounter == 0
Also, at a higher level, IMHO, I think that injection/disjection of ressources of an
application scope component should only be done once in the life of the component, not at
every method all
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Shane Bryzak
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:54 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Denis Forveille updated JBSEAM-3295:
------------------------------------
Attachment: BijectionInterceptor_Denis.java
Attached our non-optimized version of BijectionInterceptor
It could easily be optimized in many ways, including the usage of an AtomicInteger as you
did...but the logic respects the logic of the initial BijectionInterceptor, ie
injecting/disinjecting only on the first level of methdo calls
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Shane Bryzak
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:59 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Denis Forveille commented on JBSEAM-3295:
-----------------------------------------
Also the uploaded code misses the try/finally logic that will make it 100% safe..
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Shane Bryzak
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:04 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Pete Muir resolved JBSEAM-3295.
-------------------------------
Resolution: Done
Assignee: Pete Muir (was: Shane Bryzak)
Denis, I committed a fix that is similar to yours, but it puts the injection inside a sync
block as we need for all components to wait for injection to be complete before
proceeding.
I guess this isn't the most optimized approach, but we will do something better for
beta2.
Can you review for me, and post back if you see some problem?
Thanks
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Pete Muir
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Denis Forveille commented on JBSEAM-3295:
-----------------------------------------
Shane,
It seems ok.
Two things:
1) You didn't commit to the branch, only in the trunk
2) Why not pushing down the code between
Object result = invocation.proceed();
and
return result;
.. in the finally block?
Is it because you don't want to perform an outject in case of an exception in
invocation.proceed() ?
(I'll test the new code on monday)
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Pete Muir
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3295:
-----------------------------------
Denis,
1) Yes, we will work on an optimized version for the branch and trunk - JBSEAM-3301 covers
this. Main concern right now is releasing 2.1 beta1 ;-)
2) Correct, you *don't* want to outject if the invocation of the business method
throws an exception but you do want to disinject - as ever, with exception processing, you
want to halt when the exception is thrown, and do cleanup (disinjection).
Thanks for the help with this :-)
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Pete Muir
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Denis Forveille commented on JBSEAM-3295:
-----------------------------------------
You're welcome Pete and thx to you for the great job on seam.
I understand your point about the release of 2.1b, but you should commit the same code in
the branch as the one Shane commited on the trunk, because i think the code currently on
the branch will cause more dommages than the one previosuly in place. At least for the
moment.
Also JBSEAM-3301 is currently only targetted for 2.1, not 2.0.x
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Pete Muir
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3295) Major reentrancy problem with "Application Scope" components and injection/disinjection
[
https://jira.jboss.org/jira/browse/JBSEAM-3295?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3295:
-----------------------------------
Yeah, I was just being lazy on a Friday night ;-)
I did the backport (n.b. it was my fix ;-)
I also targeted JBSEAM-3301 at 2.0.3 as well...
Major reentrancy problem with "Application Scope"
components and injection/disinjection
---------------------------------------------------------------------------------------
Key: JBSEAM-3295
URL: https://jira.jboss.org/jira/browse/JBSEAM-3295
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.2.SP1
Environment: WebSphere v6.1.0.17 in POJO Mode
Reporter: Denis Forveille
Assignee: Pete Muir
Priority: Blocker
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: BijectionInterceptor_Denis.java
There is a major reentrancy problem with "Application Scope" components and
injection/disinjection
As in any component @In dependent object are injected/disinjected with the
BijectionInterceptor interceptor
As there is one instance of BijectionInterceptor per Component (It seems), there is only
one instance of BijectionInterceptor in the JVM for an Application Scope Component,
instance shared by all threads
With that in mind, take:
- 2 running thread (T1, T2)
- One application scope component (C1) with many@In attributes (All referecing
Application Scope components too..)
T1 enters method M1 of C1. BijectionInterceptor inject @In depedencies of C1, and set
the "reentrant" attribute of the instance of BijectionInterceptor attached to C1
to "true"
T2 enters method M1of C1. BijectionInterceptor does nothing as "reentrant" is
true
T1 exits method M1 of C1. As this is thios thread (T1) that set "reentrant"
initially, it performs the "disinjection" and set all the @In attribues of C1
to null
T2 then fails with NPE as all the @In attributes of C1 are set to null !!!!!
Core of the org.jboss.seam.core.BijectionInterceptor class:
private boolean reentrant; //OK, since all Seam components are single-threaded
@AroundInvoke
public Object aroundInvoke(InvocationContext invocation) throws Exception{
if (reentrant) {
return invocation.proceed();
}
else {
reentrant = true;
try {
Component component = getComponent();
boolean enforceRequired = !component.isLifecycleMethod(
invocation.getMethod() );
component.inject( invocation.getTarget(), enforceRequired );
Object result = invocation.proceed();
component.outject( invocation.getTarget(), enforceRequired );
component.disinject( invocation.getTarget() );
return result;
}
finally {
reentrant = false;
}
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5926
days inactive
5928
days old
10 comments
3 participants
participants (3)
-
Denis Forveille (JIRA) -
Pete Muir (JIRA)
-
Shane Bryzak (JIRA)