[ http://jira.jboss.com/jira/browse/JBSEAM-2232?page=comments#action_12386866 ] Max Andersen commented on JBSEAM-2232: -------------------------------------- I know of one usecase where these events are usefull, namely to allow the tooling to listen for events and put a breakpoint automatically when a specific event happens. Tracing down when something is initialized is usefull. I would suggest we move the event logging to a TRACE level instead or somehow allow users to enable/disable logging for the events they want. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2232?page=comments#action_12388454 ] Matthew Lieder commented on JBSEAM-2232: ---------------------------------------- Guys, vote for this issue if you want it fixed; that's mostly how they've been prioritizing fixes lately. Given how easy this is to rectify, I'm guessing as soon as it gets their attention they'll fix it :). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2232?page=comments#action_12388465 ] Tobias Frech commented on JBSEAM-2232: -------------------------------------- The WARN message is only printed if the Drools libs are present. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2232?page=comments#action_12395965 ] Vladimir Kovalyuk commented on JBSEAM-2232: ------------------------------------------- I have to skip the following messages: 1. related to Events component (too verbose :) ) 2. seam component not found (before creating, a lot of unsuccessful attempts to concat some prefixes like org.jboss.seam.core.actions etc) 3. instantiating seam component 4. initializing new instance of 5. done initializing I'll be fine with fine-prepared exception when seam can't create component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2232?page=all ] Pete Muir updated JBSEAM-2232: ------------------------------ Fix Version/s: 2.1.0.GA (was: 2.1.0.BETA1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Pete Muir updated JBSEAM-2232: ------------------------------ Fix Version/s: 2.1.1.CR1 (was: 2.1.0.CR1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Pete Muir commented on JBSEAM-2232: ----------------------------------- I would say: * INFO level is only used during startup, nothing during runtime * DEBUG level is used for information that is useful for a user to develop their Seam app * TRACE is for stuff that is useful for debugging Seam itself -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Francisco Jose Peredo Noguez commented on JBSEAM-2232: ------------------------------------------------------ Correction: log messages should be added to in org.jboss.seam.util.Reflections and they should be on the TRACE level. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Pete Muir updated JBSEAM-2232: ------------------------------ Fix Version/s: 2.1.2.GA (was: 2.2.0.CR1) Assignee: Pete Muir -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Christian Bauer commented on JBSEAM-2232: ----------------------------------------- One more thing and a mistake I've seen a few times in the Seam codebase - let's not repeat them on Web Beans: org.jboss.seam.deployment.ClassDescriptor try { clazz = classLoader.loadClass(classname); // IBM JVM will throw a TypeNotPresentException if any annotation on the class is not on // the classpath, rendering the class virtually unusable (given Seam's heavy use of annotations) clazz.getAnnotations(); } catch (ClassNotFoundException cnfe) { log.info("could not load class: " + classname, cnfe); } catch (NoClassDefFoundError ncdfe) { log.debug("could not load class (missing dependency): " + classname, ncdfe); } catch (TypeNotPresentException tnpe) { clazz = null; log.debug("could not load class (annotation missing dependency): " + classname, tnpe); } If you want to "inform" the user about something, it's enough if you print a message. Don't print a stacktrace that has no information that the user is going to need at this point. Otherwise, debug level printing if the stacktrace can probably be considered OK although I'd do that at TRACE. Or much better, tell the user how to get more output if necessary: "This is a warning because you did this or that, and enable DEBUG|TRACE for more information". What I'm trying to say is: Apply some common sense when you log stuff and don't think about what's useful to you but what the user is ultimately supposed to do when he reads that message. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Norman Richards reassigned JBSEAM-2232: --------------------------------------- Assignee: Norman Richards (was: Dan Allen) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2232?page=com.atlassian.jira.pl... ] Norman Richards closed JBSEAM-2232. ----------------------------------- Resolution: Done I've taken a second pass at this with an eye on keeping everything INFO or higher as consistent and useful as possible. There is still a lot of debug level logging that would probably be better as trace, but overall it looks like a healthy place to be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira