[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
10:35 p.m.
Should be able to customize Hibernate validation messages based on context (by page, or
role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: http://jira.jboss.com/jira/browse/JBSEAM-1262
Project: JBoss Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:24 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
[ http://jira.jboss.com/jira/browse/JBSEAM-1262?page=comments#action_12360758 ]
Pete Muir commented on JBSEAM-1262:
-----------------------------------
I see where you are coming from with this, and agree that it would be good to be able to
customise message values for a group of inputs, but I'm not sure that syntax is the
best. I prefer:
<s:validate message="#{messages.fooMessage}" />
Would that work for you?
Should be able to customize Hibernate validation messages based on
context (by page, or role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: http://jira.jboss.com/jira/browse/JBSEAM-1262
Project: JBoss Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:32 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
[ http://jira.jboss.com/jira/browse/JBSEAM-1262?page=comments#action_12360770 ]
Nathaniel Stoddard commented on JBSEAM-1262:
--------------------------------------------
I'm not sure how the best way to do this either. Personally, I don't think we
should be specifying error messages (displayed on the presentation tier) in the model --
bad coupling, though not the worst. The <s:validate> syntax you mentioned would
work, but would require one tag for each field being validated. More people would
probably benefit from being able to customize the error messages even when using
<s:validateAll>. I suppose we can ignore @IfInvalid() for now since it is
"semi-deprecated".
Since <s:validate> and <s:validateAll> both validate UIInput-bound values,
perhaps we can come up with some sort of mechanism where we place a <f:attribute> on
the UIInput that species the error message to use for each validation rule. Ex:
<h:inputText value="#{myBean.socialSecurityNumber}">
<f:attribute name="msg-pattern"
value="#{errors['social-security-number-invalid-pattern']}" />
</h:inputText>
... I'm just thinking here -- not sure what direction is best.
Should be able to customize Hibernate validation messages based on
context (by page, or role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: http://jira.jboss.com/jira/browse/JBSEAM-1262
Project: JBoss Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:10 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
[ http://jira.jboss.com/jira/browse/JBSEAM-1262?page=comments#action_12360773 ]
Pete Muir commented on JBSEAM-1262:
-----------------------------------
Yes, I think we definitely want to have this on the presentation layer.
Given
public class Model {
@Length(min=10, message="#{messages.generalFooMessage}")
private String foo;
@Length(min=10, message="#{messages.generalBarMessage}")
private String bar;
}
then
<s:validateAll>
<h:inputText value="#{model.foo}" />
<h:inputText value="#{model.bar}">
<s:validate message="#{messages.specificBarMessage}" />
</h:inputText>
</s:validateAll>
would result in foo using the message specified on the validator, and bar taking a more
specific message from the nested s:validate
It could be good to have something like
<s:validateAll bundle="messageBundleForThisSetOfFields">
...
</s:validateAll>
similar to how you can specify a message bundle for a page.
Should be able to customize Hibernate validation messages based on
context (by page, or role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: http://jira.jboss.com/jira/browse/JBSEAM-1262
Project: JBoss Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:10 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
[ http://jira.jboss.com/jira/browse/JBSEAM-1262?page=comments#action_12360924 ]
Keith Naas commented on JBSEAM-1262:
------------------------------------
We solved this by customizing the decorate tag. For each of the processXxx methods, we
setup, call the real method, and tear it down. In the setup we simply put the
"label" into the request map. The teardown removes it.
The label is either an attribute that the user puts into the decorate element, or if
unspecified defaults to the id of the UIComponent.
This way, when the resource bundle is accessed by the validator, it will plug the label
string into it. This works well regardless of which technology we use.
For instance our bundle looks like this.
# Please note that these override the defaults set by the JSF implementation
## BEGIN JSF override
javax.faces.converter.BigDecimalConverter.DECIMAL=#{label} is not a valid entry.
javax.faces.converter.BigDecimalConverter.DECIMAL_detail=*
javax.faces.validator.DoubleRangeValidator.MINIMUM=#{label} must be greater than or equal
to {0}.
javax.faces.validator.DoubleRangeValidator.MINIMUM_detail=*
javax.faces.validator.DoubleRangeValidator.MAXIMUM=#{label} must be less than or equal to
{0}.
javax.faces.validator.DoubleRangeValidator.MAXIMUM_detail=*
....
## END JSF Override
## Begin Hibernate Validator override
validator.assertFalse=#{label} is not a valid entry.
validator.length=#{label} must be between {min} and {max} characters.
validator.max=#{label} must be less than or equal to {value}.
validator.min=#{label} must be greater than or equal to {value}.
....
## End Hibernate Validator override
Should be able to customize Hibernate validation messages based on
context (by page, or role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: http://jira.jboss.com/jira/browse/JBSEAM-1262
Project: JBoss Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:01 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
[ http://jira.jboss.com/jira/browse/JBSEAM-1262?page=comments#action_12360997 ]
Keith Naas commented on JBSEAM-1262:
------------------------------------
Of course, the customized label messages only work for non Seam components if the faces
application resource bundle delegates to the Seam ResourceBundle component. This would
mean implementing JBSEAM-1045.
Should be able to customize Hibernate validation messages based on
context (by page, or role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: http://jira.jboss.com/jira/browse/JBSEAM-1262
Project: JBoss Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:17 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1262) Should be able to customize Hibernate validation messages based on context (by page, or role like Seam component scopes)
[
https://jira.jboss.org/jira/browse/JBSEAM-1262?page=com.atlassian.jira.pl...
]
Pete Muir closed JBSEAM-1262.
-----------------------------
Resolution: Out of Date
This should now work as Seam now allows you to next parameters in JSF to a message.
Should be able to customize Hibernate validation messages based on
context (by page, or role like Seam component scopes)
------------------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1262
URL: https://jira.jboss.org/jira/browse/JBSEAM-1262
Project: Seam
Issue Type: Feature Request
Affects Versions: 1.2.1.GA
Reporter: Nathaniel Stoddard
Currently, each validation specified a single message resource to be used as the error
message. It would be helpful if there was some way to customize the error messages to be
used such that in one case "Contact address is required." is displayed, while in
others "Billing address is required", for example. Annotating model classes
with validation rules limits the reuse of those classes since the validation messages
offer limited flexibility.
Since validated fields in the domain classes aren't necessarily associated with a
UIInput on a page, it would be helpful to have more flexible annotations, such as:
@MaxLength(messages = {@Message(role='contactForm',
value='contact.too_long'), @Message(role='billingForm',
value='billing.too_long')})
private String field;
Also needed would be some way of indicated to the UIView which 'role' should be
used when validation takes place.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5923
days inactive
6449
days old
6 comments
3 participants
participants (3)
-
Keith Naas (JIRA) -
Nathaniel Stoddard (JIRA)
-
Pete Muir (JIRA)