[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
10:43 p.m.
hot deployment directory should not be tied to name and location of debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture the
path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=all ]
Dan Allen updated JBSEAM-1327:
------------------------------
Attachment: JBSEAM-1327-1.txt
Patch against the 1.2.1.ga source code. Also note that I added an INFO level log message
announcing which directory will be used for the hot deployment classloader. This log
message can be very helpful for developers getting started with this feature.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=all ]
Dan Allen updated JBSEAM-1327:
------------------------------
Attachment: JBSEAM-1328.txt
A patch against the seam trunk (1.3.0). Also note that I added an INFO level log message
announcing which directory is being used for hot deployment. This log message can be
helpful for developers who are getting started with this feature.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:03 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=comments#action_12362311 ]
Dan Allen commented on JBSEAM-1327:
-----------------------------------
The attachments are a bit confusing because JIRA doesn't allow you to enter a name
field. Here is the mapping:
JBSEAM-1327-1.txt => Seam 1.2.1.ga
JBSEAM-1328.txt => Seam trunk (1.3.0)
I accidentally gave the second patch the wrong issue id, but unfortunately there is no way
to change it now.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:42 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=all ]
Dan Allen updated JBSEAM-1327:
------------------------------
Attachment: JBSEAM-1327_trunk.txt
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:42 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=all ]
Dan Allen updated JBSEAM-1327:
------------------------------
Attachment: JBSEAM-1327_1.2.1.GA.txt
Scratch those first two patches because they had problems. The second two patches should
work properly.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:44 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=comments#action_12362313 ]
Dan Allen commented on JBSEAM-1327:
-----------------------------------
Okay, JIRA is starting to irritate me now with this stupid attachment management. The
valid patches, which should be self explanatory now, are:
2. Text File JBSEAM-1327_1.2.1.GA.txt (1 kb)
3. Text File JBSEAM-1327_trunk.txt (3 kb)
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:42 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=comments#action_12362464 ]
Gavin King commented on JBSEAM-1327:
------------------------------------
I tried out your patch, but it does not work on JBoss.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:45 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=comments#action_12362472 ]
Dan Allen commented on JBSEAM-1327:
-----------------------------------
Rats...let me give it another try. I will rev up JBoss and figure out where things are
going wrong. If the patch needs to be changed, which I am going to assume from your
trials it does, I will provide a new version. Thanks for your patience.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:24 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=all ]
Dan Allen updated JBSEAM-1327:
------------------------------
Attachment: JBSEAM-1327-take2-1.2.1.GA.txt
JBSEAM-1327-take2-trunk.txt
As it turns out, ServletContext#getResource() is not a reliable way to get a java.io.File
from a path within an exploded archive. Different application servers take different
approaches. JBoss specifically returns a URL object that uses the "jndi"
protocol (hence why the previous patches didn't work for JBoss). From that URL, there
isn't much luck of finding the directory.
However, once I opened my eyes a little wider (and rolled my mind back a couple of years)
I (re)discovered the ServletContext#getRealPath() method. Granted, this function is not
something you would use in a production environment since it only works for exploded
archives. Alas, that is the only time we need it, so it lends itself perfectly to this
situation!
The new patches use servletContext.getRealPath("/WEB-INF/dev") to find the hot
deployable classloader directory. I erred on the side of caution on the TRUNK so as to
not change the API of the RedeployableStrategy. To maintain the same method signatures, I
wrap the resulting String in a URL. Feel free to refactor at will.
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327-take2-1.2.1.GA.txt,
JBSEAM-1327-take2-trunk.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=comments#action_12362486 ]
Gavin King commented on JBSEAM-1327:
------------------------------------
Where are the new patches? I don't see any patch using getRealPath()...
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327-take2-1.2.1.GA.txt,
JBSEAM-1327-take2-trunk.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1327) hot deployment directory should not be tied to name and location of debug jar
[ http://jira.jboss.com/jira/browse/JBSEAM-1327?page=all ]
Gavin King closed JBSEAM-1327.
------------------------------
Resolution: Done
Assignee: Gavin King
OK, I think I've got something that works now. Please test it on Jetty for me,
thanks.
(In CVS HEAD)
hot deployment directory should not be tied to name and location of
debug jar
-----------------------------------------------------------------------------
Key: JBSEAM-1327
URL: http://jira.jboss.com/jira/browse/JBSEAM-1327
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 1.2.1.GA
Environment: JDK 1.5, Ubuntu Linux 7.04, Jetty running under Maven 2
Reporter: Dan Allen
Assigned To: Gavin King
Priority: Critical
Fix For: 1.3.0.BETA1
Attachments: JBSEAM-1327-1.txt, JBSEAM-1327-take2-1.2.1.GA.txt,
JBSEAM-1327-take2-trunk.txt, JBSEAM-1327_1.2.1.GA.txt, JBSEAM-1327_trunk.txt,
JBSEAM-1328.txt
The logic for determining the location of the hot deployable directory for Java classes
currently relies on the location and name of the jboss-seam-debug jar file. While this
may work when the jar file is placed in WEB-INF/lib, relative to the WEB-INF/dev
directory, and named jboss-seam-debug.jar, it breaks down when it is loaded by the
application server by a different means or has a different name.
For instance, when running a Seam application using Jetty from within Maven 2, the
location of the jar file is in the local repository.
What I find particularly scary is the hard-coded string offsets:
String hotDeployDirectory = path.substring( 9, path.length()-46 ) + "dev";
To get a better understanding of the problem, I added some logging messages to capture
the path resolver logic when jetty builds its classpath from the maven repository.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/.m2/repository-public/jboss/seam/jboss-seam-debug/1.2.1.GA/jbossdev
If I place the jboss-seam-debug-1.2.1.ga.jar file in the src/main/webapp/WEB-INF/lib
directory, then things get a little bit better, but still not quite right.
META-INF/debug.xhtml detected at
jar:file:/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jboss-seam-debug-1.2.1.GA.jar!/META-INF/debug.xhtml
Hot deploy directory is
/home/dallen/projects/connoisseur/src/main/webapp/WEB-INF/lib/jbossdev
What I propose is for the WEB-INF/dev directory to be loaded using the servlet context.
That way, it will always be the directory that is most likely located in the project of
the developer. Since this feature is intended strictly for development, this seams to
make the most sense.
I will provided a patch for both Seam 1.2.1.ga and the trunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6444
days inactive
6446
days old
11 comments
2 participants
participants (2)
-
Dan Allen (JIRA) -
Gavin King (JIRA)