[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
7:42 p.m.
Allow for map and set properties configured through componenets.xml to maintain there
ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: The future
Reporter: Stuart Douglas
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:44 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Stuart Douglas updated JBSEAM-3460:
-----------------------------------
Attachment: preserve-order-patch.diff
Patch
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: The future
Reporter: Stuart Douglas
Attachments: preserve-order-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:53 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Stuart Douglas updated JBSEAM-3460:
-----------------------------------
Attachment: seam-collections-patch.diff
An updated patch that automatically selects the correct collection type for concrete types
and allows for sorted maps/sets to be injected as well.
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: The future
Reporter: Stuart Douglas
Attachments: preserve-order-patch.diff, seam-collections-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:55 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Stuart Douglas updated JBSEAM-3460:
-----------------------------------
Affects Version/s: 2.1.0.GA
(was: The future)
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.GA
Reporter: Stuart Douglas
Attachments: preserve-order-patch.diff, seam-collections-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:54 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3460:
-----------------------------------
Hi Stuart. I like the idea of being able to preserve order, but is there a reason not to
just do this by default? How much more expensive is it to always preserve order?
Also, if we do decide to specify the "implementation" in components.xml it needs
to be the fully qualified class name, not some string property we invent.
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.GA
Reporter: Stuart Douglas
Attachments: preserve-order-patch.diff, seam-collections-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Stuart Douglas updated JBSEAM-3460:
-----------------------------------
Attachment: seam-collections-patch-v2.diff
I have attached another updated patch.
I think it would be great if we preserved order by default, the performance overhead would
be minimal (in some situation it would even improve performance as LinkedHashMap has
faster iteration). The only change that is required to the patch is to instantiate a
LinkedHashMap instead of a HashMap in Component.java.
The reason why I didn't was because I did not want to break existing code that may
cast injected Maps to HashMap, but I don't know how common this situation is (and
anyone doing it would be relying on undocumented behavior anyway), and it would be easy to
fix by manually specifying a HashMap implementation.
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.GA
Reporter: Stuart Douglas
Attachments: preserve-order-patch.diff, seam-collections-patch-v2.diff,
seam-collections-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Pete Muir resolved JBSEAM-3460.
-------------------------------
Fix Version/s: 2.1.0.GA
Resolution: Done
Assignee: Pete Muir
Stuart, I've applied your patch with some alterations:
* Fixed the weird code formatting
* Altered implementation->type
* Supported type on List type properties as well
* Used LinkedHashMap and LinkedHashSet by default
Thanks for the patch! Keepi them coming!
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.GA
Reporter: Stuart Douglas
Assignee: Pete Muir
Fix For: 2.1.0.GA
Attachments: preserve-order-patch.diff, seam-collections-patch-v2.diff,
seam-collections-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 a.m.
New subject: [JBoss JIRA] Closed: (JBSEAM-3460) Allow for map and set properties configured through componenets.xml to maintain there ordering
[
https://jira.jboss.org/jira/browse/JBSEAM-3460?page=com.atlassian.jira.pl...
]
Pete Muir closed JBSEAM-3460.
-----------------------------
Allow for map and set properties configured through componenets.xml
to maintain there ordering
----------------------------------------------------------------------------------------------
Key: JBSEAM-3460
URL: https://jira.jboss.org/jira/browse/JBSEAM-3460
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.GA
Reporter: Stuart Douglas
Assignee: Pete Muir
Fix For: 2.1.0.GA
Attachments: preserve-order-patch.diff, seam-collections-patch-v2.diff,
seam-collections-patch.diff
Add a preserve-order attribute to map and set properties that would allow the ordering to
be preserved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5449
days inactive
5932
days old
7 comments
2 participants
participants (2)
-
Pete Muir (JIRA) -
Stuart Douglas (JIRA)