12:17 p.m.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Priority: Blocker
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:19 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=all ]
Pete Muir updated JBSEAM-1596:
------------------------------
Assignee: Pete Muir
Priority: Minor (was: Blocker)
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assigned To: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:05 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12367688 ]
Gavin King commented on JBSEAM-1596:
------------------------------------
If we did do something like this (and I'm far from convinced its a good idea), we
should do it in Hibernate Validator, not in Seam.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assigned To: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12368549 ]
Geoffrey De Smet commented on JBSEAM-1596:
------------------------------------------
Maybe this validation should only trigger at the persistence layer (and ignored on above
layers)?
Currently, if a column is unique, we get a exception, which doesn't make it possible
to tell a user which field is not unique:
It would be nice if we get an InvalidStateException, which can be cleanly reported.
Here's what you get when a column called "code" is not unique, as you can
see "code" isn't mentioned nor cleanly extractable from it:
Caused by: org.hibernate.exception.ConstraintViolationException: could not insert:
[be.schaubroeck.bba.budgethouder.BudgethouderPO]
at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:71)
at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:43)
at
org.hibernate.id.insert.AbstractReturningDelegate.performInsert(AbstractReturningDelegate.java:40)
at
org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:2158)
at
org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:2638)
at
org.hibernate.action.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:48)
at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:250)
at
org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:298)
at
org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:181)
at
org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:107)
at
org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
at
org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:131)
at
org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:87)
at
org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:38)
at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:618)
at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:592)
at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:596)
at
org.hibernate.ejb.AbstractEntityManagerImpl.persist(AbstractEntityManagerImpl.java:213)
... 61 more
Caused by: com.mysql.jdbc.exceptions.MySQLIntegrityConstraintViolationException: Duplicate
entry 'NIET_UNIEK' for key 2
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:931)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:2941)
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1623)
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:1715)
at com.mysql.jdbc.Connection.execSQL(Connection.java:3249)
at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1268)
at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1541)
at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1455)
at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1440)
at
org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:101)
at
org.hibernate.id.IdentityGenerator$GetGeneratedKeysDelegate.executeAndExtract(IdentityGenerator.java:73)
at
org.hibernate.id.insert.AbstractReturningDelegate.performInsert(AbstractReturningDelegate.java:33)
... 76 more
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assigned To: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12368559 ]
Christian Bauer commented on JBSEAM-1596:
-----------------------------------------
"Currently, if a column is unique, we get a exception, which doesn't make it
possible to tell a user which field is not unique:
It would be nice if we get an InvalidStateException, which can be cleanly reported.
"
Uhm, you are supposed to _CHECK_ before you _INSERT_. You are not supposed to throw random
data in the direction of your database and then "report" if something fails.
This is what this issue is about, whether Seam should over built-in procedures for this
check or not. I agree with Emmanuel that it shouldn't, because avoiding race
conditions would require locking between check and insert, and that should really be up to
the developer.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assigned To: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12370500 ]
Fabricio Lemos commented on JBSEAM-1596:
----------------------------------------
Couldn´t the validator be configurable to lock, or not, the data base table? So it would
be up to the developer where to apply the validator and whether it would lock the table.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assigned To: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12370506 ]
Christian Bauer commented on JBSEAM-1596:
-----------------------------------------
There is no portable table locking syntax in SQL, it would require a major addition to the
Hibernate dialects.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assigned To: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:52 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=all ]
Pete Muir updated JBSEAM-1596:
------------------------------
Assignee: (was: Pete Muir)
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:46 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12380066 ]
Diego Ballve commented on JBSEAM-1596:
--------------------------------------
Let aside full blow lock'n'check, an optimistic check would already be a good
helper for most of us. The database constraint is still there to catch the cases when that
is not enough, right?
I was thinking on how do do it with hibernate validator -like approach but you lack the
entity there, so even if you could check if the value is defined in database (entityClass+
property passed as init params to the restriction annotation) you can't perform a
basic check: is it defined for the same object.
One could define an extended hibernate Validator interface that would also take the entity
on isValid().. if only ClassValidator would expose its memberValidators, you could detect
those from Seam ValidatingResolver and call the new isValid().
On the other hand, the entityClass already gives you what you need to know to build a
checking query: (i.e, @Id, @Column(unique=true), etc).It would be a lot of digging for
annotations, but still possible to find out what you need.
I have not found a good approach to go with the current interfaces yet, but maybe
collecting some possible approaches might shine some light in the discussion.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12380088 ]
Diego Ballve commented on JBSEAM-1596:
--------------------------------------
While the issue is open, I'm extending seam Validators and adding custom validators to
the ValidatingResolver.setValue(). What they do is to find getter, look for specific
annotations, query database if needed, return extra customInvalidValues). The code below
could event be added to seam Validators to make this kind of extension more
straightforward:
public class Validators {
...
class ValidatingResolver extends ELResolver {
...
@Override
public void setValue(ELContext context, Object base, Object property, Object value)
throws NullPointerException, PropertyNotFoundException,
PropertyNotWritableException, ELException {
if (base != null && property != null) {
context.setPropertyResolved(true);
invalidValues = getValidator(base).getPotentialInvalidValues(property.toString(),
value);
InvalidValue[] customInvalidValues = getCustomInvalidValues(base, property.toString(),
value);
invalidValues = (InvalidValue[]) ArrayUtils.addAll(invalidValues,
customInvalidValues);
}
}
}
/** Extension point for custom non-hibernate validators. */
protected InvalidValue[] getCustomInvalidValues(Object base, String property, Object
value) {
// lookup and calls to my custom validators goes here
}
}
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:09 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12384569 ]
Adam Warski commented on JBSEAM-1596:
-------------------------------------
But isn't the lack of a unique constraint validator a violation of DRY?
I think it's quite a common constraint, but is quite hard to handle right now. The
only reasonable choice is a custom validator ... as verifying it the model can cause
problems --- in case of a validation error detected, you have to prevent changes in entity
beans to be commited, and the only possible way to do that is rolling back the
transaction. As a rollback exception can't be caught, it's not possible to display
a user-friendly message on the same page, from thich the form was submitted.
Adam
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:13 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1596) Unique Constraint Validator
[ http://jira.jboss.com/jira/browse/JBSEAM-1596?page=comments#action_12394365 ]
Thomas Modeneis commented on JBSEAM-1596:
-----------------------------------------
Wow,
It will very coool if Hibernate creates one @annotation to validade unique
constraints!!!!!!!!!!!!!!!
Yeap ? let do this stuff.
Thanks all Hibernate and Seam Developers for this very productivity tools.
:)
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: http://jira.jboss.com/jira/browse/JBSEAM-1596
Project: JBoss Seam
Issue Type: Feature Request
Components: JSF
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:30 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1596) Unique Constraint Validator
[
https://jira.jboss.org/jira/browse/JBSEAM-1596?page=com.atlassian.jira.pl...
]
Pete Muir closed JBSEAM-1596.
-----------------------------
Resolution: Won't Fix
Assignee: Pete Muir
This should be a FR in Hibernate Validator JIRA.
Unique Constraint Validator
---------------------------
Key: JBSEAM-1596
URL: https://jira.jboss.org/jira/browse/JBSEAM-1596
Project: Seam
Issue Type: Feature Request
Components: JSF Integration
Affects Versions: 2.0.0.BETA1
Reporter: Pete Muir
Assignee: Pete Muir
Priority: Minor
We could have a generic unique constrain validator as part of the model validation.
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4059691#...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5884
days inactive
6344
days old
12 comments
8 participants
participants (8)
-
Adam Warski (JIRA) -
Christian Bauer (JIRA)
-
Diego Ballve (JIRA)
-
Fabricio Lemos (JIRA)
-
Gavin King (JIRA)
-
Geoffrey De Smet (JIRA)
-
Pete Muir (JIRA)
-
Thomas Modeneis (JIRA)