[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1257) default equals() on javabean components is not reflexive
4:31 p.m.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:35 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=comments#action_12360645 ]
Matt Drees commented on JBSEAM-1257:
------------------------------------
If this can't be addressed, then the docs should probably include a note that users
will have to override equals() if they need to use it.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:52 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=all ]
Pete Muir reassigned JBSEAM-1257:
---------------------------------
Assignee: Gavin King
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Gavin King
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:04 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=comments#action_12360647 ]
Max Andersen commented on JBSEAM-1257:
--------------------------------------
componentproxy.equals(component) is doable; but component.equals(componentproxy) is not
without bytecode weaving (and then the proxy probably wouldn't be needed anyway) since
the component instance is not interceptable - that is what the proxy does.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Gavin King
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:27 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=comments#action_12360665 ]
Matt Drees commented on JBSEAM-1257:
------------------------------------
componentproxy.equals(component) would be nice too, I think, but really what I'm
asking for is componentproxy.equals(componentproxy).
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Gavin King
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:08 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=all ]
Matt Drees updated JBSEAM-1257:
-------------------------------
Attachment: reflexive-equals.txt
Here's a patch to JavaBeanIntereceptor.java that should do the trick, I think. When
intercepting an equals method, if the parameter is identical to the proxy, it unwraps the
parameter. So I suppose if you design your equals method to make calls on the parameter
assuming interceptors will be run (for injection, etc), then this patch would hurt you.
But I think no one should be making those assumptions for an equals method.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Gavin King
Attachments: reflexive-equals.txt
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=comments#action_12378934 ]
Matt Drees commented on JBSEAM-1257:
------------------------------------
I added an entry to http://wiki.jboss.org/wiki/Wiki.jsp?page=SeamProblemsFAQ. If this
issue is resolved, that entry should be removed.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Gavin King
Attachments: reflexive-equals.txt
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:50 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=all ]
Pete Muir updated JBSEAM-1257:
------------------------------
Fix Version/s: 2.0.1.GA
Assignee: Pete Muir (was: Gavin King)
Matt, I'm scheduling this for 2.0.1 as I think it needs a little discussion as it does
alter the behaviour of beans. We don't have time for this release unfotunately.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Pete Muir
Fix For: 2.0.1.GA
Attachments: reflexive-equals.txt
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=all ]
Pete Muir closed JBSEAM-1257.
-----------------------------
Resolution: Done
Thanks Matt, I applied the patch and added a test. Sorry about the time it took to get
this in!
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Pete Muir
Fix For: 2.0.1.GA
Attachments: reflexive-equals.txt
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:08 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1257) default equals() on javabean components is not reflexive
[ http://jira.jboss.com/jira/browse/JBSEAM-1257?page=comments#action_12388986 ]
Matt Drees commented on JBSEAM-1257:
------------------------------------
Thanks Pete. I'll kill the FAQ entry when 2.0.1GA is released.
default equals() on javabean components is not reflexive
--------------------------------------------------------
Key: JBSEAM-1257
URL: http://jira.jboss.com/jira/browse/JBSEAM-1257
Project: JBoss Seam
Issue Type: Bug
Components: Core
Affects Versions: 1.2.1.GA
Reporter: Matt Drees
Assigned To: Pete Muir
Fix For: 2.0.1.GA
Attachments: reflexive-equals.txt
If a javabean component doesn't override equals(), the javassist proxy generated for
it has a nonreflexive equals method. I.e., component.equals(component) returns false.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6258
days inactive
6470
days old
9 comments
3 participants
participants (3)
-
Matt Drees (JIRA) -
Max Andersen (JIRA)
-
Pete Muir (JIRA)