[JBoss JIRA] Created: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
2:19 p.m.
@End should probably not throw exceptions if a conversation could not be ended because it
does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://jira.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha4
Reporter: Lincoln Baxter III
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:37 a.m.
New subject: [JBoss JIRA] Updated: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
[
https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plug...
]
Brian Leathem updated SEAMFACES-46:
-----------------------------------
Fix Version/s: 3.1.0.Tracking
@End should probably not throw exceptions if a conversation could not
be ended because it does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://issues.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha3
Reporter: Lincoln Baxter III
Fix For: 3.1.0.Tracking
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:19 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
[
https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plug...
]
Brian Leathem commented on SEAMFACES-46:
----------------------------------------
Similarly, @Begin should not necessarily throw an exception if a Conversation is already
long-running.
@End should probably not throw exceptions if a conversation could not
be ended because it does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://issues.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha3
Reporter: Lincoln Baxter III
Fix For: 3.1.0.Tracking
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 p.m.
New subject: [JBoss JIRA] Assigned: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
[
https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plug...
]
Shane Bryzak reassigned SEAMFACES-46:
-------------------------------------
Assignee: Sebastian Sachtleben
@End should probably not throw exceptions if a conversation could not
be ended because it does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://issues.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha3
Reporter: Lincoln Baxter III
Assignee: Sebastian Sachtleben
Fix For: 3.1.0.Tracking
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:21 p.m.
New subject: [JBoss JIRA] Updated: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
[
https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plug...
]
Anonymous updated SEAMFACES-46:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/seam/faces/pull/50
@End should probably not throw exceptions if a conversation could not
be ended because it does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://issues.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha3
Reporter: Lincoln Baxter III
Assignee: Sebastian Sachtleben
Fix For: 3.1.0.Tracking
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
[
https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plug...
]
Sebastian Sachtleben commented on SEAMFACES-46:
-----------------------------------------------
Added check for conversation.isTransient() on endConversation method. Properly tested, no
more exception occur just debug log message "No conversation found after
method".
The current behavior of @Begin is, that every invoke of that method creates a new
conversation. The first invoke creates conversation id 1. The next invoke
beginConversation of ConversationBoundaryInterceptor still says conversation id is null
and transient. Its not possible to add a check to keep the same conversation like
@Begin(join=true). The @End invoke is fine. Conversation id is set. But why is the
conversation id null on beginConversation even if its invoked before?
@End should probably not throw exceptions if a conversation could not
be ended because it does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://issues.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha3
Reporter: Lincoln Baxter III
Assignee: Sebastian Sachtleben
Fix For: 3.1.0.Tracking
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:04 p.m.
New subject: [JBoss JIRA] Updated: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist
[
https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plug...
]
George Gastaldi updated SEAMFACES-46:
-------------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
@End should probably not throw exceptions if a conversation could not
be ended because it does not exist
--------------------------------------------------------------------------------------------------------
Key: SEAMFACES-46
URL: https://issues.jboss.org/browse/SEAMFACES-46
Project: Seam Faces
Issue Type: Feature Request
Components: Conversations
Affects Versions: 3.0.0.Alpha3
Reporter: Lincoln Baxter III
Assignee: Sebastian Sachtleben
Fix For: 3.1.0.Tracking
The @End annotation calls conversation.end() without first checking
conversation.isTransient(). This results in exceptions when invoking the method on a
transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4844
days inactive
5243
days old
6 comments
6 participants
participants (6)
-
Anonymous (JIRA) -
Brian Leathem (JIRA)
-
George Gastaldi (JIRA)
-
Lincoln Baxter III (JIRA)
-
Sebastian Sachtleben (JIRA)
-
Shane Bryzak (JIRA)