4:14 p.m.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:57 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Ales Justin commented on JBSEAM-3655:
-------------------------------------
By the name, ServerConversationContext, this can probebly get used by multiple threads at
the same time?
Unless instance itself is synchronized, using HashMap is a no-no, since it can lead to
weird behavior:
A HashMap can break completely if two threads are updating
the underlying data structures at the same time.
This can then cause all sorts of weird behaviour,
e.g. infinite loops when the broken linked list
contains links that link to themselves.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3655:
-----------------------------------
Conversations are single threaded by default.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:56 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom commented on JBSEAM-3655:
--------------------------------------------
And I believe all of the Context objects are essentially request scoped. The get created
at the beginning of the request in something like FacesLifecycle.beginRequest() and
destroyed in FacesLifecycle.endRequest(). So I believe we can assume this object
doesn't need to be thread safe. It already isn't thread safe since its usinng
HashMaps for the additions and removals Maps.
The main question with this change is if it's possible to add or remove something from
a conversation in the middle of a request without going through this Context object.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:10 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3655:
-----------------------------------
It's the only way.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:58 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom resolved JBSEAM-3655.
----------------------------------------
Resolution: Done
fixed
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom commented on JBSEAM-3655:
--------------------------------------------
Pete requested some data on what this issue does performance wise.
I have a test that goes through the CRUD operations of an entity for an in house app. I
did two test runs one with this patch and one without.
Here are the results for calls to this method:
org.jboss.seam.contexts.ServerConversationContext.get(String)
Without patch:
127,120 Invocations
33.852 Seconds
With patch:
127,300 Invocations
5,350ms Seconds
So by no means is this scientific but it appears that this patch makes Conversation get
requests about 84% faster.
Mike
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Nicolas Feybesse commented on JBSEAM-3655:
------------------------------------------
Hi,
This is a good new for the performance but this cache cause me a lot of problems...
One of these is that @PerNestedConversation do not work any more in my nested
Conversations.
Please, could you add a Public method to clear the cache in the SVN ?
I really need it!
NF
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:05 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom reopened JBSEAM-3655:
----------------------------------------
Shoot. this is the kind of feedback I was looking for with this. Looks like we might have
to roll this back. I'll take a look and roll it back if I cannot find a way around
this issue.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:05 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom updated JBSEAM-3655:
---------------------------------------
Fix Version/s: 2.1.1.CR2
(was: 2.1.1.CR1)
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:49 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom commented on JBSEAM-3655:
--------------------------------------------
Looking at the code perhaps I can just skip the cache if the component is
"isPerNestedConversation". Can you try this patch Nicolas? Change the get
method of ServerConversationContext to:
public Object get(String name) {
if(!cache.containsKey(name)) {
Object value = resolveValue(name);
if(!isPerNestedConversation(name)) {
cache.put(name, value);
} else {
return value;
}
}
return cache.get(name);
}
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
midnight
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Nicolas Feybesse commented on JBSEAM-3655:
------------------------------------------
Thanks Michael
Your patch fixes well my @PerNestedConversation problems.
I don't know if it resolves all my issues, but it's really better.
Could you commit it in the SVN ? (Nightly build mavenized project...)
I will notice you if I discover other issues.
Thanks
NF
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom resolved JBSEAM-3655.
----------------------------------------
Resolution: Done
fix committed. Let me know if you notice any other problems with this patch.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom updated JBSEAM-3655:
---------------------------------------
Fix Version/s: 2.1.1.CR1
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:03 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Nicolas Feybesse commented on JBSEAM-3655:
------------------------------------------
Michael,
I have another problem : when I do a Manager.instance().initializeTemporaryConversation()
or Manager.instance().leaveConversation(), I have to do a
((ServerConversationContext)Contexts.getConversationContext()).clear();
I am not sure, but perhaps it is a good Idea to clear the cache in these methods.
NF
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:48 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom reopened JBSEAM-3655:
----------------------------------------
Thanks, I'll take a look.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom commented on JBSEAM-3655:
--------------------------------------------
Hmm.....so it appears to me that this may be a bug in Seam already. If you call
initializeTemporaryConversation() and you've added a bean to the conversation context
and then call "initializeTemporaryConversation()" then that temporary
conversation will return the recently added bean from the previous conversation. Does
that correct? If so perhaps it makes sense to call
((ServerConversationContext)Contexts.getConversationContext()).clear(); in
initializeTemporaryConversation regardless of the caching. What do you think? If that
makes sense I may create a separate issue for that and check a fix in under that issue.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:57 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom commented on JBSEAM-3655:
--------------------------------------------
Created JBSEAM-3777
Thinking about this a bit more I believe that perhaps the correct approach is for
Manager.instance().initializeTemporaryConversation() to call flush prior to creating the
new conversation and that perhaps we should clear the cache whenever flush() is called. I
would like to keep the cache behind the scenes as possible. Thoughts?
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:07 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Nicolas Feybesse commented on JBSEAM-3655:
------------------------------------------
Michaël,
I think you are right : there was a bug in Seam already. (I remember some problems I
encountered with initializeTemporaryConversation())
I think there are two needs with Manager.instance().initializeTemporaryConversation() :
1) When we really want a new virgin conversation : the maps need to be cleaned and the
cache too (for example : we don't want to keep the EntityManager)
2) When we want a new conversation, but we want to keep objects that are alraedy added.
Personally, I need the two behaviors.
I propose :
public initializeTemporaryConversation(boolean keepContent){ ... }
What about Manager.instance().leaveConversation() ?
NF
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:10 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom commented on JBSEAM-3655:
--------------------------------------------
I'm a little bit confused about tyour keepContent flag. Couldn't the conversation
just flush all the time and if you want to use what it flushes great otherwise it will
eventually just expire and go away?
As far as "leaveConversation" goes it calls initializeTemporaryCovnersation so I
hoped to kill both birds with the one stone.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:47 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Michael Youngstrom resolved JBSEAM-3655.
----------------------------------------
Resolution: Won't Fix
I decided that this feature was too risky for the level of reward. Conversation
management code would need to be cleaned up and given more structure and cleaner contracts
in order for this to work. Perhaps something like this could work in a future minor
release of seam but I see now this is too risky for a bugfix release.
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR2, 2.1.1.CR1
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:31 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Nicolas Feybesse commented on JBSEAM-3655:
------------------------------------------
Michaël :
If you are already in a long running conversation and you wan't to switch to a second
long running conversation :
If it doesn't exist, you have to create it the first time.
I don't wan't to keep the EntityManager when I create the second long running
conversation.
How can I do this currently ?
Here is a workaround :
Manager.instance().initializeTemporaryConversation();
((ServerConversationContext)Contexts.getConversationContext()).clear();
Manager.instance().beginConversation();
Without ((ServerConversationContext)Contexts.getConversationContext()).clear();
The new long running conversation keeps the first entitymanager.
I would like to manage several EntityManagers independantly (for flush, for close, for
lazy...).
Could you tell me the way to do that ?
NF
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:35 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3655) Caching in ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3655?page=com.atlassian.jira.pl...
]
Jay Balunas closed JBSEAM-3655.
-------------------------------
Caching in ServerConversationContext
-------------------------------------
Key: JBSEAM-3655
URL: https://jira.jboss.org/jira/browse/JBSEAM-3655
Project: Seam
Issue Type: Bug
Components: Core
Reporter: Michael Youngstrom
Assignee: Michael Youngstrom
Fix For: 2.1.1.CR1, 2.1.1.CR2
In my application profiling the SeamELResolver is an extremely hot spot.
ServerConversationContext was the hottest. I think it would be safe to create a request
scoped cache on ServerCovnersationContext. I believe nobody can really be add or removing
values from the conversation without going through the ServerConversationContext. In my
tests caching resolution of conversation values greatly improved EL performance.
Index: src/main/org/jboss/seam/contexts/ServerConversationContext.java
===================================================================
--- src/main/org/jboss/seam/contexts/ServerConversationContext.java (revision 9465)
+++ src/main/org/jboss/seam/contexts/ServerConversationContext.java (working copy)
@@ -36,6 +36,7 @@
private final Set<String> removals = new HashSet<String>();
private final String id;
private final List<String> idStack;
+ private final Map<String, Object> cache = new HashMap<String, Object>();
private List<String> getIdStack()
{
@@ -81,8 +82,15 @@
this.idStack = new LinkedList<String>();
idStack.add(id);
}
+
+ public Object get(String name) {
+ if (!cache.containsKey(name)) {
+ cache.put(name, resolveValue(name));
+ }
+ return cache.get(name);
+ }
- public Object get(String name)
+ protected Object resolveValue(String name)
{
Object result = additions.get(name);
if (result!=null)
@@ -148,6 +156,7 @@
public void set(String name, Object value)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preSetVariable." + name);
+ cache.remove(name);
if (value==null)
{
//yes, we need this
@@ -185,6 +194,7 @@
public void remove(String name)
{
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.preRemoveVariable." + name);
+ cache.remove(name);
additions.remove(name);
removals.add(name);
if ( Events.exists() )
Events.instance().raiseEvent("org.jboss.seam.postRemoveVariable." + name);
@@ -245,6 +255,7 @@
public void clear()
{
+ cache.clear();
additions.clear();
removals.addAll( getNamesFromSession() );
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5780
days inactive
5819
days old
22 comments
5 participants
participants (5)
-
Ales Justin (JIRA) -
Jay Balunas (JIRA)
-
Michael Youngstrom (JIRA)
-
Nicolas Feybesse (JIRA)
-
Pete Muir (JIRA)