[ http://jira.jboss.com/jira/browse/JBSEAM-1373?page=all ] Gavin King reassigned JBSEAM-1373: ---------------------------------- Assignee: Michael Yuan -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-1373?page=comments#action_12364268 ] Michael Yuan commented on JBSEAM-1373: -------------------------------------- The basic code and example are checked in (yes, I did test the example). I think it is good enough for ALPHA release since we are pressed for time ... However, I do want to add a few other things w.r.t Quartz integration. Shall I raise separate JIRA issues for BETA1 for the following points? 1. One of the features of Quartz is that it can specify a "stop time" for the repeating task. We do not have that now. Shall we add a new timer annotation for that? What do we call it? (we already use @Expiration for start time ;)). 2. Perhaps, we should write a QuartzTriggerSchedule class to wrap a Quartz Trigger. It would allow the user to build their own triggers and then use @Trigger trigger to pass to a async method. We can provide that in addition to the current support for fixed interval and cron jobs. 3. Right now the TimerServiceDispatcher and ThreadPoolDispatcher still use TimerSchedule. But I think it might be better to change it to "Schedule" and then use "schedule instanceof TimerSchedule" in the "scheduleWithXYZ()" method to replace " schedule.getIntervalDuration()!=null". I just think it makes the code cleaner. cheers Michael -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira