[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
1:54 a.m.
Natural conversation id initialized at wrong time, leading to exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.x, 2.1.0.BETA1
When there is a request to use a natural conversation, and the conversation id is not part
of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=all ]
Dan Allen updated JBSEAM-3053:
------------------------------
Attachment: JBSEAM-3053-trunk-v1.txt
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.1.0.BETA1, 2.0.x
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=all ]
Dan Allen updated JBSEAM-3053:
------------------------------
Attachment: JBSEAM-3053-branch_20-v1.txt
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.1.0.BETA1, 2.0.x
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=comments#action_12414967 ]
Pete Muir commented on JBSEAM-3053:
-----------------------------------
Ok, how do you intend not to introduce a regression for JBSEAM-2583?
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.1.0.BETA1, 2.0.x
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=comments#action_12415034 ]
Dan Allen commented on JBSEAM-3053:
-----------------------------------
From my perspective, it address that other problem too. You stated:
"currently, it's not able to build the natural conversation id, so gives it a
synthetic ID"
That's only because the logic inside of the natural conversation id class was:
String id = getRequestConversationId(parameters);
return id==null ? Id.nextId() : id;
Which is clearly the source of the problem in this case. It was knowingly generating a
synthetic ID. Now the logic takes this opportunity to generate a natural conversation id
return id == null ? getConversationId() : id;
Where getConversationId() evaluates the EL expression. The screwy part before was that the
natural conversation id class was calling the synthetic id generator.
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.x, 2.1.0.BETA1
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:21 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=comments#action_12415080 ]
Pete Muir commented on JBSEAM-3053:
-----------------------------------
Ok, I got confused.
As long as it doesn't cause a regression for JBSEAM-2583 then please apply.
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.1.0.BETA1, 2.0.x
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:49 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=comments#action_12416114 ]
Dan Allen commented on JBSEAM-3053:
-----------------------------------
I can confirm that my fix works and does not cause a regression. Here is what I did.
1) Generate an app with seam-gen, using one entity User.
2) Define a natural conversation in /WEB-INF/pages.xml
<conversation name="User" parameter-name="userId"
parameter-value="#{userHome.instance.id}"/>
3) In the UserEdit.page.xml, disable the <begin-conversation/> tag for the purpose
of this demonstration
4) In the UserEdit.page.xml, enable a natural conversation conversation="User"
5) On the Course.xhtml add a UI command link in a form
<h:commandLink action="edit" value="Edit"><s:conversationName
value="User"/><s:conversationPropagation
type="join"/></h:commandLink>
6) Add a navigation rule to Course.page.xml
<navigation from-action="edit">
<redirect view-id="/UserEdit.xhtml"/>
</navigation>
7) After clicking on the link, you will see that cid= is not present in the URL location
bar and that /debug.seam reports one natural conversation is present.
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.CR1, 2.1.0.BETA1
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:55 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=all ]
Dan Allen resolved JBSEAM-3053.
-------------------------------
Resolution: Done
Natural conversation id initialized at wrong time, leading to
exceptions
------------------------------------------------------------------------
Key: JBSEAM-3053
URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.CR1, 2.1.0.BETA1
Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
Original Estimate: 1 hour
Remaining Estimate: 1 hour
When there is a request to use a natural conversation, and the conversation id is not
part of the request, the natural value (EL) is being resolved prior to the temporary
conversation being initialized, potentially leading to exceptions. The natural value
should be resolved when the conversation id provider is asked to initialize a value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6058
days inactive
6068
days old
7 comments
2 participants
participants (2)
-
Dan Allen (JIRA) -
Pete Muir (JIRA)