[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter
1:18 p.m.
"value required" message for missing page param should give name of missing
parameter
-------------------------------------------------------------------------------------
Key: JBSEAM-4056
URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
Project: Seam
Issue Type: Patch
Components: Core
Affects Versions: 2.1.1.GA
Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
Reporter: Ian Darwin
When you somehow submit a post with a missing page param, the stack trace only says:
javax.faces.validator.ValidatorException: value is required
at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
...
The attached patch changes the message to
javax.faces.validator.ValidatorException: value is required pKey
making it much easier to diagnose the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter
[
https://jira.jboss.org/jira/browse/JBSEAM-4056?page=com.atlassian.jira.pl...
]
Ian Darwin updated JBSEAM-4056:
-------------------------------
Attachment: to.seam
Patch against 2.1.1.GA/src corrects this issue.
Also fixes one minor typo in comment.
"value required" message for missing page param should give
name of missing parameter
-------------------------------------------------------------------------------------
Key: JBSEAM-4056
URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
Project: Seam
Issue Type: Patch
Components: Core
Affects Versions: 2.1.1.GA
Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
Reporter: Ian Darwin
Attachments: to.seam
When you somehow submit a post with a missing page param, the stack trace only says:
javax.faces.validator.ValidatorException: value is required
at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
...
The attached patch changes the message to
javax.faces.validator.ValidatorException: value is required pKey
making it much easier to diagnose the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:23 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter
[
https://jira.jboss.org/jira/browse/JBSEAM-4056?page=com.atlassian.jira.pl...
]
Norman Richards commented on JBSEAM-4056:
-----------------------------------------
I'm not sure I agree. With this change, it would never be possible to use a message
that didn't have the name appended. Is the field not passed in as the {0} parameter
for the required field message?
"value required" message for missing page param should give
name of missing parameter
-------------------------------------------------------------------------------------
Key: JBSEAM-4056
URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
Project: Seam
Issue Type: Patch
Components: Core
Affects Versions: 2.1.1.GA
Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
Reporter: Ian Darwin
Attachments: to.seam
When you somehow submit a post with a missing page param, the stack trace only says:
javax.faces.validator.ValidatorException: value is required
at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
...
The attached patch changes the message to
javax.faces.validator.ValidatorException: value is required pKey
making it much easier to diagnose the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:03 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter
[
https://jira.jboss.org/jira/browse/JBSEAM-4056?page=com.atlassian.jira.pl...
]
Dan Allen resolved JBSEAM-4056.
-------------------------------
Fix Version/s: 2.1.2.GA
Resolution: Done
Assignee: Dan Allen
I have resolved this issue the official JSF way. I use the "get message from resource
bundle or default approach" and pass in the parameter name as an argument that can be
used in the message template. There are actually two keys:
Scenario #1: parameter required
Key: org.jboss.seam.param.Required
Default: '{0}' parameter is required
0 = name of parameter
Scenario #2: parameter invalid
Key: org.jboss.seam.param.Invalid
Default: '{1}' parameter is invalid: {0}
0 = validation message or exception message
1 = name of parameter
I know it seems strange to make {1} the placeholder for the name of the parameter in the
second scenario, but that is consistent with all other validators in JSF. The label is
always the last positional parameter.
"value required" message for missing page param should give
name of missing parameter
-------------------------------------------------------------------------------------
Key: JBSEAM-4056
URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
Project: Seam
Issue Type: Patch
Components: Core
Affects Versions: 2.1.1.GA
Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
Reporter: Ian Darwin
Assignee: Dan Allen
Fix For: 2.1.2.GA
Attachments: to.seam
When you somehow submit a post with a missing page param, the stack trace only says:
javax.faces.validator.ValidatorException: value is required
at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
...
The attached patch changes the message to
javax.faces.validator.ValidatorException: value is required pKey
making it much easier to diagnose the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:05 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter
[
https://jira.jboss.org/jira/browse/JBSEAM-4056?page=com.atlassian.jira.pl...
]
Dan Allen commented on JBSEAM-4056:
-----------------------------------
You can have the name of the parameter excluded by overriding these message keys in your
resource bundle and leaving out the positional parameter corresponding to the parameter
name.
"value required" message for missing page param should give
name of missing parameter
-------------------------------------------------------------------------------------
Key: JBSEAM-4056
URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
Project: Seam
Issue Type: Patch
Components: Core
Affects Versions: 2.1.1.GA
Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
Reporter: Ian Darwin
Assignee: Dan Allen
Fix For: 2.1.2.GA
Attachments: to.seam
When you somehow submit a post with a missing page param, the stack trace only says:
javax.faces.validator.ValidatorException: value is required
at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
...
The attached patch changes the message to
javax.faces.validator.ValidatorException: value is required pKey
making it much easier to diagnose the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter
[
https://jira.jboss.org/jira/browse/JBSEAM-4056?page=com.atlassian.jira.pl...
]
Norman Richards closed JBSEAM-4056.
-----------------------------------
"value required" message for missing page param should give
name of missing parameter
-------------------------------------------------------------------------------------
Key: JBSEAM-4056
URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
Project: Seam
Issue Type: Patch
Components: Core
Affects Versions: 2.1.1.GA
Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
Reporter: Ian Darwin
Assignee: Dan Allen
Fix For: 2.1.2.CR2
Attachments: to.seam
When you somehow submit a post with a missing page param, the stack trace only says:
javax.faces.validator.ValidatorException: value is required
at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
...
The attached patch changes the message to
javax.faces.validator.ValidatorException: value is required pKey
making it much easier to diagnose the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5719
days inactive
5763
days old
5 comments
3 participants
participants (3)
-
Dan Allen (JIRA) -
Ian Darwin (JIRA)
-
Norman Richards (JIRA)