[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
1:34 p.m.
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/jira/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:04 a.m.
New subject: [JBoss JIRA] Updated: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Cody Lerum updated JBSEAM-4284:
-------------------------------
Attachment: JBSEAM-4284
Also seeing this. I created a patch against the trunk
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Attachments: JBSEAM-4284
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:40 a.m.
New subject: [JBoss JIRA] Commented: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Cody Lerum commented on JBSEAM-4284:
------------------------------------
Also attaching the stack trace when it fails.
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:40 a.m.
New subject: [JBoss JIRA] Updated: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Cody Lerum updated JBSEAM-4284:
-------------------------------
Attachment: JBSEAM-4284.stacktrace.txt
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:52 a.m.
New subject: [JBoss JIRA] Commented: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Marek Novotny commented on JBSEAM-4284:
---------------------------------------
I looked at the sources and patch and I am not sure that this issue is only in fixing
position of pageflow name substring. Documentation says that type should be
type="nested", but propagation type in Enum is
org.jboss.seam.core.PropagationType.NEST. Anyway you can set the type attribute to
whatever you want, it is not validated if it should be nest or nested.
Have you tried to use type="nest" instead of type="nested"?
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 p.m.
New subject: [JBoss JIRA] Resolved: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Marek Novotny resolved JBSEAM-4284.
-----------------------------------
Assignee: Marek Novotny
Fix Version/s: 2.2.1.CR3
Resolution: Done
I applied patch plus I fixed also ambiguity of type attribute in s:conversationPropagation
tag.
Now implementation and Seam tag lib library describes type of conversationPropagation the
same as enum org.jboss.seam.core.PropagationType.
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Assignee: Marek Novotny
Fix For: 2.2.1.CR3
Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 p.m.
New subject: [JBoss JIRA] Closed: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Marek Novotny closed JBSEAM-4284.
---------------------------------
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Assignee: Marek Novotny
Fix For: 2.2.1.CR3
Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:58 p.m.
New subject: [JBoss JIRA] Commented: (JBSEAM-4284) Wrong pageflow name in case of nested conversation
[
https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin....
]
Cody Lerum commented on JBSEAM-4284:
------------------------------------
Just built and tested in my app after your 13830 commit. looks good.
Wrong pageflow name in case of nested conversation
--------------------------------------------------
Key: JBSEAM-4284
URL: https://jira.jboss.org/browse/JBSEAM-4284
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Reporter: Vesa Hiltunen
Assignee: Marek Novotny
Fix For: 2.2.1.CR3
Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
I tried to start nested conversation with new pageflow as follows:
<s:link value="DoIt" action="/pages/myPage.xhtml">
<s:conversationPropagation type="nested"
pageflow="myPageflowName" />
</s:link>
Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
Request parameter was: conversationPropagation=nested.myPageflowName
It looks like method getPropagationFromRequestParameter(Map parameters) in
org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string
"nested." was "nest."
Current code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>5 )
{
pageflow = value.substring(5);
}
}
One way to fix the code:
else if (value.startsWith("nest"))
{
propagationType = PropagationType.NEST;
if ( value.length()>7 )
{
pageflow = value.substring(7);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5010
days inactive
5476
days old
7 comments
3 participants
participants (3)
-
Cody Lerum (JIRA) -
Marek Novotny (JIRA)
-
Vesa Hiltunen (JIRA)