[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-906) Support redirect component for navigation out of conversational scope
1:11 p.m.
Support redirect component for navigation out of conversational scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel" button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354066 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
With this, the only remaining challenge is getting the 'redirect' component
prepared and set when you start a RC. I had a few discussions about this with Gavin, and I
think a generic or preferred solution is still not present (or at least not obvious to
me).
How do you start a RC and get the 'redirect' component into it? First you need to
prepare it with 'redirect.captureCurrentRequest()', and the current request is the
one you will return to when you Cancel the RC.
Solution 1:
display.xhtml
<s:link action="edit"/>
pages.xhtml
<page view-id="/display.xhtml"
action="#{redirect.captureCurrentRequest()}">
<navigation>
<rule if-outcome="edit">
<begin-conversation/>
<redirect view-id="/edit.xhtml"/>
</rule>
</navigation>
</page>
Advantage: Easy, other stuff that also needs to be prepared before the conversation is
promoted, like any request parameters to pass into the conversation, can be encapsulated
in the page action as well.
Disadvantage: Can't call 'redirect.execute()' to get out of the RC because
there are actionMethod and actionOutcome parameters on the captured request. Need to strip
off these first.
Eh, other solutions?
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:41 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354094 ]
Gavin King commented on JBSEAM-906:
-----------------------------------
Have you seen captureCurrentView(), redirectToCapturedView()?
That stuff is new. (But relies on page parameters.)
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:01 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354103 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
Yes, but captureCurrentView() starts a conversation. That doesn't fit my Solution 1
and I had not much success with other navigation strategies.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:25 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354111 ]
Gavin King commented on JBSEAM-906:
-----------------------------------
It only starts a conv if there is none already in progress.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:32 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354126 ]
Gavin King commented on JBSEAM-906:
-----------------------------------
Proposed to support:
<page view-id="/display.xhtml">
<navigation>
<rule if-outcome="edit">
<begin-conversation/>
<capture-current-view/>
<redirect view-id="/edit.xhtml"/>
</rule>
</navigation>
</page>
And:
<page view-id="/edit.xhtml">
<navigation>
<rule if-outcome="cancel">
<end-conversation/>
<return-to-captured-view/>
</rule>
</navigation>
</page>
And possibly also support:
<end-conversation redirectToParent="true"/>
We also need the simpler forms of this:
<s:link value="Edit" view="/edit.xhtml"
propagation="begin" capture-current-view="true"/>
<s:link value="Cancel" propagation="end"
return-to-captured-view="true"/>
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:36 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354128 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
Well of course before-redirect="false" if there are FacesMessages, you get the
idea...
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:36 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354127 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
That's going to do it (I guess). And we already have the <end-conversation
before-redirect="true"/> option, which is useful if Cancel transports
FacesMessages.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:56 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354130 ]
Gavin King commented on JBSEAM-906:
-----------------------------------
Actually I think the best option is to have both:
<return-to-parent-view/>
<return-to-captured-view/>
And have them both be noops if there is no parent view or no captured view.
And if they both appear in the same rule, give the one that appears first precedence.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:14 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354131 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
(I like this):
<page view-id="/display.xhtml">
<navigation>
<rule if-outcome="edit">
<begin-conversation capture-current-view="true"/>
<redirect view-id="/edit.xhtml"/>
</rule>
</navigation>
</page>
(Not sure because of renaming Redirect methods):
<page view-id="/edit.xhtml">
<navigation>
<rule if-outcome="cancel">
<end-conversation/>
<redirect to-captured-view="true"
to-parent-view="false"/>
</rule>
</navigation>
</page>
<s:link value="Edit" view="/edit.xhtml"
propagation="begin" capture-current-view="true"/>
<s:link value="Cancel" propagation="end"
redirect-to-captured-view="true"/>
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:16 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354132 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
And maybe <begin-conversation capture-current-view="true"> should even be
the default. When do you exit a conversation and don't want to end up where you
started?
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Priority: Minor
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:25 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=all ]
Gavin King updated JBSEAM-906:
------------------------------
Fix Version/s: 1.1.8 GA
Assignee: Gavin King
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8 GA
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:53 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=all ]
Gavin King updated JBSEAM-906:
------------------------------
Attachment: navigation-patch.diff
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8 GA
Attachments: navigation-patch.diff
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=all ]
Gavin King updated JBSEAM-906:
------------------------------
Attachment: ReturnToCapturedViewNavigationHandler.java
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8 GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=all ]
Gavin King updated JBSEAM-906:
------------------------------
Attachment: ReturnToParentViewNavigationHandler.java
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8 GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354165 ]
Gavin King commented on JBSEAM-906:
-----------------------------------
So, I implemented this (patch attached).
However, after doing that...I'm inclined to think it would be better to just support
actions in navigation rules. These new elements are basically just wrappers around an
existing component method. Not sure that it is worth bloating out the DTD for this if it
can be accomplished with a single more general construct.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8 GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:27 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354182 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
Tested, page parameters are not captured:
<page view-id="/docDisplay.xhtml"
action="#{browser.prepare}">
<param name="nodeId" value="#{browser.nodeId}"/>
<navigation>
<rule if-outcome="editDoc">
<capture-current-view/>
<begin-conversation flush-mode="MANUAL"/>
<redirect view-id="/docEdit.xhtml">
<param name="docId"
value="#{currentDocument.id}"/>
<param name="parentDirId"
value="#{currentDirectory.id}"/>
</redirect>
</rule>
</page>
<page view-id="/docEdit.xhtml" login-required="true">
<navigation>
<rule if-outcome="cancel">
<end-conversation/>
<return-to-captured-view/>
</rule>
</navigation>
</page>
Click on EditDoc
http://localhost:8080/wiki/docDisplay.seam?nodeId=10&actionOutcome=ed...:
08:16:33,838 DEBUG [Lifecycle] >>> Begin web request
08:16:33,838 DEBUG [Manager] Found conversation id in request parameter: 5
08:16:33,838 DEBUG [Manager] No stored conversation, or concurrent call to the stored
conversation
08:16:33,839 DEBUG [AbstractSeamPhaseListener] After restoring conversation context:
ConversationContext(6)
08:16:33,849 DEBUG [Manager] Beginning long-running conversation
08:16:33,849 DEBUG [Manager] redirecting to:
/wiki/docEdit.seam?docId=10&parentDirId=8&cid=6&clr=true
...
Click on Cancel
http://localhost:8080/wiki/docEdit.seam?actionOutcome=cancel&cid=6&am...:
08:17:04,362 DEBUG [Lifecycle] >>> Begin web request
08:17:04,362 DEBUG [Manager] Found conversation id in request parameter: 6
08:17:04,363 DEBUG [Manager] Restoring conversation with id: 6
08:17:04,363 DEBUG [AbstractSeamPhaseListener] After restoring conversation context:
ConversationContext(6)
08:17:04,364 DEBUG [Manager] Ending long-running conversation
08:17:04,365 DEBUG [Manager] redirecting to: /wiki/docDisplay.seam?cid=6
08:17:04,367 DEBUG [Manager] Storing conversation state: 6
08:17:04,369 DEBUG [Lifecycle] <<< End web request
08:17:04,370 DEBUG [Lifecycle] >>> Begin web request
08:17:04,370 DEBUG [Manager] Found conversation id in request parameter: 6
08:17:04,370 DEBUG [Manager] Restoring conversation with id: 6
08:17:04,370 DEBUG [AbstractSeamPhaseListener] After restoring conversation context:
ConversationContext(6)
...
The nodeId is gone.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8.GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:53 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12354234 ]
Christian Bauer commented on JBSEAM-906:
----------------------------------------
The issue seems to be that the page parameter is not in the page context, Pages.java:652:
Object object = Contexts.getPageContext().get( pageParameter.getName() );
Returns null when ConversationControl.beginOrEndConversation runs and captures the view.
Don't know when page parameters are initialized, if before or after the conversation
control, probably easy if you understand AbstractSeamPhaseListener.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.1.8.GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=all ]
Gavin King closed JBSEAM-906.
-----------------------------
Resolution: Won't Fix
Will do JBSEAM-1086 instead.
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.2.1.GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:43 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-906) Support redirect component for navigation out of conversational scope
[ http://jira.jboss.com/jira/browse/JBSEAM-906?page=comments#action_12364029 ]
Gavin King commented on JBSEAM-906:
-----------------------------------
You can now raise an event when a navigation rule fires, using:
<raise-event type="endPageFlow"/>
And add a listener to that event to do the redirection :-)
Support redirect component for navigation out of conversational
scope
---------------------------------------------------------------------
Key: JBSEAM-906
URL: http://jira.jboss.com/jira/browse/JBSEAM-906
Project: JBoss Seam
Issue Type: Feature Request
Components: Core
Reporter: Christian Bauer
Assigned To: Gavin King
Priority: Minor
Fix For: 1.2.1.GA
Attachments: navigation-patch.diff, ReturnToCapturedViewNavigationHandler.java,
ReturnToParentViewNavigationHandler.java
It's about my favorite subject, the "history" or "cancel"
button.
Assume the following (RC == Root Conversation, NC == Nested Conversation):
RC(1) -> NC(2) -> NC(3)
I can render a Cancel button on each page in NC 2 and 3 with the
action=#{conversation.endAndRedirect()} to get back to any parent NC or RC.
I can not render a Cancel button on each page in RC, because there is no "parent
view-id" we could redirect to. So my Cancel button on these pages has to call some
logic I've written on my RC backing component.
I propose to extend the Conversation.endAndRedirect() method with the following logic:
- If called in a NC, do what it currently does.
- If called in a RC, check if the 'redirect' component is present in RC, if yes,
call 'redirect.execute()'
If this would be available, I could completely control conversation navigation and the
navigation history through nesting conversations (with s:link or pages.xml) and by
ensuring that a RC has a prepared 'redirect' component when it is started. All
Cancel buttons would be able to use action="#{conversation.endAndRedirect()}"
and would either get the user "one up" in the conversation stack or
"out" of conversational scope.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6449
days inactive
6549
days old
19 comments
2 participants
participants (2)
-
Christian Bauer (JIRA) -
Gavin King (JIRA)