1:25 p.m.
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: http://jira.jboss.com/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.CR1, 2.1.0.BETA1
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3083) urlBase on <m:message> does not work
[ http://jira.jboss.com/jira/browse/JBSEAM-3083?page=all ]
Dan Allen updated JBSEAM-3083:
------------------------------
Attachment: JBSEAM-3083-trunk-v1.txt
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: http://jira.jboss.com/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.CR1, 2.1.0.BETA1
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3083) urlBase on <m:message> does not work
[ http://jira.jboss.com/jira/browse/JBSEAM-3083?page=all ]
Dan Allen updated JBSEAM-3083:
------------------------------
Attachment: JBSEAM-3083-branch_20-v1.txt
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: http://jira.jboss.com/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.CR1, 2.1.0.BETA1
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:01 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3083) urlBase on <m:message> does not work
[ http://jira.jboss.com/jira/browse/JBSEAM-3083?page=all ]
Dan Allen resolved JBSEAM-3083.
-------------------------------
Resolution: Done
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: http://jira.jboss.com/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.CR1, 2.1.0.BETA1
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-3083) urlBase on <m:message> does not work
[ http://jira.jboss.com/jira/browse/JBSEAM-3083?page=all ]
Pete Muir reopened JBSEAM-3083:
-------------------------------
Please revert the API change in the 2.0 branch.
Also, I don't think the API change is corrrect at all. If you are pointing at a
different JSF app, then how do you expect it to process the request? The *reason* for this
feature is that you need more than a relative path when you are rendering an html mail.
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: http://jira.jboss.com/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.1.0.BETA1, 2.0.3.CR1
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:25 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3083) urlBase on <m:message> does not work
[ http://jira.jboss.com/jira/browse/JBSEAM-3083?page=all ]
Pete Muir updated JBSEAM-3083:
------------------------------
Fix Version/s: 2.0.3.GA
(was: 2.1.0.BETA1)
(was: 2.0.3.CR1)
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: http://jira.jboss.com/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.1.0.A1, 2.0.2.SP1
Reporter: Dan Allen
Assigned To: Dan Allen
Fix For: 2.0.3.GA
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:14 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3083) urlBase on <m:message> does not work
[
https://jira.jboss.org/jira/browse/JBSEAM-3083?page=com.atlassian.jira.pl...
]
Pete Muir closed JBSEAM-3083.
-----------------------------
Resolution: Rejected
I reverted both patches.
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: https://jira.jboss.org/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.0.2.SP1, 2.1.0.A1
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 2.0.3.CR2
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:16 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-3083) urlBase on <m:message> does not work
[
https://jira.jboss.org/jira/browse/JBSEAM-3083?page=com.atlassian.jira.pl...
]
Pete Muir reassigned JBSEAM-3083:
---------------------------------
Assignee: Pete Muir (was: Dan Allen)
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: https://jira.jboss.org/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.0.2.SP1, 2.1.0.A1
Reporter: Dan Allen
Assignee: Pete Muir
Fix For: 2.0.3.CR2
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:31 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3083) urlBase on <m:message> does not work
[
https://jira.jboss.org/jira/browse/JBSEAM-3083?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3083:
-----------------------------------
I fixed the actual bug though
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: https://jira.jboss.org/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.0.2.SP1, 2.1.0.A1
Reporter: Dan Allen
Assignee: Pete Muir
Fix For: 2.0.3.CR2
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:52 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-3083) urlBase on <m:message> does not work
[
https://jira.jboss.org/jira/browse/JBSEAM-3083?page=com.atlassian.jira.pl...
]
Dan Allen reopened JBSEAM-3083:
-------------------------------
Assignee: Dan Allen (was: Pete Muir)
As it turns out, this was not fixed.
The current logic is as follows:
MailFacesContextImpl.start(getUrlBase() +
context.getExternalContext().getRequestContextPath() == null ? "" :
context.getExternalContext().getRequestContextPath());
The problem with this logic is that the urlBase is never used. That's because the
string concatenation happens first, then the ternary operation is applied. Since the first
part is never null, it always uses the context path. If the intent is the use the urlBase
verbatim, then we need an extra set of brackets.
Here is what it should be:
MailFacesContextImpl.start(getUrlBase() == null ?
context.getExternalContext().getRequestContextPath() :
getUrlBase() + context.getExternalContext().getRequestContextPath());
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: https://jira.jboss.org/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.0.2.SP1, 2.1.0.A1
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:52 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3083) urlBase on <m:message> does not work
[
https://jira.jboss.org/jira/browse/JBSEAM-3083?page=com.atlassian.jira.pl...
]
Dan Allen resolved JBSEAM-3083.
-------------------------------
Fix Version/s: 2.1.0.BETA1
Resolution: Done
Labels: email context_path (was: )
Applied fix in comment.
urlBase on <m:message> does not work
-------------------------------------
Key: JBSEAM-3083
URL: https://jira.jboss.org/jira/browse/JBSEAM-3083
Project: Seam
Issue Type: Bug
Components: Mail
Affects Versions: 2.0.2.SP1, 2.1.0.A1
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 2.0.3.CR2, 2.1.0.BETA1
Attachments: JBSEAM-3083-branch_20-v1.txt, JBSEAM-3083-trunk-v1.txt
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
The attribute urlBase on <m:message> is broken in two fundamental ways. First, the
logic as to whether to use the urlBase doesn't make any sense at all, resulting in the
urlBase never being used. The second problem is that EL value expressions in the urlBase
are not getting resolved.
I am proposing a strategy as part of this fix. If the urlBase is used, it is taken
verbatim, without appending the current context path. The reason is, if urlBase is
overridden, it may be because it is pointing to a completely different application. If the
developer want to reuse the context path, the expression
#{facesContext.externalContext.requestContextPath} must be included in the urlBase
attribute.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5922
days inactive
5998
days old
10 comments
2 participants
participants (2)
-
Dan Allen (JIRA) -
Pete Muir (JIRA)