[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[JBoss JIRA] Created:...

[JBoss JIRA] Commented:...

Max Rydahl Andersen (JIRA)

Saturday, 7 March 2009 Sat, 7 Mar '09

11:41 a.m.

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.1.GA, 2.1.0.SP1 Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: 2.1.2.GA As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Dan Allen (JIRA)

Saturday, 7 March Sat, 7 Mar

1:40 p.m.

New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Dan Allen commented on JBSEAM-3996: ----------------------------------- I want to emphasize that solving this issue is not as straightforward as it might appear. Seam was designed so that one component could override another with the same component name and class using precedence rules. Now we are saying that if there is a conflict, it should still not fail. Let's just think this through rather than put in a quick fix.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: 2.1.2.GA As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

1:49 p.m.

New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Pete Muir commented on JBSEAM-3996: ----------------------------------- No, thats wrong "one component could override another with the same component name and class" Same name yes, exactly the same class, no. A sub/superclass yes, or the same class defined in XML (but we are way before XML kicks in here). There is absolutely no way we want to be deploying the same class twice using annotations. This is not well defined in Seam, I know, but it is implied.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: 2.1.2.GA As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Max Rydahl Andersen (JIRA)

2:23 p.m.

New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Max Rydahl Andersen commented on JBSEAM-3996: --------------------------------------------- What Pete Said :) The "duplicate class" part is key, it is not a duplicate component. I'm quite sure it was never intended for Seam to break normal classloading semantics.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: 2.1.2.GA As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Norman Richards (JIRA)

Saturday, 19 December Sat, 19 Dec

2:58 p.m.

New subject: [JBoss JIRA] Updated: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Norman Richards updated JBSEAM-3996: ------------------------------------ Fix Version/s: The future (was: 2.2.1.CR1)

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: The future As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Max Rydahl Andersen (JIRA)

Thursday, 7 January Thu, 7 Jan

5:37 a.m.

New subject: [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Max Rydahl Andersen commented on JBSEAM-3996: --------------------------------------------- seriously - the future ?, this isn't really rocket science - just dont fail if the override is same name and class so it is alignment with Java classpath semantics.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: The future As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Max Rydahl Andersen (JIRA)

5:39 a.m.

New subject: [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Max Rydahl Andersen commented on JBSEAM-3996: --------------------------------------------- note: this change in behavior causes it to break when using something like testng from eclipse where there unfortunately can be duplicates on the classpath.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: The future As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Pete Muir (JIRA)

5:55 a.m.

New subject: [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Pete Muir commented on JBSEAM-3996: ----------------------------------- We don't plan on doing any more non-critical work on Seam 2

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Fix For: The future As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Pete Muir (JIRA)

Thursday, 4 February Thu, 4 Feb

5:59 a.m.

New subject: [JBoss JIRA] Updated: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Pete Muir updated JBSEAM-3996: ------------------------------ Fix Version/s: 2.2.1.CR1 (was: The future) Priority: Critical (was: Major) This affects tooling

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Dan Allen Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Pete Muir (JIRA)

6:01 a.m.

New subject: [JBoss JIRA] Assigned: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Pete Muir reassigned JBSEAM-3996: --------------------------------- Assignee: Marek Novotny (was: Dan Allen)

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Marek Novotny (JIRA)

Friday, 5 February Fri, 5 Feb

5:52 a.m.

New subject: [JBoss JIRA] Resolved: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Marek Novotny resolved JBSEAM-3996. ----------------------------------- Resolution: Done I added a condition if a component is the same name and class => not throwing exception otherwise for component with the same name and different class, the exception will be thrown. I checked this with JBDS 3.0.0.cr2 with enabled debug in seam.properties in test project.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Max Rydahl Andersen (JIRA)

6:49 a.m.

New subject: [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Max Rydahl Andersen commented on JBSEAM-3996: --------------------------------------------- *thank you* :)

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Pete Muir (JIRA)

Friday, 26 February Fri, 26 Feb

6:43 a.m.

New subject: [JBoss JIRA] Closed: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Pete Muir closed JBSEAM-3996. -----------------------------

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Max Rydahl Andersen (JIRA)

6:54 a.m.

New subject: [JBoss JIRA] Reopened: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Max Rydahl Andersen reopened JBSEAM-3996: ----------------------------------------- Looking at the patch I do not believe this will solve it. The comparison should be based on the classname to avoid any problems with classpath order and different classloaders. Since Seam should only have access to *one* class within one classloader it should be enough to compare the class name.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Max Rydahl Andersen (JIRA)

6:59 a.m.

New subject: [JBoss JIRA] Commented: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Max Rydahl Andersen commented on JBSEAM-3996: --------------------------------------------- note, the current patch will probably work in a single standalone unit tests, but running inside a container that you might be scanning manually you could bump into the same classname but different classloaders and then the equals method will return false and that is exactly the case we want to avoid. Reading Marek's note says it does solve it for JBDS which is great - but just saying that I think the correct patch is to just use the class name and ignore any of the classloader comparison clazz().equals will do.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR1 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Marek Novotny (JIRA)

Monday, 1 March Mon, 1 Mar

2:14 a.m.

New subject: [JBoss JIRA] Updated: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Marek Novotny updated JBSEAM-3996: ---------------------------------- Fix Version/s: 2.2.1.CR2 (was: 2.2.1.CR1) I agree that it should be changed to compare only class names. I will fix it in next CR2.

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR2 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

Marek Novotny (JIRA)

Thursday, 18 March Thu, 18 Mar

8:16 a.m.

New subject: [JBoss JIRA] Closed: (JBSEAM-3996) Seam should ignore duplicate classes on classpath

[ https://jira.jboss.org/jira/browse/JBSEAM-3996?page=com.atlassian.jira.pl... ] Marek Novotny closed JBSEAM-3996. --------------------------------- Resolution: Done fixed

...

Seam should ignore duplicate classes on classpath ------------------------------------------------- Key: JBSEAM-3996 URL: https://jira.jboss.org/jira/browse/JBSEAM-3996 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.1.0.SP1, 2.1.1.GA Reporter: Max Rydahl Andersen Assignee: Marek Novotny Priority: Critical Fix For: 2.2.1.CR2 As discussed in JBIDE-3623 then Seam is reporting "Two components with the same name and precedence - component name: <name>, component classes: <classname>" when the class name is exactly the same. In that case it should only be the one that is first on the classpath that is used; that the class exist in other locations is irrelevant since you won't be able to load the class anyway since in java classloading first-found wins.

5394

days inactive

5770

days old

seam-issues@lists.jboss.org

Manage subscription

16 comments

5 participants

tags (0)

participants (5)

Dan Allen (JIRA)
Marek Novotny (JIRA)
Max Rydahl Andersen (JIRA)
Norman Richards (JIRA)
Pete Muir (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3996) Seam should ignore duplicate classes on classpath