4:01 p.m.
Hi;
Specification states that depending context is active --> "while an observer
method is invoked", but it does not state that where is the starting point for the
activation. In the TCK tests, it is activated on the Manager#fireEvent.
But currently in the OpenWebBeans project, we activate the Dependent Context at the start
of the Observer#notify method.
Which one is correct?
Thanks;
/Gurkan
3:25 p.m.
Well, the spec says "observer method". It doesn't say anything about
other observers. So It would be perfectly fine to do it in the
notify() method, but not wrong to do it form fireEvent().
On Sat, Feb 28, 2009 at 4:01 PM, Gurkan Erdogdu <gurkanerdogdu(a)yahoo.com> wrote:
--
Gavin King
gavin.king(a)gmail.com
http://in.relation.to/Bloggers/Gavin
http://hibernate.org
http://seamframework.org
1:02 a.m.
Thanks for answering Gavin.
Then, we can not pass the TCK test if we use Observer#notify :)
________________________________
From: Gavin King <gavin(a)hibernate.org>
To: Gurkan Erdogdu <gurkanerdogdu(a)yahoo.com>
Cc: webbeans-dev(a)lists.jboss.org
Sent: Sunday, March 1, 2009 11:25:06 PM
Subject: Re: [webbeans-dev] TCK Tests - Dependent Context Activation
Well, the spec says "observer method". It doesn't say anything about
other observers. So It would be perfectly fine to do it in the
notify() method, but not wrong to do it form fireEvent().
On Sat, Feb 28, 2009 at 4:01 PM, Gurkan Erdogdu <gurkanerdogdu(a)yahoo.com> wrote:
--
Gavin King
gavin.king(a)gmail.com
http://in.relation.to/Bloggers/Gavin
http://hibernate.org
http://seamframework.org
5:27 a.m.
Hi;
org/jboss/jsr299/tck/tests/context/dependent/DependentContextTest.java,
@Test(groups = { "contexts", "observerMethod" })
@SpecAssertion(section = "8.3", id = "g")
public void testContextIsActiveWhenInvokingObserverMethod()
{
getCurrentManager().fireEvent(new HorseInStableEvent());
assert HorseStable.isDependentContextActive();
}
@Test(groups = { "contexts", "observerMethod" })
@SpecAssertion(section = "8.3", id = "i")
public void testContextIsActiveWhenInvokingObserver()
{
getCurrentManager().fireEvent(new HorseInStableEvent());
assert ApplicationHorseStable.isDependentContextActive();
}I think that after the Observer#notify method [calling the HorseStable or
ApplicationHorseStable observer methods], Dependent context will be destroyed.
Gurkan
________________________________
From: David Allen <drallendc(a)gmail.com>
To: Gurkan Erdogdu <gurkanerdogdu(a)yahoo.com>
Cc: Gavin King <gavin(a)hibernate.org>; openwebbeans-dev(a)incubator.apache.org;
webbeans-dev(a)lists.jboss.org
Sent: Monday, March 2, 2009 12:36:35 PM
Subject: Re: [webbeans-dev] TCK Tests - Dependent Context Activation
On Sun, 2009-03-01 at 23:02 -0800, Gurkan Erdogdu wrote:
Thanks for answering Gavin.
Then, we can not pass the TCK test if we use Observer#notify :)
Which test in the TCK are you referring to?
8:20 a.m.
On Mon, 2009-03-02 at 03:27 -0800, Gurkan Erdogdu wrote:
This test was testing the same thing as the one below, so it has been
changed and renamed to
testContextIsActiveWhenCreatingObserverMethodInstance. Now it properly
tests the condition from the specification that states:
The @Dependent scope is inactive except:
• when an instance of a bean with scope @Dependent is created by the
container to receive a producer method, producer
field, disposal method or observer method invocation, or
This test is correct and verifies that the dependent context is active
while the observer method is called, not after fireEvent(). The
isDependentContextActive() method is not checking at that moment, but
checking whether it was active when the event was fired.
Yes, this is correct, but does not actually have anything to do with
these tests since the dependentContextActive member was set while the
observer method was executed, not while it is queried.
5875
days inactive
5877
days old
5 comments
3 participants
participants (3)
-
David Allen -
Gavin King -
Gurkan Erdogdu