We want some extra info from the manifest that isn't defined on Package (and Package doesn't allow you to get arbitrary info, just specific info...) Nik, if you put this in core, you can make it a Service with a default impl (JDKManifestFinder), and JBoss can use the VFSManifestFinder. On 1 Dec 2009, at 15:32, Ales Justin wrote: > http://anonsvn.jboss.org/repos/jbossas/projects/weld-int/trunk/deployer/s... > > But why Manifest in the first place? > If the classloading is done right, > Class::getPackage() should get you the right info. > > -Ales _______________________________________________ weld-dev mailing list weld-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-dev

The module. On 1 Dec 2009, at 16:09, Gavin King wrote: > Well, a package-level annotation would do it. It all depends upon > whether you really want info about the package, or about the *module*. > Which is it? > > On Tue, Dec 1, 2009 at 10:35 AM, Pete Muir <pmuir(a)redhat.com&gt; wrote: >> We want some extra info from the manifest that isn't defined on Package (and Package doesn't allow you to get arbitrary info, just specific info...) >> >> Nik, if you put this in core, you can make it a Service with a default impl (JDKManifestFinder), and JBoss can use the VFSManifestFinder. >> >> On 1 Dec 2009, at 15:32, Ales Justin wrote: >> >>> http://anonsvn.jboss.org/repos/jbossas/projects/weld-int/trunk/deployer/s... >>> >>> But why Manifest in the first place? >>> If the classloading is done right, >>> Class::getPackage() should get you the right info. >>> >>> -Ales >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev >> > > > > -- > Gavin King > gavin.king(a)gmail.com > http://in.relation.to/Bloggers/Gavin > http://hibernate.org > http://seamframework.org

Pete, if you would like us to add a <description/> tag to beans.xml in the maintenance release, let me know.

ok On Tue, Dec 1, 2009 at 11:23 AM, Pete Muir <pmuir(a)redhat.com&gt; wrote: > FTR, what Nik wants is the ability to do: > > if (portableExtension) { >   log.info("Loading " + portableExtensionName + " " + portableExtensionVersion); > } > > I'm not quite sure if this is something that should go in beans.xml (which, IMO is about a application configuration). > > TBH, I think the Manifest is the right place for this. > > On 1 Dec 2009, at 16:13, Gavin King wrote: > >> Pete, if you would like us to add a <description/> tag to beans.xml in >> the maintenance release, let me know. > > -- Gavin King gavin.king(a)gmail.com http://in.relation.to/Bloggers/Gavin http://hibernate.org http://seamframework.org _______________________________________________ weld-dev mailing list weld-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-dev

BTW, would <T> Manifest findManifest(Class<T> clazz) throws Exception; be a better signature if it's to be used with ProcessAnnotatedType.getAnnotatedType().getJavaClass() ?

Perhaps we even could we raise a ProcessBeanDeplomentArchive event so we wouldn't get hit for every bean in an archive? We could then call the manifestfinder once (for any file in the archive?) or find another place to check it from. Of course the extension would not be portable (unless the event goes into a rev of the spec). On Tue, Dec 1, 2009 at 6:25 PM, Gavin King <gavin.king(a)gmail.com&gt; wrote: > ok > > On Tue, Dec 1, 2009 at 11:23 AM, Pete Muir <pmuir(a)redhat.com&gt; wrote: >> FTR, what Nik wants is the ability to do: >> >> if (portableExtension) { >> log.info("Loading " + portableExtensionName + " " + portableExtensionVersion); >> } >> >> I'm not quite sure if this is something that should go in beans.xml (which, IMO is about a application configuration). >> >> TBH, I think the Manifest is the right place for this. >> >> On 1 Dec 2009, at 16:13, Gavin King wrote: >> >>> Pete, if you would like us to add a <description/> tag to beans.xml in >>> the maintenance release, let me know. >> >> > > > > -- > Gavin King > gavin.king(a)gmail.com > http://in.relation.to/Bloggers/Gavin > http://hibernate.org > http://seamframework.org > > _______________________________________________ > weld-dev mailing list > weld-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev > -- --- Nik _______________________________________________ weld-dev mailing list weld-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-dev