Re: [aerogear-dev] Removing Auth dependency from Pipeline

On Feb 12, 2013, at 2:28 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > +1 on removing the AeroGear.ajax, and using plain jQuery > > I am not sure if it is really a good idea to have the Authenticator > become a "global management object for the pipes. > I think it makes sense to give a pipe it's authModule... > > Was the auth dependency change something that was driven by removing > the AG.ajax bits? If so, I'd like to understand the why/how. Not initially. First, the idea was that we (Luke and I) wanted to remove that dependency to allow more flexibility in building custom downloads. I wanted to be able to download Pipeline without Auth since IMO we can't currently do that because then documented functionality in Pipeline won't work.

In the process, I realized that the dependency was just going to be reversed and after the PR was discussed a bit other issues were found and the motivation switched to removing AeroGear.ajax for simplicity and smaller file size.

> > On Mon, Feb 11, 2013 at 10:15 AM, Kris Borchers <kris(a)redhat.com&gt; wrote: >> >> In https://issues.jboss.org/browse/AEROGEAR-858, I propose a change to the >> APIs of both Pipeline and Auth when creating new pipes or auth modules. What >> this change does is change the dependency from Pipeline depending on Auth to >> only the Auth rest adapter depending on Pipeline. So what does this get us? >> >> A narrower dependency between Auth and Pipeline >> Removal of AeroGear.ajax and instead build directly on top of jQuery.ajax >> which in turn gives us a much smaller file size (important for JS) >> >> >> I would appreciate other thoughts on this. There are some issues with my >> current PR (https://github.com/aerogear/aerogear-js/pull/21) but I think I >> have solutions so once I update that PR I would appreciate feedback on that >> as well. >> >> Thanks! >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev