[hibernate-commits] [hibernate/hibernate-orm] e80804: HHH-13856 - Long-awaited TODOs done as an improvement
Branch: refs/heads/wip/6.0
Home: https://github.com/hibernate/hibernate-orm
Commit: e8080414774a9818d555e349a14e146b9da8560f
https://github.com/hibernate/hibernate-orm/commit/e8080414774a9818d555e34...
Author: The Geeky Asian <msafeeransari(a)gmail.com>
Date: 2020-02-20 (Thu, 20 Feb 2020)
Changed paths:
M hibernate-core/src/main/java/org/hibernate/dialect/unique/DB2UniqueDelegate.java
M
hibernate-core/src/main/java/org/hibernate/dialect/unique/DefaultUniqueDelegate.java
M hibernate-core/src/main/java/org/hibernate/mapping/Constraint.java
M hibernate-core/src/main/java/org/hibernate/mapping/Table.java
M hibernate-core/src/test/java/org/hibernate/test/annotations/any/AnyTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/bytecode/ProxyBreakingTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/IdClassXmlTest.java
M hibernate-core/src/test/java/org/hibernate/test/annotations/loader/LoaderTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/OptionalOneToOnePKJCTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/query/QueryAndSQLTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/reflection/ElementCollectionConverterTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/xml/ejb3/Ejb3XmlTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/xml/ejb3/OrmVersion1SupportedTest.java
M hibernate-core/src/test/java/org/hibernate/test/annotations/xml/hbm/HbmTest.java
M
hibernate-core/src/test/java/org/hibernate/test/annotations/xml/hbm/HbmWithIdentityTest.java
M
hibernate-envers/src/main/java/org/hibernate/envers/configuration/internal/metadata/AuditMetadataGenerator.java
M
hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java
Log Message:
-----------
HHH-13856 - Long-awaited TODOs done as an improvement
1. TODO: Remove duplicate method from ConstraintConstaint.java currently has two duplicate
methods. 1. getColumnIterator()2. columnIterator()
Both the methods return the same value i.e. column.iterator().
One of them needs to be removed in order to reduce and clean the duplication.
2. TODO: Change method name for getXmlFiles in BaseCoreFunctionalTestCaseCurrently, in
BaseCoreFunctionalTestCase a method named getXmlFiles()has a TODO placed that suggests the
method name to be changed to getOrmXmlFiles().
Since the method has a protected scope, there is a possibility it is being used by other
clients. Hence, changing the method name in minor versions might break the code for
clients.