[hibernate-commits] [hibernate/hibernate-search] b77e41: HSEARCH-4073 Sonar: Cognitive Complexity of method...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: b77e41600e4d9e32170dbb10d77e5f676f429d42 https://github.com/hibernate/hibernate-search/commit/b77e41600e4d9e32170d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/lowlevel/syntax/search/impl/Elasticsearch56SearchSyntax.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/lowlevel/syntax/search/impl/Elasticsearch7SearchSyntax.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/lowlevel/syntax/search/impl/ElasticsearchSearchSyntax.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/scope/model/impl/ElasticsearchScopeSearchIndexesContext.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/AbstractElasticsearchDocumentValueSort.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/SearchWork.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/scope/model/impl/LuceneScopeSearchIndexesContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/LuceneCollectors.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmPathFilterFactory.java Log Message: ----------- HSEARCH-4073 Sonar: Cognitive Complexity of methods should not be too high Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: e062f4a12b3fa877621f86c35671e65e423314d2 https://github.com/hibernate/hibernate-search/commit/e062f4a12b3fa877621f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/MultiValueMode.java M engine/src/main/java/org/hibernate/search/engine/reporting/spi/EventContexts.java Log Message: ----------- HSEARCH-4073 Sonar: String literals should not be duplicated Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: daf253b2aeaee60972eccb8f840fc40600cb2185 https://github.com/hibernate/hibernate-search/commit/daf253b2aeaee60972ec... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: A integrationtest/mapper/orm-batch-jsr352/src/test/java/org/hibernate/search/integrationtest/batch/jsr352/component/HibernateSearchPartitionMapperComponentIT.java R integrationtest/mapper/orm-batch-jsr352/src/test/java/org/hibernate/search/integrationtest/batch/jsr352/component/PartitionMapperComponentIT.java M integrationtest/mapper/orm-batch-jsr352/src/test/java/org/hibernate/search/integrationtest/batch/jsr352/massindexing/RestartChunkIT.java A mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/impl/HibernateSearchPartitionMapper.java R mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/impl/PartitionMapper.java M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/spi/EntityReader.java M mapper/orm-batch-jsr352/core/src/main/resources/META-INF/batch-jobs/hibernate-search-mass-indexing.xml Log Message: ----------- HSEARCH-4073 Sonar: Class names should not shadow interfaces or superclasses Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: fccc7ba1c98cb9afdbebd5803f4af314d44a6aca https://github.com/hibernate/hibernate-search/commit/fccc7ba1c98cb9afdbeb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/GsonHttpEntity.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/HashShardingStrategy.java M build-config/src/main/java/org/hibernate/checkstyle/checks/regexp/IllegalImport.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContext.java M util/common/src/main/java/org/hibernate/search/util/common/reflect/impl/GenericTypeContext.java M util/common/src/main/java/org/hibernate/search/util/common/reporting/EventContext.java Log Message: ----------- HSEARCH-4073 Sonar: Local variables should not shadow class fields Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 54135689bd7d2efe53c63ba878dd619e9991d763 https://github.com/hibernate/hibernate-search/commit/54135689bd7d2efe53c6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchSession.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/impl/InTransactionWorkQueueSynchronization.java Log Message: ----------- HSEARCH-4073 Sonar: Remove unused, obsolete code Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 632415ae570255a4f400f676b464261005f61315 https://github.com/hibernate/hibernate-search/commit/632415ae570255a4f400... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/PropertyBindingContext.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/TypeBindingContext.java Log Message: ----------- HSEARCH-4073 Sonar: remove obsolete TODOs related to type-safe TypeBridge/PropertyBridge Moved the TODOs to HSEARCH-4088 Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: de1537569d331e3042aed97352c469cd561ed31e https://github.com/hibernate/hibernate-search/commit/de1537569d331e3042ae... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmIntegrationBooterImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java Log Message: ----------- HSEARCH-4073 Sonar: remove obsolete TODOs related to JMX Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 690dee92de51e1eed92d79a9d99f66d4526d5f5f https://github.com/hibernate/hibernate-search/commit/690dee92de51e1eed92d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/util/impl/SerializationUtil.java Log Message: ----------- HSEARCH-4073 Sonar: dead code Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 7c44b91a675b281ba9d36c4d7ad5c3a65f833e2e https://github.com/hibernate/hibernate-search/commit/7c44b91a675b281ba9d3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M integrationtest/mapper/orm-batch-jsr352/src/test/java/org/hibernate/search/integrationtest/batch/jsr352/massindexing/MassIndexingJobWithCompositeIdIT.java Log Message: ----------- HSEARCH-4073 Sonar: JUnit4 @Ignored should provide a rationale Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: bcc2c0666c02260085eb1df4b25e6ce3ccbc2d07 https://github.com/hibernate/hibernate-search/commit/bcc2c0666c02260085eb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/builder/impl/ElasticsearchWorkBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/AbstractNonBulkableWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/BulkableWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/ElasticsearchWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/NonBulkableWork.java Log Message: ----------- HSEARCH-4073 Sonar: Unused type parameters should be removed Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 0283187ebcd7993f6838d4a1b3b3fab5505c8215 https://github.com/hibernate/hibernate-search/commit/0283187ebcd7993f6838... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/impl/EntityWriter.java M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/spi/EntityReader.java Log Message: ----------- HSEARCH-4073 Sonar: Generic exceptions should never be thrown Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 72dc2f1972522f0a2c62807c0202fe097920ae94 https://github.com/hibernate/hibernate-search/commit/72dc2f1972522f0a2c62... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/service/TestDataService.java Log Message: ----------- HSEARCH-4073 Sonar: Unnecessary assertion Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 52e35143b9a8ec4b1c2de813b002ef20320ba651 https://github.com/hibernate/hibernate-search/commit/52e35143b9a8ec4b1c2d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/MassIndexingJob.java Log Message: ----------- HSEARCH-4073 Sonar: Unused "private" fields should be removed Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 093127f027cefcdbdd8879e23c1ccfac9f0dd723 https://github.com/hibernate/hibernate-search/commit/093127f027cefcdbdd88... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/impl/EntityWriter.java Log Message: ----------- HSEARCH-4073 Unnecessary @SuppressWarnings Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Compare: https://github.com/hibernate/hibernate-search/compare/d1f93c7eb97e...0931...