[hibernate-commits] [hibernate/hibernate-search] b0a536: HSEARCH-3398 Move object loading to SPI in a dedic...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: b0a536dd419778cc0465e4a3b1272d1f3a51c7ab https://github.com/hibernate/hibernate-search/commit/b0a536dd419778cc0465... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexSearchTarget.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexSearchTarget.java M engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexSearchTarget.java R engine/src/main/java/org/hibernate/search/engine/search/IdentityObjectLoader.java R engine/src/main/java/org/hibernate/search/engine/search/ObjectLoader.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/query/spi/SearchQueryResultDefinitionContextImpl.java A engine/src/main/java/org/hibernate/search/engine/search/loading/spi/IdentityObjectLoader.java A engine/src/main/java/org/hibernate/search/engine/search/loading/spi/ObjectLoader.java M engine/src/main/java/org/hibernate/search/engine/search/query/impl/ObjectHitAggregator.java M engine/src/main/java/org/hibernate/search/engine/search/query/impl/ProjectionHitAggregator.java M engine/src/main/java/org/hibernate/search/engine/search/query/spi/LoadingHitCollector.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchResultLoadingOrTransformingIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/StubObjectLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextQueryImpl.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/ByTypeObjectLoader.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/ComposableObjectLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchQueryResultDefinitionContextImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchTargetImpl.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/MutableObjectLoadingOptions.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/ObjectLoaderBuilder.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/SingleTypeByIdObjectLoader.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/ByTypeObjectLoader.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/ComposableObjectLoader.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/MutableObjectLoadingOptions.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/ObjectLoaderBuilder.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/SingleTypeByIdObjectLoader.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchTargetDelegateImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoSearchTargetDelegate.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexSearchTarget.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingSearchTarget.java Log Message: ----------- HSEARCH-3398 Move object loading to SPI in a dedicated package There was no point exposing ObjectLoader in APIs. Commit: 3cc17e764c4dcb8566227096b7c2b7f137608cf3 https://github.com/hibernate/hibernate-search/commit/3cc17e764c4dcb856622... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: R engine/src/main/java/org/hibernate/search/engine/common/SearchManager.java R engine/src/main/java/org/hibernate/search/engine/common/SearchManagerBuilder.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/SearchProjectionFactoryContext.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/spi/DifferentSessionFactoriesIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AbstractFieldContainerValueExtractorIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/DocumentIdDefaultBridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldDefaultBridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FullTextFieldIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/KeywordFieldIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/model/GenericPropertyIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/model/PropertyInheritanceIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/routing/AnnotationMappingRoutingIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/routing/ProgrammaticMappingRoutingIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/AnnotationMappingSmokeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/ProgrammaticMappingSmokeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/spatial/AnnotationMappingGeoPointBridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/spatial/ProgrammaticMappingGeoPointBridgeIT.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/JavaBeanMapping.java R mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/JavaBeanSearchManagerBuilder.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanMappingImpl.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanSearchManagerImpl.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/JavaBeanSearchTarget.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/impl/JavaBeanSearchTargetImpl.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/session/JavaBeanSearchManager.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/session/JavaBeanSearchManagerBuilder.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/hibernate/HibernateOrmSearchTarget.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextSearchTargetImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextSessionImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/HibernateSearchContextService.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/jpa/HibernateOrmSearchTarget.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/HibernateOrmMapping.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/HibernateOrmSearchManager.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/HibernateOrmSearchManagerBuilder.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmSearchManagerImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/HibernateOrmSearchTarget.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchTargetImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/HibernateOrmSearchManager.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/HibernateOrmSearchManagerBuilder.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/PojoMapping.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/PojoSearchManager.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/PojoSearchManagerBuilder.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/PojoSearchTarget.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchTargetDelegateImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingDelegate.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingFactory.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingImplementor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingInitiatorImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoSearchManagerImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoSearchTargetDelegate.java Log Message: ----------- HSEARCH-3398 Make the mapping, manager and search target interfaces specific to each POJO mapper Commit: 9da992c3c73199755890f2de2e1d8f11f5177514 https://github.com/hibernate/hibernate-search/commit/9da992c3c73199755890... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanMappingImpl.java R mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanSearchManagerImpl.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/impl/JavaBeanSearchTargetImpl.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/session/impl/JavaBeanSearchManagerImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingImpl.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmSearchManagerImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchQueryResultDefinitionContextImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchTargetImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchManagerImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoMappingDelegateImpl.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchManagerDelegateImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchTargetDelegateImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingDelegate.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoSearchManagerImpl.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoSearchTargetDelegate.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/search/spi/PojoSearchTargetDelegate.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/session/spi/PojoSearchManagerDelegate.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/session/spi/PojoSearchManagerImpl.java Log Message: ----------- HSEARCH-3398 Simplify the delegation mechanism in POJO mappers Commit: c476fc415b721c39fcd46c4a8248ebbbd92f2607 https://github.com/hibernate/hibernate-search/commit/c476fc415b721c39fcd4... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/HibernateOrmMappingDefinitionContainerContext.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/PojoMappingDefinitionContainerContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingInitiatorImpl.java Log Message: ----------- HSEARCH-3398 Remove interface PojoMappingDefinitionContainerContext This interface was API, but was only ever exposed indirectly and was dead simple. Better define specific APIs wherever we need them. Commit: fb3ff0da107e017d71a9d0679f3d89f4e016edd7 https://github.com/hibernate/hibernate-search/commit/fb3ff0da107e017d71a9... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/spi/DifferentSessionFactoriesIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/event/impl/InitializingHibernateSearchState.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextSearchTargetImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextSessionImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/HibernateSearchContextService.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/HibernateOrmMapping.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingFactory.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingKey.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/spi/HibernateOrmMapping.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/HibernateOrmSearchTarget.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchTargetImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/spi/HibernateOrmSearchTarget.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/HibernateOrmSearchManager.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/HibernateOrmSearchManagerBuilder.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchManagerImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/spi/HibernateOrmSearchManager.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/spi/HibernateOrmSearchManagerBuilder.java Log Message: ----------- HSEARCH-3398 Move mapping/manager/search target of the ORM mapper to SPI Users should not need these types to use the ORM mapper; the actual APIs are the FullTextSession et. al. Commit: ab07d7d5fd6652b7e92e3adfd9b0820980feb631 https://github.com/hibernate/hibernate-search/commit/ab07d7d5fd6652b7e92e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/JavaBeanMappingBuilder.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/session/JavaBeanSearchManager.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/session/impl/JavaBeanSearchManagerImpl.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/work/JavaBeanWorkPlan.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/work/impl/JavaBeanWorkPlanImpl.java Log Message: ----------- HSEARCH-3398 Move PojoWorkPlan to SPI That's one more interface from the POJO module that will not leak into mapper APIs. Commit: adc2a085020809599a7eff654634051109980421 https://github.com/hibernate/hibernate-search/commit/adc2a085020809599a7e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexManagerImpl.java R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexSearchTarget.java R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexSearchTargetBuilder.java A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexSearchTargetContextBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchTargetContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImpl.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexSearchTarget.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexSearchTargetBuilder.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexSearchTargetContextBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchTargetContext.java M engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexManagerImplementor.java R engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexSearchTarget.java R engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexSearchTargetBase.java R engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexSearchTargetBuilder.java A engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexSearchTargetContextBuilder.java M engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexManagerImpl.java A engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexSearchTargetBuilderImpl.java A engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexSearchTargetImpl.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappedIndexManager.java A engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappedIndexSearchTarget.java A engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappedIndexSearchTargetBuilder.java A engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryResultDefinitionContextImpl.java R engine/src/main/java/org/hibernate/search/engine/search/dsl/query/spi/SearchQueryResultDefinitionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/sort/impl/RootSearchSortDslContextImpl.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/search/LuceneSearchMultiIndexIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchMultiIndexIT.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchTargetDelegateImpl.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexManager.java R util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexSearchTarget.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexSearchTargetContext.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingSearchTarget.java Log Message: ----------- HSEARCH-3398 Move the implementation of IndexSearchTarget to the engine ... and only expect backends to implement SearchTargetContext. This makes things easier in the next commits when we make the search query result definition APIs specific to each mapper. Besides, this looks like a good idea in any case, since it makes the backend code simpler and allows us to remove SPIs because they are no longer relevant. Commit: 25af7843049f2433b3bddc6dbe6257a86e1f3298 https://github.com/hibernate/hibernate-search/commit/25af7843049f2433b3bd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/search/LuceneSearchMultiIndexIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchMultiIndexIT.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingIndexManager.java Log Message: ----------- HSEARCH-3398 Use the search target wrapper of the Stub mapper in backend tests even for multi-index tests We're going to change these SPIs, so we will have to change these tests anyway; this only makes sure that as we change the tests, we also make them more resilient to future SPI changes. Commit: f6695b6e94d1492ba0b96a6f7c34e54bfc72d19e https://github.com/hibernate/hibernate-search/commit/f6695b6e94d1492ba0b9... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexSearchTargetBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexSearchTargetImpl.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappedIndexSearchTarget.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/SearchProjectionFactoryContext.java R engine/src/main/java/org/hibernate/search/engine/search/dsl/query/SearchQueryResultDefinitionContext.java R engine/src/main/java/org/hibernate/search/engine/search/dsl/query/SearchQueryWrappingDefinitionResultContext.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryPredicateCollector.java A engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryResultContextImpl.java R engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryResultDefinitionContextImpl.java R engine/src/main/java/org/hibernate/search/engine/search/dsl/query/impl/SearchQueryWrappingDefinitionResultContextImpl.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchQueryIT.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/JavaBeanSearchTarget.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/dsl/query/JavaBeanQueryResultDefinitionContext.java A mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/dsl/query/impl/JavaBeanQueryResultDefinitionContextImpl.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/impl/JavaBeanSearchTargetImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/hibernate/FullTextQueryResultDefinitionContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/hibernate/FullTextSearchTarget.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/hibernate/HibernateOrmSearchQueryResultDefinitionContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextSearchTargetImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/jpa/FullTextQueryResultDefinitionContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/jpa/FullTextSearchTarget.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/jpa/HibernateOrmSearchQueryResultDefinitionContext.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/FullTextQueryResultDefinitionContextImpl.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchQueryResultDefinitionContextImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/HibernateOrmSearchTargetImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/spi/HibernateOrmSearchTarget.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchManagerImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchManagerDelegateImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchTargetDelegateImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/search/spi/PojoSearchTargetDelegate.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/session/spi/PojoSearchManagerDelegate.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingQueryResultDefinitionContext.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingSearchTarget.java Log Message: ----------- HSEARCH-3398 Make query result definition APIs mapper-specific Results will be different depending on the mapper anyway: the ORM mapper returns managed entities, while the JavaBean mapper cannot possibly do that, and a hypothetical JSON mapper would rather return JSON objects. What's more, each mapper will need to provide ways for users to configure this result extraction differently, e.g. Hibernate ORM will need to provide options regarding whether the second level cache should be used. In the end, having a common superinterface for this is probably not a good idea, so let's have mapper-specific APIs. Commit: 0c3368d83acdb845e242349ef50e2832be82fafe https://github.com/hibernate/hibernate-search/commit/0c3368d83acdb845e242... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/SingleTypeByIdObjectLoader.java Log Message: ----------- HSEARCH-3398 Remove a useless method detected by Sonar This method has been unnecessary since ad72715e5eb0209a8b9173b1c70f6d10ff431969 Compare: https://github.com/hibernate/hibernate-search/compare/01e45d06772a...0c33... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.