[hibernate-commits] [hibernate/hibernate-search] 446958: HSEARCH-4876 Test cycle detection with @IndexedEmb...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-search Commit: 446958f7a9ede06eb3f741caf5a97306d5eb8d8e https://github.com/hibernate/hibernate-search/commit/446958f7a9ede06eb3f7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java Log Message: ----------- HSEARCH-4876 Test cycle detection with @IndexedEmbedded.excludePaths Commit: 9bf7824a6f0f5521b8d8452ba9142d916eacaf15 https://github.com/hibernate/hibernate-search/commit/9bf7824a6f0f5521b8d8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/tree/TreeFilterDefinition.java Log Message: ----------- HSEARCH-4876 Fix invalid default for @IndexedEmbedded.includeDepth when setting @IndexedEmbedded.excludePaths Commit: 02257e0876f94cf7c83edec776642fb4fbfc5a50 https://github.com/hibernate/hibernate-search/commit/02257e0876f94cf7c83e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java Log Message: ----------- HSEARCH-4876 Test non-root cycles with excludePaths Commit: 12a2c7ab7b2ff97ba92154c8f0ae2ddf97584566 https://github.com/hibernate/hibernate-search/commit/12a2c7ab7b2ff97ba921... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/TreeFilter.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java Log Message: ----------- HSEARCH-4876 Check if a path is potentially excluded before failing with cycle detection Commit: 01a135dd3b8d52814b9bdc3116d2bc0bd370b7b9 https://github.com/hibernate/hibernate-search/commit/01a135dd3b8d52814b9b... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java Log Message: ----------- HSEARCH-4876 Adding one more (so far failing) test case Commit: 1cb2b795bd45b17d01beb5b35caca279cab30aa0 https://github.com/hibernate/hibernate-search/commit/1cb2b795bd45b17d01be... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/TreeFilter.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java Log Message: ----------- HSEARCH-4876 Change how we check if the cycle can be broken Commit: ee82682e006da633375e44594674f92a9e913023 https://github.com/hibernate/hibernate-search/commit/ee82682e006da633375e... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/PathFilter.java M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/TreeFilter.java Log Message: ----------- HSEARCH-4876 Move isPotentiallyExcluded to PathFilter Commit: 6f20e49a8ea1f71ad13f9ac4ae276edc483b3f37 https://github.com/hibernate/hibernate-search/commit/6f20e49a8ea1f71ad13f... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java A integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedCycleIT.java Log Message: ----------- HSEARCH-4876 Move cycle detection tests to its own class Commit: 6cb86d9a34152dfa83ac5c7319890ef9ec703d2d https://github.com/hibernate/hibernate-search/commit/6cb86d9a34152dfa83ac... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedCycleIT.java Log Message: ----------- HSEARCH-4876 Ignore the test for cycle and prefixes without dots Commit: 402b5a0e3b5d9f806ded4430c3596fcc94a2a4af https://github.com/hibernate/hibernate-search/commit/402b5a0e3b5d9f806ded... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/PathFilter.java M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/TreeFilter.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedCycleIT.java Log Message: ----------- HSEARCH-4876 Simplify the algorithm - simplify the algorithm to only go through filters once - ignore trailing unterminated prefixes - use full-object-names checks in potentially excluded method Co-authored-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 328f21da813f828952b4210f0818d302ff3c6f14 https://github.com/hibernate/hibernate-search/commit/328f21da813f828952b4... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M engine/src/main/java/org/hibernate/search/engine/common/tree/impl/PathFilter.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java Log Message: ----------- HSEARCH-4876 Use exact match when checking exclude paths Commit: 939297fd630d7074d268c53fcd031af9b6720d2a https://github.com/hibernate/hibernate-search/commit/939297fd630d7074d268... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2023-06-21 (Wed, 21 Jun 2023) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedCycleIT.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/IndexedEmbedded.java Log Message: ----------- HSEARCH-4876 Add more tests for prefixes Compare: https://github.com/hibernate/hibernate-search/compare/fc2c9038a638...9392...