[hibernate-commits] [hibernate/hibernate-validator] 3e264e: HV-1165 Support type argument constraints for Set

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-validator Commit: 3e264e3b23a88ced83acdf2e6ba42de913dc0452 https://github.com/hibernate/hibernate-validator/commit/3e264e3b23a88ced8... Author: Guillaume Smet <guillaume.smet(a)gmail.com&gt; Date: 2016-12-07 (Wed, 07 Dec 2016) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java M engine/src/main/java/org/hibernate/validator/internal/metadata/location/TypeArgumentConstraintLocation.java M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java M engine/src/main/java/org/hibernate/validator/internal/util/ReflectionHelper.java M engine/src/test/java/org/hibernate/validator/test/internal/engine/typeannotationconstraint/TypeAnnotationConstraintTest.java M engine/src/test/java/org/hibernate/validator/test/internal/util/ReflectionHelperTest.java Log Message: ----------- HV-1165 Support type argument constraints for Set This is a follow-up of HV-1062: it fixed the Map case but introduced a regression for the Set case. Also unify the tests so that they cover correctly all cases. Also fix a misleading comment which led to this mistake. Note that a few tests for Optional method validation got removed, they will be reintroduced in a follow-up commit. Commit: 2c57a19a1841ad5165e051d4214ad66a48ecaa2c https://github.com/hibernate/hibernate-validator/commit/2c57a19a1841ad516... Author: Guillaume Smet <guillaume.smet(a)gmail.com&gt; Date: 2016-12-07 (Wed, 07 Dec 2016) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/util/CollectionHelper.java M engine/src/main/java/org/hibernate/validator/internal/util/ReflectionHelper.java M engine/src/test/java/org/hibernate/validator/test/internal/util/ReflectionHelperTest.java Log Message: ----------- HV-1175 Fix ReflectionHelper.getIndexedValue for arrays The previous code was not working at all because it constructed an iterator over a list containing the array of elements instead of the elements. Note that it might sound overly complicated but dealing with arrays of primitives makes it necessary. Commit: 4e2dbc08234730da47612bb16b3432dbbaaacfd1 https://github.com/hibernate/hibernate-validator/commit/4e2dbc08234730da4... Author: Guillaume Smet <guillaume.smet(a)gmail.com&gt; Date: 2016-12-07 (Wed, 07 Dec 2016) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java M engine/src/test/java/org/hibernate/validator/test/internal/engine/typeannotationconstraint/TypeAnnotationConstraintTest.java Log Message: ----------- HV-1175 Support type arguments on array and array of primitives Commit: 41e814781daa9b82bfaa426374d3db9d8b9bd374 https://github.com/hibernate/hibernate-validator/commit/41e814781daa9b82b... Author: Guillaume Smet <guillaume.smet(a)gmail.com&gt; Date: 2016-12-07 (Wed, 07 Dec 2016) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedExecutable.java M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedField.java M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedParameter.java M engine/src/test/java/org/hibernate/validator/test/internal/engine/typeannotationconstraint/TypeAnnotationConstraintTest.java Log Message: ----------- HV-1176 Fix type argument constraints detection. They could be ignored if they were the only constraints of a method's parameters or return value. This issue was detected by separating the tests of List and Optional: the presence of an @Valid annotation for the List made the test work. Compare: https://github.com/hibernate/hibernate-validator/compare/0daf6da46ce0...4...