[hibernate-commits] [hibernate/hibernate-search] fafeaa: HSEARCH-3056 Pass an object representing the conte...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: fafeaa2f76c5ac75150a34ad519f2e6819cd2ac7 https://github.com/hibernate/hibernate-search/commit/fafeaa2f76c5ac75150a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/NoOpPojoImplicitReindexingResolverNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolver.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverCastedTypeNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverContainerElementNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverDirtinessFilterNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverMarkingNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverMultiNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverOriginalTypeNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverPropertyNode.java A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverRootContext.java A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/spi/PojoImplicitReindexingResolverSessionContext.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoContainedTypeManager.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/AbstractPojoTypeIndexingPlan.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoWorkTypeContext.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/spi/PojoWorkSessionContext.java Log Message: ----------- HSEARCH-3056 Pass an object representing the context to PojoImplicitReindexingResolver This will be necessary in the next commit. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 6ce452d1e46cc85dadbbb33bf906d833e6beb103 https://github.com/hibernate/hibernate-search/commit/6ce452d1e46cc85dadbb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/lifecycle/CleanupIT.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldContainerExtractorBaseIT.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/testsupport/util/StartupStubContainerExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverContainerElementNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/ContainerExtractor.java A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/ValueProcessor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/BooleanArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/ByteArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/CharArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/CollectionElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/DoubleArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/FloatArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/IntArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/IterableElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/LongArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/MapKeyExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/MapValueExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/ObjectArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalDoubleValueExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalIntValueExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalLongValueExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/OptionalValueExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/impl/ShortArrayElementExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ChainingContainerExtractor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorContainerElementNode.java Log Message: ----------- HSEARCH-3056 Avoid instantiating lambdas when calling a ContainerExtractor With this change, we'll avoid once instantiation per container encountered while processing entities to index. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 90df91ce918437ebccabc29573d864394dce1f6d https://github.com/hibernate/hibernate-search/commit/90df91ce918437ebccab... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/automaticindexing/impl/PojoImplicitReindexingResolverContainerElementNode.java R mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ChainingContainerExtractor.java A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ChainingContainerExtractorHolder.java A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractingProcessor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractorBinder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractorHolder.java A mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/SingleContainerExtractorHolder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorContainerElementNodeBuilder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorContainerElementNode.java Log Message: ----------- HSEARCH-3056 Avoid instantiating lambdas when calling chained ContainerExtractors Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: b7abead38dc82285da6f6a2e9867901ac804422c https://github.com/hibernate/hibernate-search/commit/b7abead38dc82285da6f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/BoundPropertyBridge.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/BoundRoutingBridge.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/BoundTypeBridge.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/BoundValueBridge.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/DefaultIdentifierBindingContext.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/PropertyBindingContextImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/TypeBindingContextImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/ValueBindingContextImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/impl/BeanBinder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/PropertyIdentifierMapping.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/ProvidedIdentifierMapping.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoRootIdentityMappingCollector.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/AbstractPojoIndexingProcessorTypeNodeBuilder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorValueNodeBuilderDelegate.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyBridgeNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeBridgeNode.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorValueBridgeNode.java M util/common/src/main/java/org/hibernate/search/util/common/impl/AbstractCloser.java M util/common/src/main/java/org/hibernate/search/util/common/impl/SuppressingCloser.java M util/common/src/test/java/org/hibernate/search/util/common/impl/CloserTest.java M util/common/src/test/java/org/hibernate/search/util/common/impl/SuppressingCloserTest.java Log Message: ----------- HSEARCH-3056 Avoid instantiating lambdas when using closers Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: de8c891c89131fc57dc65f449e83110e32db72b7 https://github.com/hibernate/hibernate-search/commit/de8c891c89131fc57dc6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationPojoTypeMetadataContributorFactory.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/impl/AbstractPojoModelCompositeElement.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/spi/AbstractPojoRawTypeModel.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/spi/PojoRawTypeModel.java Log Message: ----------- HSEARCH-3056 Remove an unnecessary stream in PojoRawTypeModel Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: dbca1e6ba8af3e74397fc702498f0aed0796e702 https://github.com/hibernate/hibernate-search/commit/dbca1e6ba8af3e74397f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/impl/JobContextData.java M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/impl/ProgressAggregator.java M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/util/impl/JobContextUtil.java M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/util/impl/ValidationUtil.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmBasicTypeMetadataProvider.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/ValueBindingContextImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/impl/BeanBinder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataProvider.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorValueNodeBuilderDelegate.java Log Message: ----------- HSEARCH-3056 Avoid functional code where an imperative approach is just as clear Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 3f71a713ec60f0474244eb390c1fcab49eb6772f https://github.com/hibernate/hibernate-search/commit/3f71a713ec60f0474244... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/mapping/definition/AnnotationMappingDiscoveryIT.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AnnotationMappingDiscoveryIT.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/alternative/impl/AlternativeBinderImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/impl/GeoPointBridge.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/PojoModelCompositeElement.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/PojoModelProperty.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoPropertyAdditionalMetadataBuilder.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/impl/PojoPropertyAdditionalMetadata.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/impl/AbstractPojoModelCompositeElement.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelNestedCompositeElement.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelPropertyRootElement.java M v5migrationhelper/engine/src/main/java/org/hibernate/search/bridge/builtin/impl/CoordinatesBridge.java Log Message: ----------- HSEARCH-3056 Expose Collection rather than Stream in metamodel APIs So that users aren't forced to use lambdas unnecessarily. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: d1f93c7eb97ec39786e5a69b1251c58ea3cc6036 https://github.com/hibernate/hibernate-search/commit/d1f93c7eb97ec39786e5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-11-02 (Mon, 02 Nov 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/schema/management/impl/LuceneIndexSchemaManager.java M mapper/orm-batch-jsr352/core/src/main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/lucene/impl/StepProgressSetupListener.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/alternative/impl/AlternativeBinderImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/impl/GeoPointBridge.java M v5migrationhelper/engine/src/main/java/org/hibernate/search/bridge/builtin/impl/CoordinatesBridge.java Log Message: ----------- HSEARCH-3056 Avoid using lambdas where a method reference or factory method is just as clear Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Compare: https://github.com/hibernate/hibernate-search/compare/528fbf73235a...d1f9...