[hibernate-commits] [hibernate/hibernate-orm] 4b7fcb: HHH-15681 use enum instead of boolean of lock scopes

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 4b7fcb5123de610d7ac23465e19674c11daddfb4 https://github.com/hibernate/hibernate-orm/commit/4b7fcb5123de610d7ac2346... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2022-11-08 (Tue, 08 Nov 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/LockMode.java M hibernate-core/src/main/java/org/hibernate/LockOptions.java M hibernate-core/src/main/java/org/hibernate/Session.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/OptimisticForceIncrementLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/OptimisticLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/PessimisticForceIncrementLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/PessimisticReadSelectLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/PessimisticReadUpdateLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/PessimisticWriteSelectLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/PessimisticWriteUpdateLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/SelectLockingStrategy.java M hibernate-core/src/main/java/org/hibernate/dialect/lock/UpdateLockingStrategy.java Log Message: ----------- HHH-15681 use enum instead of boolean of lock scopes also a bunch of Javadoc improvement for LockOptions and friends Commit: 61294250b3e1cd531ee5ebf2fb0618ebb8ec5821 https://github.com/hibernate/hibernate-orm/commit/61294250b3e1cd531ee5ebf... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2022-11-08 (Tue, 08 Nov 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/LockOptions.java M hibernate-core/src/main/java/org/hibernate/Session.java M hibernate-core/src/main/java/org/hibernate/engine/spi/SessionDelegatorBaseImpl.java M hibernate-core/src/main/java/org/hibernate/engine/spi/SessionLazyDelegator.java M hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java Log Message: ----------- HHH-15680 deprecate LockRequest and add overloads of lock() which accept LockOptions Commit: 58ba65f529003c5f83e8dddbd915f3e45ac0bffd https://github.com/hibernate/hibernate-orm/commit/58ba65f529003c5f83e8ddd... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2022-11-08 (Tue, 08 Nov 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/LockOptions.java M hibernate-core/src/main/java/org/hibernate/query/spi/QueryOptionsAdapter.java M hibernate-core/src/main/java/org/hibernate/sql/exec/internal/JdbcSelectExecutorStandardImpl.java Log Message: ----------- HHH-15682 add ImmutableLockOptions here we had an amazing idiom: static final instances of a mutable value class Commit: 02ad34091c477a90271928a96d5b772debe2e4f4 https://github.com/hibernate/hibernate-orm/commit/02ad34091c477a90271928a... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2022-11-08 (Tue, 08 Nov 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/LockOptions.java M hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureCallImpl.java M hibernate-core/src/main/java/org/hibernate/query/NativeQuery.java M hibernate-core/src/main/java/org/hibernate/query/Query.java M hibernate-core/src/main/java/org/hibernate/query/SelectionQuery.java M hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQuery.java M hibernate-core/src/main/java/org/hibernate/query/spi/AbstractSelectionQuery.java M hibernate-core/src/main/java/org/hibernate/query/sql/internal/NativeQueryImpl.java M hibernate-core/src/main/java/org/hibernate/query/sql/spi/NativeQueryImplementor.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmSelectionQueryImpl.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/lock/QueryLockingTest.java Log Message: ----------- HHH-15683+HHH-15684 clean up the handling of LockOptions for queries This contains a change to LockOptions.overlay() which is breaking in principle, but more natural and less fragile. It also deprecates SelectionQuery.setAliasSpecificLockMode() which I believe was added in 6.0 by mistake. The method is an overload of setLockMode() in the rest of the hierarchy. Commit: 9d141a27936a1ac2aab66e72d4cdd2c1fb5f440f https://github.com/hibernate/hibernate-orm/commit/9d141a27936a1ac2aab66e7... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2022-11-08 (Tue, 08 Nov 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/LockMode.java M hibernate-core/src/main/java/org/hibernate/LockOptions.java M hibernate-core/src/main/java/org/hibernate/Session.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java M hibernate-core/src/main/java/org/hibernate/event/spi/RefreshEvent.java M hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java Log Message: ----------- improve javadoc for LockModes, and deprecate LockOptions.SKIP_LOCKED Use LockMode.UPGRADE_SKIPLOCKED instead of setting the timeout to -2. Compare: https://github.com/hibernate/hibernate-orm/compare/a5fa3739e22a...9d141a2...