[hibernate-commits] [hibernate/hibernate-search] d3b6c0: HSEARCH-2529 Avoid NPE when logging errors on Luce...

Branch: refs/heads/5.7 Home: https://github.com/hibernate/hibernate-search Commit: d3b6c023831a884d667b7dc49955bbca28b82e72 https://github.com/hibernate/hibernate-search/commit/d3b6c023831a884d667b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/exception/impl/LogErrorHandler.java M orm/src/test/java/org/hibernate/search/test/errorhandling/LuceneErrorHandlingTest.java Log Message: ----------- HSEARCH-2529 Avoid NPE when logging errors on Lucene works with no related entity Commit: 02d223c8f87fd56681fcdfc0fb48ffdbc166c41f https://github.com/hibernate/hibernate-search/commit/02d223c8f87fd56681fc... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M orm/src/test/java/org/hibernate/search/test/configuration/BlogEntry.java M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticSearchMappingFactory.java M orm/src/test/java/org/hibernate/search/test/query/facet/Car.java Log Message: ----------- Remove obsolete comments Analyzer definitions are no longer duplcated in the elasticsearch.yml (since eac1a182a25fe373ef9490cbb8f9480ab2d19869). Commit: 0e9a3868ce7eb94eaef9d65ac921b0fc16153751 https://github.com/hibernate/hibernate-search/commit/0e9a3868ce7eb94eaef9... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java Log Message: ----------- HSEARCH-2535 Make it clearer that the 'multiValued' parameter actually means 'the property holder might have multiple values' Commit: 37c1a342c5bb345d96f21043aa7d13d185d36521 https://github.com/hibernate/hibernate-search/commit/37c1a342c5bb345d96f2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java Log Message: ----------- HSEARCH-2535 Support faceting on container properties (arrays, iterables, maps) Commit: e90425b2352de4c6ed548aa56e15f439948590b5 https://github.com/hibernate/hibernate-search/commit/e90425b2352de4c6ed54... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: R orm/src/test/java/org/hibernate/search/test/query/facet/CollectionFacetingTest.java A orm/src/test/java/org/hibernate/search/test/query/facet/EmbeddedCollectionFacetingTest.java Log Message: ----------- HSEARCH-2535 Rename CollectionFacetingTest to avoid confusions This test is not related to the facetting of Collection properties, but to the facetting inside an embedded collection. Commit: 27d391ee8e4006a80a3af3c30719c107375d765e https://github.com/hibernate/hibernate-search/commit/27d391ee8e4006a80a3a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: A orm/src/test/java/org/hibernate/search/test/query/facet/MultiValuedFacetingTest.java Log Message: ----------- HSEARCH-2535 Test faceting on container properties (arrays, iterables, maps) Some tests are disabled because they do not pass due to HSEARCH-1927. Commit: 252c53037090e611eb1df74df3ec297e1e808992 https://github.com/hibernate/hibernate-search/commit/252c53037090e611eb1d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/util/impl/CollectionHelper.java Log Message: ----------- HSEARCH-2510 Copy CollectionHelper.iteratorFromArray from Hibernate Validator Commit: c5c5fd0b96559684b4ddf0b9cbf336b14d5169fb https://github.com/hibernate/hibernate-search/commit/c5c5fd0b96559684b4dd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/util/impl/CollectionHelper.java Log Message: ----------- HSEARCH-2510 Introduce CollectionHelper.iterableFromArray Commit: 0049cce1f0e0f6588e4f65bfa8f941267839a22e https://github.com/hibernate/hibernate-search/commit/0049cce1f0e0f6588e4f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/util/impl/CollectionHelper.java Log Message: ----------- HSEARCH-2510 Avoid the extra iterable instantiation in CollectionHelper.iteratorFromArray Because there will be someone who's not happy with that extra instantiation, I'm sure. Calls to array accessors seem to be inlined, so there shouldn't be much execution overhead. Commit: 7c1e5321baf4322da71ca747d75c771b9103e412 https://github.com/hibernate/hibernate-search/commit/7c1e5321baf4322da71c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/bridge/builtin/ArrayBridge.java M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java M orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeTest.java M orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeTestEntity.java M orm/src/test/java/org/hibernate/search/test/query/facet/MultiValuedFacetingTest.java Log Message: ----------- HSEARCH-2510 Support indexing arrays of primitive types Commit: 40f766e1e8e01ed5a4051df6285c72a5b3d69282 https://github.com/hibernate/hibernate-search/commit/40f766e1e8e01ed5a405... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/impl/WorkPlan.java Log Message: ----------- HSEARCH-2540 Fix a misleading piece of code Commit: 47e4eabe0cf4640be042ce652494b95fb1a879b7 https://github.com/hibernate/hibernate-search/commit/47e4eabe0cf4640be042... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M orm/src/test/java/org/hibernate/search/test/query/dsl/NumericEncodingQueriesTest.java Log Message: ----------- HSEARCH-2501 Always initialize calendars in NumericEncodingQueriesTest with the same value We used to keep the hour, minutes, etc. from the current date/time. Commit: 7089a97e112c3b2208968eb8bbfd12a848de5881 https://github.com/hibernate/hibernate-search/commit/7089a97e112c3b220896... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/ElasticsearchDateHelper.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexMappingIT.java Log Message: ----------- HSEARCH-2501 Align the behavior of automatic calendar resolution adjustment with Elasticsearch on Lucene's behavior We truncate the date with the GMT timezone, even if the calendar has a different timezone. Commit: 265bd0b4086a7f3e67172a50699c93dbc445c916 https://github.com/hibernate/hibernate-search/commit/265bd0b4086a7f3e6717... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M orm/src/test/java/org/hibernate/search/test/bridge/BridgeTest.java Log Message: ----------- HSEARCH-2501 Test issues with timezones when testing calendar/date index-time rounding The Elasticsearch integration fails testCalendarBridge when using non-GMT timezones. This is fixed with HSEARCH-2501. Commit: 06c6a08e18f143cf5716a216933594a3f299ba0e https://github.com/hibernate/hibernate-search/commit/06c6a08e18f143cf5716... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java Log Message: ----------- HSEARCH-2545 When processing "contained in" metadata, don't check every @NumericField annotation matches an actual field We may not inspect every @NumericField annotation in this case, because field bridges are not built and thus we don't care whether fields are numeric or not. The validation will always be performed when processing the indexed entity metadata, anyway, so we will warn users eventually. Commit: 4395924f819e47818e5d996e4da608b5f2b04776 https://github.com/hibernate/hibernate-search/commit/4395924f819e47818e5d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: A orm/src/test/java/org/hibernate/search/test/engine/NumericDocumentIdIndexedEmbeddedTest.java Log Message: ----------- HSEARCH-2545 Test for numeric document IDs embedded through an @IndexedEmbedded Commit: 4380fb0dddb256dc65aca616d857546ea2a0144b https://github.com/hibernate/hibernate-search/commit/4380fb0dddb256dc65ac... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/impl/DefaultMutableEntityIndexBinding.java M engine/src/main/java/org/hibernate/search/engine/impl/DynamicShardingEntityIndexBinding.java M engine/src/main/java/org/hibernate/search/engine/impl/EntityIndexBindingFactory.java M engine/src/main/java/org/hibernate/search/engine/spi/EntityIndexBinding.java M engine/src/main/java/org/hibernate/search/indexes/impl/IndexManagerHolder.java Log Message: ----------- HSEARCH-2522 Make it possible to retrieve the IndexManagerType from EntityIndexBinding This helps when we need the IndexManagerType and we're not sure that there already is an IndexManager, or we don't want to retrieve index managers (because of dynamic sharding, they may be lazily initialized). Commit: 49daf5d0e8c9b06dcfb2dd88f91fc55f0277fc76 https://github.com/hibernate/hibernate-search/commit/49daf5d0e8c9b06dcfb2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/ElasticsearchEntityHelper.java Log Message: ----------- HSEARCH-2522 Use EntityIndexBinding#getIndexManagerType in ElasticsearchEntityHelper This avoids to trigger an early initialization of index managers in the case of dynamic sharding. Commit: 1b76b417f415b9f52f40e6d91ef9017e7c76c412 https://github.com/hibernate/hibernate-search/commit/1b76b417f415b9f52f40... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java Log Message: ----------- HSEARCH-2531 Make configuration-based index name override work with ElasticsearchIndexManager We used to apply this override on the attribute returned by getIndexName(), which is really not a good idea: Hibernate Search works in such a way that it expects the index name returned by getIndexName() to be the exact same that was passed to the initialize() method. Because we did change the returned getIndexName(), we couldn't retrieve the index manager anymore when indexing and indexing failed consistently. Possible solutions were: * to align ElasticsearchIndexManager's behavior on that of DirectoryBasedIndexManager, making getIndexName() return the exact string that was passed to the initialize() method. * to make the index name passed to the initialize() method already account for the override. But that would be a breaking change to existing IndexManager implementations. * to make Hibernate Search ask newly created index managers for their actual name after initializing them (by calling getActualName is available or getIndexName otherwise). But that would be a breaking change to clients of SearchIntegrator.getIndexManager. I chose the first solution, which is more hackish, but safer in the current context of a candidate release. Commit: 5c5696854ea49b036301c14c53bd61d981a3db1d https://github.com/hibernate/hibernate-search/commit/5c5696854ea49b036301... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: A engine/src/test/java/org/hibernate/search/test/configuration/IndexNameOverrideTest.java Log Message: ----------- HSEARCH-2531 Test the behavior of index managers regarding index name overrides Commit: 3411e1b5817530ce5e49b9a735d7803ebf1057a7 https://github.com/hibernate/hibernate-search/commit/3411e1b5817530ce5e49... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java Log Message: ----------- HSEARCH-2547 Consider nested @IndexedEmbeddeds as included even when upper-level @IndexedEmbedded with empty includePaths exist Commit: c8fde18f40127cb851f420f969654c580a8f8ea0 https://github.com/hibernate/hibernate-search/commit/c8fde18f40127cb851f4... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: A orm/src/test/java/org/hibernate/search/test/embedded/path/DefaultPathsWithNestedIndexedEmbeddedTest.java Log Message: ----------- HSEARCH-2547 Test the behavior when an @IndexedEmbedded with includePaths is embedded within another @IndexedEmbedded without includePaths Commit: 6281a4baf4eb1f9dfdbdf745017ee046984c4865 https://github.com/hibernate/hibernate-search/commit/6281a4baf4eb1f9dfdbd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: R engine/src/main/java/org/hibernate/search/indexes/spi/AnalyzerDefinitions.java Log Message: ----------- HSEARCH-2527 Removed the unused type AnalyzerDefinitions Commit: 5147cfbbbcb0596d25179833dd0ebc5633ea885e https://github.com/hibernate/hibernate-search/commit/5147cfbbbcb0596d2517... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ElasticsearchAnalyzerReference.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ElasticsearchAnalyzerStrategy.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/NamedElasticsearchAnalyzerReference.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ScopedElasticsearchAnalyzer.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ScopedElasticsearchAnalyzerReference.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/SimpleElasticsearchAnalyzerReference.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/model/IndexSettings.java M engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneEmbeddedAnalyzerStrategy.java A engine/src/main/java/org/hibernate/search/analyzer/impl/NamedLuceneAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/ScopedLuceneAnalyzer.java M engine/src/main/java/org/hibernate/search/analyzer/impl/ScopedLuceneAnalyzerReference.java A engine/src/main/java/org/hibernate/search/analyzer/impl/SimpleLuceneAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/spi/AnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/spi/AnalyzerStrategy.java A engine/src/main/java/org/hibernate/search/analyzer/spi/NamedAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/spi/ScopedAnalyzer.java M engine/src/main/java/org/hibernate/search/analyzer/spi/ScopedAnalyzerReference.java M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/AddWorkExecutor.java M engine/src/main/java/org/hibernate/search/engine/impl/AnalyzerReferenceRegistry.java M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java M engine/src/main/java/org/hibernate/search/query/dsl/impl/ConnectedQueryContextBuilder.java Log Message: ----------- HSEARCH-2527 Remove mix-ups between analyzers and analyzer references 1. Move the scoped analyzer builder from the analyzers to the references. That way, we can have lazy initialization on scoped analyzer references, which in turn allows us to avoid having analyzer references inside scoped analyzer. 2. Make it more clear that only *some* analyzer references have a name by introducing the NamedAnalyzerReference interface. Hopefully this will make it clearer that the analyzer reference name is not the same as the analyzer name: * when an analyzer reference has a name, its analyzer will consistency return that same name with getName(String) * *but* when the analyzer reference does not provide a name, it simply means that the analyzer name can only be queried at runtime (e.g. for scoped analyzers). Commit: b7bb70fbe58fbdd095261c1fd5fdab02ddcf61e6 https://github.com/hibernate/hibernate-search/commit/b7bb70fbe58fbdd09526... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ElasticsearchAnalyzerReference.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/NamedElasticsearchAnalyzerReference.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ScopedElasticsearchAnalyzerReference.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/SimpleElasticsearchAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/NamedLuceneAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/RemoteAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/SimpleLuceneAnalyzerReference.java Log Message: ----------- HSEARCH-2527 Make is/unwrap safer for subclasses of analyzer references The former implementation was prone to bugs when new subclasses were added and `is` wasn't overridden. Commit: 1c8ed6665c9c58d2d6112ca3decd41c9794f1095 https://github.com/hibernate/hibernate-search/commit/1c8ed6665c9c58d2d611... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/analyzer/spi/AnalyzerStrategy.java Log Message: ----------- HSEARCH-2527 Remove an obsolete comment in AnalyzerStrategy's javadoc Commit: 271f0b6a3d625b7af4b09f42a181d927d43227ff https://github.com/hibernate/hibernate-search/commit/271f0b6a3d625b7af4b0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ElasticsearchAnalyzerStrategy.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/spi/ElasticsearchIndexManagerType.java M engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneEmbeddedAnalyzerStrategy.java M engine/src/main/java/org/hibernate/search/analyzer/spi/AnalyzerStrategy.java M engine/src/main/java/org/hibernate/search/engine/impl/AnalyzerReferenceRegistry.java M engine/src/main/java/org/hibernate/search/engine/impl/AnnotationProcessingHelper.java M engine/src/main/java/org/hibernate/search/engine/impl/ConfigContext.java M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java M engine/src/main/java/org/hibernate/search/indexes/spi/IndexManagerType.java M engine/src/main/java/org/hibernate/search/indexes/spi/LuceneEmbeddedIndexManagerType.java Log Message: ----------- HSEARCH-2527 Make it possible for analyzer strategies to initialize *all* their references ... and not only the named ones. Commit: 078c1275090dfe691bc0acf3929ae2d59e9ecaa5 https://github.com/hibernate/hibernate-search/commit/078c1275090dfe691bc0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ElasticsearchAnalyzerStrategy.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ScopedElasticsearchAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneEmbeddedAnalyzerStrategy.java M engine/src/main/java/org/hibernate/search/analyzer/impl/ScopedLuceneAnalyzerReference.java Log Message: ----------- HSEARCH-2527 Remove the need for synchronization in Scoped*AnalyzerReference.getAnalyzer() We make sure the reference is either initialized at the end of the search factory initialization (for references created during bootstraping) or immediately when it's built (for references created at runtime, when copying). Commit: ded9943bb291f29ff4ee28c5aaba13ed1e3bd11e https://github.com/hibernate/hibernate-search/commit/ded9943bb291f29ff4ee... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ScopedElasticsearchAnalyzer.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/impl/ScopedElasticsearchAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/impl/ScopedLuceneAnalyzer.java M engine/src/main/java/org/hibernate/search/analyzer/impl/ScopedLuceneAnalyzerReference.java M engine/src/main/java/org/hibernate/search/analyzer/spi/ScopedAnalyzerReference.java M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/AddWorkExecutor.java M engine/src/main/java/org/hibernate/search/query/dsl/impl/ConnectedQueryContextBuilder.java Log Message: ----------- HSEARCH-2527 Make Scoped*AnalyzerReferences drop the reference to their builder ASAP This allows to have one less map in memory at runtime for each scoped analyzer reference. Maybe not worth it, but at least it's cleaner... To achieve that, we have to build copied scoped analyzer without the original map of analyzer references by scope, which means the copy builder becomes quite different from the initial builder, and that we must retrieve the global analyzer and analyzers by scope from the scoped analyzer. Commit: fd9edd12207b7167003031fede80a7a164156f4f https://github.com/hibernate/hibernate-search/commit/fd9edd12207b71670030... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaCreator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaDropper.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaMigrator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java Log Message: ----------- HSEARCH-2519 Add missing parameters in the javadoc of elasticsearch schema helpers Commit: 5ae559cae57b3f65a0ecd74a09c505cb2e4925b3 https://github.com/hibernate/hibernate-search/commit/5ae559cae57b3f65a0ec... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/IndexSchemaManagementStrategy.java Log Message: ----------- HSEARCH-2519 Make it clearer in the doc that schema management strategies may affect analyzer definitions. Commit: 9507f8e980f613f3fb7f68abe49180805986ea20 https://github.com/hibernate/hibernate-search/commit/9507f8e980f613f3fb7f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/gson/AbstractExtraPropertiesJsonAdapter.java Log Message: ----------- HSEARCH-2519 Fix AbstractExtraPropertiesJsonAdapter.read (used to return null) Commit: 31d372d1fc50fba7a50169ea40c7f76e570b62db https://github.com/hibernate/hibernate-search/commit/31d372d1fc50fba7a501... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/model/IndexSettings.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/model/TokenFilterDefinition.java Log Message: ----------- HSEARCH-2519 Add some missing toString implementations in ES index metadata types Commit: 00ecfd22a90ac1bbf596eff70f906a3e9c906046 https://github.com/hibernate/hibernate-search/commit/00ecfd22a90ac1bbf596... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/ElasticsearchCharFilterFactory.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/ElasticsearchTokenizerFactory.java Log Message: ----------- HSEARCH-2519 Fix copy/paste errors in the javadoc Commit: 554bddd578869f1163b63fbfda635bdd4ed5e9f9 https://github.com/hibernate/hibernate-search/commit/554bddd578869f1163b6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchValidationMessages.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContext.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationErrorCollector.java Log Message: ----------- HSEARCH-2519 Validate analyzer definitions in ES's VALIDATE schema management strategy Limitations: * definition parameters are compared quite strictly; for instance arrays are always considered ordered, while order actually doesn't matter for some parameters. This could be avoided with a metamodel that would mention the few unordered array parameters. * default values are not handled, i.e. a definition setting a parameter to its default value will be deemed invalid if the expected definition doesn't mention this parameter. This could be avoided, but would require a massive metamodel of all Elasticsearch analysis types. Commit: f30d17301d69b4fe88fb1249227f41b3d6879c68 https://github.com/hibernate/hibernate-search/commit/f30d17301d69b4fe88fb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/TestElasticsearchClient.java Log Message: ----------- HSEARCH-2519 Test ES's VALIDATE schema management strategy with analyzer definitions Commit: bb069a0d5d202f304896e5182d198f876dbdb44b https://github.com/hibernate/hibernate-search/commit/bb069a0d5d202f304896... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/CjkBigramIgnoredScriptsParametersTransformer.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/DefaultElasticsearchAnalyzerDefinitionTranslatorTest.java Log Message: ----------- HSEARCH-2519 When translating analysis factories for ES, make sure the order of elements in array parameters is stable This will avoid issues when validating the schema. Commit: 0ea079cf9e83d3ea80741aeec5d70c8935ca4df7 https://github.com/hibernate/hibernate-search/commit/0ea079cf9e83d3ea8074... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/json/AnalysisJsonElementEquivalence.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/json/AnalysisJsonElementUnorderedArrayEquivalence.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/json/AnalysisParameterEquivalenceRegistry.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java Log Message: ----------- HSEARCH-2519 Add support for unordered arrays when validating ES analyzer definitions Mapping arrays are still considered ordered just to be safe, because some mappings are applied recursively, which means the order may make a difference. Commit: a16d369dd967bb6588773020f5a85e95178a81b1 https://github.com/hibernate/hibernate-search/commit/a16d369dd967bb658877... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchValidationMessages.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContext.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContextElement.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContextType.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationErrorCollector.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java Log Message: ----------- HSEARCH-2519 Reduce code duplication in DefaultElasticsearchSchemaValidator The volume of code does not change much, but it feels a bit cleaner. This commit can be removed without impacting features. Commit: db7594e25f2a8894980c490678bc3e22f06c4463 https://github.com/hibernate/hibernate-search/commit/db7594e25f2a8894980c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/IndexSchemaManagementStrategy.java Log Message: ----------- HSEARCH-2519 Document that the VALIDATE strategy now validates analyzer definitions Commit: 4659a4fbcb4d3788b75acc3a17255c76453cdb48 https://github.com/hibernate/hibernate-search/commit/4659a4fbcb4d3788b75a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaMigrator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java Log Message: ----------- HSEARCH-2520 Also update analyzer definitions in ES's MERGE schema management strategy Commit: 30cd0917c577f845eff9f2fba3a86451d4582b74 https://github.com/hibernate/hibernate-search/commit/30cd0917c577f845eff9... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaMigrationIT.java Log Message: ----------- HSEARCH-2520 Test ES's MERGE schema management strategy with analyzer definitions Commit: 6cd1d62f60885df828bd9a796383b346ef1f9b24 https://github.com/hibernate/hibernate-search/commit/6cd1d62f60885df828bd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java Log Message: ----------- HSEARCH-2520 Log automatic closings and openings of Elasticsearch indexes This is important information, because it might have side-effects on other clients of those indexes, so the INFO level is relevant here. These logs shouldn't be very frequent (only one or two per index on startup). Commit: d3a5364e3483a33bccf3dda3ed2bca9a52c95e90 https://github.com/hibernate/hibernate-search/commit/d3a5364e3483a33bccf3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaMigrator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java Log Message: ----------- HSEARCH-2520 With ES's MERGE schema management strategy, only close indexes if it's really necessary Commit: 45d8f1c8182c4c34c478b79a3fe91318750ac0bc https://github.com/hibernate/hibernate-search/commit/45d8f1c8182c4c34c478... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/IndexSchemaManagementStrategy.java Log Message: ----------- HSEARCH-2520 Document that the MERGE strategy now updates analyzer definitions Commit: b4952c8933a83807e2be075409b863e44d8d7885 https://github.com/hibernate/hibernate-search/commit/b4952c8933a83807e2be... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/service/impl/StandardServiceManager.java Log Message: ----------- HSEARCH-2555 If a given system property is set, make StandardServiceManager.releaseAllServices() fail when some services aren't properly released Commit: 788a78c4dc9993fe952f0929d8fe24a7176c70e1 https://github.com/hibernate/hibernate-search/commit/788a78c4dc9993fe952f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M pom.xml Log Message: ----------- HSEARCH-2555 Ensure the test suite fails if any service isn't properly released Commit: 7630926837c45d4d57f1450ca1012da043fb8f07 https://github.com/hibernate/hibernate-search/commit/7630926837c45d4d57f1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M backends/jgroups/src/test/java/org/hibernate/search/test/jgroups/common/InjectedChannelTest.java M backends/jgroups/src/test/java/org/hibernate/search/test/jgroups/common/MuxChannelTest.java M engine/src/test/java/org/hibernate/search/test/engine/service/StandardServiceManagerTest.java M serialization/avro/src/test/java/org/hibernate/search/test/serialization/ConcurrentServiceTest.java Log Message: ----------- HSEARCH-2555 Make tests release services properly Commit: 54c17030852a4cc0c704dd8daf67efde4b39f5bb https://github.com/hibernate/hibernate-search/commit/54c17030852a4cc0c704... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/service/impl/StandardServiceManager.java Log Message: ----------- HSEARCH-2555 Avoid false positives when reporting unreleased services Commit: b9b742d09b55461b984929f71f1bfae69b4737c6 https://github.com/hibernate/hibernate-search/commit/b9b742d09b55461b9849... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M backends/jms/src/main/java/org/hibernate/search/backend/jms/impl/JmsBackendQueueProcessor.java M engine/src/main/java/org/hibernate/search/engine/impl/ImmutableSearchFactory.java M engine/src/main/java/org/hibernate/search/engine/impl/MutableSearchFactory.java M engine/src/main/java/org/hibernate/search/engine/impl/MutableSearchFactoryState.java M engine/src/main/java/org/hibernate/search/spi/impl/SearchFactoryState.java Log Message: ----------- HSEARCH-2555 Make the SearchFactory release references to the LuceneWorkSerializer ... since it's the SearchFactory that requests them in the first place. Commit: 7eca92458de65b7fba3caa7fc491c2499f120bef https://github.com/hibernate/hibernate-search/commit/7eca92458de65b7fba3c... Author: Sanne Grinovero <sanne(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/service/impl/StandardServiceManager.java Log Message: ----------- HSEARCH-2555 Use the short hand Boolean.getBoolean method instead Commit: 6ef4c2a80eaf93b0038d16a6f4f10fec9f94e106 https://github.com/hibernate/hibernate-search/commit/6ef4c2a80eaf93b0038d... Author: Sanne Grinovero <sanne(a)hibernate.org&gt; Date: 2017-01-22 (Sun, 22 Jan 2017) Changed paths: M engine/src/main/java/org/hibernate/search/engine/service/impl/StandardServiceManager.java Log Message: ----------- HSEARCH-2555 Ensure service wrapper synchronization even during final shutdown Compare: https://github.com/hibernate/hibernate-search/compare/7e57b33f98da...6ef4...