[hibernate-commits] [hibernate/hibernate-search] 51e1f4: HSEARCH-2721 Fix transient failures in DefaultElas...
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: 51e1f43ad84522e3d0c803d157b72d74baa880ba
https://github.com/hibernate/hibernate-search/commit/51e1f43ad84522e3d0c8...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2017-05-16 (Tue, 16 May 2017)
Changed paths:
M
elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/DefaultElasticsearchClientFactoryTest.java
Log Message:
-----------
HSEARCH-2721 Fix transient failures in DefaultElasticsearchClientFactoryTest.discovery
Below is a description of the method I followed to check that the fix is effective.
* run this shell code before making any change:
function countFailures() {
FAILURE=0
SUCCESS=0;
while true
do
if eval "${@}" 1>/dev/null 2>&1
then
(( ++ SUCCESS ))
else
(( ++ FAILURE ))
fi
echo "Success: $SUCCESS, failure: $FAILURE"
done
}
mvn clean install -DskipTests=true
countFailures mvn test -pl elasticsearch -rf elasticsearch
"-Dtest=DefaultElasticsearchClientFactoryTest#discovery"
* notice that for 50 runs, you get approximately 5 failures
* apply the changes in this commit
* run the same shell code again
* notice that you don't get any failures even after 50 runs