[hibernate-commits] [hibernate/hibernate-search] 1c6023: HSEARCH-4647 Slightly simplify the mechanics of re...

Branch: refs/heads/6.1 Home: https://github.com/hibernate/hibernate-search Commit: 1c6023237eee4a93c3e46b027da97c9735c256d1 https://github.com/hibernate/hibernate-search/commit/1c6023237eee4a93c3e4... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessorClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkMixedSharding4ShardSelfStaticBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkStaticSharding4ShardBaseTest.java Log Message: ----------- HSEARCH-4647 Slightly simplify the mechanics of retries in outbox polling coordination Commit: 280879ab3a2d198a722f5cf8313e74f984141f2e https://github.com/hibernate/hibernate-search/commit/280879ab3a2d198a722f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/mapping/impl/OutboxPollingSearchMappingImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/TransactionHelper.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmMassEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmMassIdentifierLoader.java Log Message: ----------- HSEARCH-4647 Make the transaction timeout an attribute of TransactionHelper Instead of a parameter of its methods, so that we can pass a fully parameterized TransactionHelper to other objects that have no idea what the timeout should be. In short, this is about separation of concerns in the changes coming in the next commits. Commit: 49694f5a32e02b2724dff12ff4b2e86eacb2840e https://github.com/hibernate/hibernate-search/commit/49694f5a32e02b2724df... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java Log Message: ----------- HSEARCH-4647 Never perform event processing in the same transaction as a pulse ... to reduce transaction contention. Commit: 0490b65df084a4e7bd2e3cc18d552870c68d827b https://github.com/hibernate/hibernate-search/commit/0490b65df084a4e7bd2e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/mapping/impl/OutboxPollingSearchMappingImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/TransactionHelper.java M orm6/mapper/orm-coordination-outbox-polling/ant-src-changes.patch M orm6/mapper/orm/ant-src-changes.patch Log Message: ----------- HSEARCH-4647 Remove unnecessary parameter in lambdas passed to TransactionHelper We were always using the session from the surrounding context anyway, so the parameter was not useful. Commit: 023821493be264ae5975db33bbaf3165095af192 https://github.com/hibernate/hibernate-search/commit/023821493be264ae5975... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/SessionHelper.java Log Message: ----------- HSEARCH-4647 Simplify the execution of code in a Hibernate ORM session This will be useful for unit testing, in particular, where we want to abstract away from sessions. Commit: 9acb7a73105c73787a00b4b5f4b2e1ff63aff001 https://github.com/hibernate/hibernate-search/commit/9acb7a73105c73787a00... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java A mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AgentClusterLinkContext.java A mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AgentClusterLinkContextProvider.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkDynamicShardingBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkLeaveClusterTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkStaticShardingEdgeCasesTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/MassIndexerAgentClusterLinkLeaveClusterTest.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/SessionHelper.java Log Message: ----------- HSEARCH-4647 Move transaction boundary control to AgentClusterLinks This does not change the behavior of outbox polling, but lays the groundwork to changing it. This will be necessary in the following commits. Commit: 527e76ed4a561b49fecdb7bf2d839a48891f7cb1 https://github.com/hibernate/hibernate-search/commit/527e76ed4a561b49fecd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/cluster/impl/AgentPersister.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/logging/impl/Log.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AgentRepositoryMockingHelper.java Log Message: ----------- HSEARCH-4647 When registering an outbox-polling agent, do not do anything else in the same transaction So that the risk of deadlocks (see below) is minimal and other agents are made aware of this agent as soon as possible. This avoids unnecessary rebalancing when multiple nodes start in quick succession to each other. Commit: 30c778784efce02f7cc07cc71e2dfada45aae3ea https://github.com/hibernate/hibernate-search/commit/30c778784efce02f7cc0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessorClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkTest.java Log Message: ----------- HSEARCH-4647 Split outbox polling transactions into smaller chunks ... to reduce transaction contention. Commit: 7b9f0edd28be1d4c495f41d9005fa94416624395 https://github.com/hibernate/hibernate-search/commit/7b9f0edd28be1d4c495f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessorClusterLink.java Log Message: ----------- HSEARCH-4647 Avoid confusing TRACE statements where no agents are to be suspended Commit: e252e3209bd1eccca1d3b55f5ea0d9e18638e0e8 https://github.com/hibernate/hibernate-search/commit/e252e3209bd1eccca1d3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxEventLoader.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxEventUpdater.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java Log Message: ----------- HSEARCH-4634 Fall back to traditional, blocking locks for outbox event deletion when SKIP_LOCKED is not supported Commit: 89dfa6ae02e19e77103c28873e0eb057e7dd4df2 https://github.com/hibernate/hibernate-search/commit/89dfa6ae02e19e77103c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M Jenkinsfile M integrationtest/mapper/orm-realbackend/src/test/java/org/hibernate/search/integrationtest/mapper/orm/realbackend/limitations/ConcurrentEmbeddedUpdateLimitationIT.java A orm6/integrationtest/mapper/orm-realbackend/ant-src-changes.patch M parents/integrationtest/pom.xml M pom.xml Log Message: ----------- HSEARCH-4644 Test against CockroachDB in continuous integration Compare: https://github.com/hibernate/hibernate-search/compare/2ba6c955638d...89df...