[hibernate-commits] [hibernate/hibernate-orm] 4d9e30: HHH-19349 actually deprecate the ImmutableEntityUp...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 4d9e30829325f070df78427a2137eca0c4a9774a https://github.com/hibernate/hibernate-orm/commit/4d9e30829325f070df78427... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-04-12 (Sat, 12 Apr 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryOptionsBuilder.java M hibernate-core/src/main/java/org/hibernate/boot/spi/AbstractDelegatingSessionFactoryOptions.java M hibernate-core/src/main/java/org/hibernate/query/spi/ImmutableEntityUpdateQueryHandlingMode.java M hibernate-core/src/main/java/org/hibernate/query/spi/QueryEngineOptions.java M hibernate-core/src/main/java/org/hibernate/query/sqm/NodeBuilder.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/update/SqmUpdateStatement.java Log Message: ----------- HHH-19349 actually deprecate the ImmutableEntityUpdateQueryHandlingMode enum It's just a boolean switch, and it has a ridiculously-long name. Imagine if we invented an enum like this for every single config switch in Hibernate! Commit: 122b85c53c2be424a9cd928834b72bdd13674c07 https://github.com/hibernate/hibernate-orm/commit/122b85c53c2be424a9cd928... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-04-12 (Sat, 12 Apr 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/SchemaAutoTooling.java M hibernate-core/src/main/java/org/hibernate/boot/SessionFactoryBuilder.java M hibernate-core/src/main/java/org/hibernate/boot/TempTableDdlTransactionHandling.java M hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryBuilderImpl.java M hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryOptionsBuilder.java M hibernate-core/src/main/java/org/hibernate/boot/spi/AbstractDelegatingSessionFactoryBuilder.java M hibernate-core/src/main/java/org/hibernate/boot/spi/AbstractDelegatingSessionFactoryOptions.java M hibernate-core/src/main/java/org/hibernate/boot/spi/SessionFactoryOptions.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DialectDelegateWrapper.java Log Message: ----------- HHH-19349 deprecate unused SessionFactoryOptions - SchemaAutoTooling is completely obsolete and unused - TempTableDdlTransactionHandling appears to also be obsolete; it's still overridable by a custom Dialect but no Dialect actually does override it Commit: 195d061e66d568dbd129cae0454fcb59f7e0bfd0 https://github.com/hibernate/hibernate-orm/commit/195d061e66d568dbd129cae... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-04-12 (Sat, 12 Apr 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/BootLogging.java M hibernate-core/src/main/java/org/hibernate/boot/jaxb/JaxbLogger.java M hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/HbmTransformationLogging.java M hibernate-core/src/main/java/org/hibernate/boot/query/BootQueryLogging.java M hibernate-core/src/main/java/org/hibernate/bytecode/BytecodeLogging.java M hibernate-core/src/main/java/org/hibernate/bytecode/enhance/spi/interceptor/BytecodeInterceptorLogging.java M hibernate-core/src/main/java/org/hibernate/cache/spi/SecondLevelCacheLogger.java M hibernate-core/src/main/java/org/hibernate/dialect/DialectLogging.java M hibernate-core/src/main/java/org/hibernate/engine/internal/VersionLogger.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/JdbcLogging.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/JdbcBatchLogging.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/env/internal/LobCreationLogging.java M hibernate-core/src/main/java/org/hibernate/graph/internal/GraphParserLogging.java M hibernate-core/src/main/java/org/hibernate/internal/CoreMessageLogger.java M hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryRegistryMessageLogger.java M hibernate-core/src/main/java/org/hibernate/internal/log/ConnectionAccessLogger.java M hibernate-core/src/main/java/org/hibernate/internal/log/ConnectionInfoLogger.java M hibernate-core/src/main/java/org/hibernate/internal/log/DeprecationLogger.java M hibernate-core/src/main/java/org/hibernate/internal/log/IncubationLogger.java M hibernate-core/src/main/java/org/hibernate/internal/log/UrlMessageBundle.java M hibernate-core/src/main/java/org/hibernate/loader/LoaderLogging.java M hibernate-core/src/main/java/org/hibernate/loader/ast/internal/MultiKeyLoadLogging.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/MappingModelCreationLogging.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/NaturalIdLogging.java M hibernate-core/src/main/java/org/hibernate/query/hql/HqlLogging.java R hibernate-core/src/main/java/org/hibernate/query/sql/NativeQueryLogging.java M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/update/SqmUpdateStatement.java M hibernate-core/src/main/java/org/hibernate/resource/beans/internal/BeansMessageLogger.java M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/SqlAstTreeLogger.java M hibernate-core/src/main/java/org/hibernate/sql/exec/SqlExecLogger.java M hibernate-core/src/main/java/org/hibernate/sql/model/ModelMutationLogging.java M hibernate-core/src/main/java/org/hibernate/sql/results/LoadingLogger.java M hibernate-core/src/main/java/org/hibernate/sql/results/ResultsLogger.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/DomainResultGraphPrinter.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/EmbeddableLoadingLogger.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/entity/EntityLoadingLogging.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/JdbcBindingLogging.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/JdbcExtractingLogging.java Log Message: ----------- mark all Loggers as @Internal, and delete an obsolete one really we should move all these to internal packages Commit: 89dab7dcdfdf0a519153b527263258821f6454c6 https://github.com/hibernate/hibernate-orm/commit/89dab7dcdfdf0a519153b52... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-04-12 (Sat, 12 Apr 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/query/sql/internal/NativeQueryImpl.java M hibernate-core/src/main/java/org/hibernate/query/sql/spi/NonSelectInterpretationsKey.java M hibernate-core/src/main/java/org/hibernate/query/sql/spi/ParameterOccurrence.java M hibernate-core/src/main/java/org/hibernate/query/sql/spi/SelectInterpretationsKey.java M hibernate-core/src/main/java/org/hibernate/sql/exec/internal/JdbcParameterBindingsImpl.java Log Message: ----------- code cleanups around native query stuff Commit: f67a0d2f0b853f2cc5bf3707f8a65610c58dd227 https://github.com/hibernate/hibernate-orm/commit/f67a0d2f0b853f2cc5bf370... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-04-12 (Sat, 12 Apr 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryOptionsBuilder.java M hibernate-core/src/main/java/org/hibernate/boot/spi/AbstractDelegatingSessionFactoryOptions.java M hibernate-core/src/main/java/org/hibernate/cfg/QuerySettings.java M hibernate-core/src/main/java/org/hibernate/internal/CoreMessageLogger.java M hibernate-core/src/main/java/org/hibernate/query/spi/ImmutableEntityUpdateQueryHandlingMode.java M hibernate-core/src/main/java/org/hibernate/query/spi/QueryEngineOptions.java M hibernate-core/src/main/java/org/hibernate/query/sqm/NodeBuilder.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java M hibernate-core/src/main/java/org/hibernate/query/sqm/tree/update/SqmUpdateStatement.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/immutable/ImmutableEntityUpdateQueryHandlingModeExceptionTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/immutable/ImmutableEntityUpdateQueryHandlingModeWarningTest.java M migration-guide.adoc M tooling/metamodel-generator/src/main/java/org/hibernate/processor/validation/MockSessionFactory.java Log Message: ----------- invert the default for hibernate.query.immutable_entity_update_query_handling_mode The "default to warn but error when explicitly disabled" semantics for this were entirely backwards and hostile to the user. "Safety" features should always be on by default. Also, you all know what I think about WARNings, and here we had the most annoying kind of WARN, the one that couldn't be suppressed, except in log settings, even though it's probably intentional that the user is updating an immutable entity. Ugh. Compare: https://github.com/hibernate/hibernate-orm/compare/eb02f8565dae...f67a0d2... To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications