[hibernate-commits] [hibernate/hibernate-orm] 1d7be9: cleanups to InFlightMetadataCollector[Impl]

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 1d7be9512adf050e1a49bc79c5d0e951c330e419 https://github.com/hibernate/hibernate-orm/commit/1d7be9512adf050e1a49bc7... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/internal/InFlightMetadataCollectorImpl.java M hibernate-core/src/main/java/org/hibernate/boot/spi/InFlightMetadataCollector.java M hibernate-core/src/main/java/org/hibernate/mapping/Component.java M hibernate-core/src/main/java/org/hibernate/mapping/ForeignKey.java M hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java Log Message: ----------- cleanups to InFlightMetadataCollector[Impl] incl attempt to fix PK to FK copying Commit: fb9c007bdd38e1acea15b84837ecfd10f8949d34 https://github.com/hibernate/hibernate-orm/commit/fb9c007bdd38e1acea15b84... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java M hibernate-core/src/main/java/org/hibernate/boot/model/process/internal/EnumeratedValueResolution.java M hibernate-core/src/main/java/org/hibernate/boot/model/process/internal/InferredBasicValueResolver.java M hibernate-core/src/main/java/org/hibernate/boot/model/relational/NamedAuxiliaryDatabaseObject.java M hibernate-core/src/main/java/org/hibernate/boot/model/relational/SimpleAuxiliaryDatabaseObject.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DialectDelegateWrapper.java M hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java M hibernate-core/src/main/java/org/hibernate/type/CharBooleanConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/NamedEnumValueConverter.java A hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/NativeEnumValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/OrdinalEnumValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/spi/BasicValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/EnumJavaType.java A hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/NativeEnumJdbcType.java Log Message: ----------- HHH-16125 attempt to support PostgreSQL enum types Commit: d348ae2d8c6f3d398f536aedf2094c5f44883c32 https://github.com/hibernate/hibernate-orm/commit/d348ae2d8c6f3d398f536ae... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/ArrayJdbcType.java Log Message: ----------- workaround issue on postgres this is probably a pre-existing hole in the logic, not related really related to my work Commit: febf39cc553d9bdaded3a53c42747937888f4881 https://github.com/hibernate/hibernate-orm/commit/febf39cc553d9bdaded3a53... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: R hibernate-core/src/main/java/org/hibernate/boot/model/process/internal/EnumeratedValueResolution.java M hibernate-core/src/main/java/org/hibernate/boot/model/process/internal/InferredBasicValueResolver.java M hibernate-core/src/main/java/org/hibernate/boot/spi/InFlightMetadataCollector.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java A hibernate-core/src/main/java/org/hibernate/dialect/MySQLEnumJdbcType.java M hibernate-core/src/main/java/org/hibernate/dialect/OracleBooleanJdbcType.java M hibernate-core/src/main/java/org/hibernate/dialect/OracleJsonJdbcType.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java A hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLEnumJdbcType.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/mapping/Column.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java M hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java M hibernate-core/src/main/java/org/hibernate/sql/ast/tree/expression/QueryLiteral.java M hibernate-core/src/main/java/org/hibernate/type/BasicType.java M hibernate-core/src/main/java/org/hibernate/type/SqlTypes.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/EnumHelper.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/NamedEnumValueConverter.java R hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/NativeEnumValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/OrdinalEnumValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/spi/BasicValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/EnumJavaType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JavaType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/IntegerJdbcType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/JdbcType.java R hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/NativeEnumJdbcType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/OracleJsonBlobJdbcType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/internal/JdbcTypeBaseline.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/DdlType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/internal/DdlTypeImpl.java A hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/internal/NamedNativeEnumDdlTypeImpl.java A hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/internal/NativeEnumDdlTypeImpl.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/spi/DdlTypeRegistry.java M hibernate-envers/src/main/java/org/hibernate/envers/configuration/internal/metadata/BasicMetadataGenerator.java Log Message: ----------- HHH-16125 complete redesign of how enum mappings work - introduce SqlTypes.ENUM - no more converters! - finish of Potgres enum support - disable BIND for enums in Criteria on PostgreSQL (PostgreSQL doesn't do the needed type conversion to the enum type) Commit: d075093ebfa7de6f5b7fb8c7f8021780e2b3059e https://github.com/hibernate/hibernate-orm/commit/d075093ebfa7de6f5b7fb8c... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java M hibernate-core/src/main/java/org/hibernate/sql/exec/internal/JdbcParameterBindingImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaCreatorImpl.java M hibernate-core/src/main/java/org/hibernate/type/EnumType.java M hibernate-core/src/main/java/org/hibernate/type/internal/UserTypeSqlTypeAdapter.java Log Message: ----------- HHH-16125 clean up legacy EnumType Commit: db4a1bb6ef5a54dabf9afa92fee5d685cb1825a2 https://github.com/hibernate/hibernate-orm/commit/db4a1bb6ef5a54dabf9afa9... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/type/BasicType.java M hibernate-core/src/main/java/org/hibernate/type/CharBooleanConverter.java M hibernate-core/src/main/java/org/hibernate/type/NumericBooleanConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/JpaAttributeConverterImpl.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/spi/BasicValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanJavaType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JavaType.java Log Message: ----------- HHH-16125 remove DDL generation stuff from converters it never belonged there! Commit: 9c6c3eba81e29c58a1a8ca41b29f9c821226869c https://github.com/hibernate/hibernate-orm/commit/9c6c3eba81e29c58a1a8ca4... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/AbstractPostgreSQLStructJdbcType.java M hibernate-core/src/main/java/org/hibernate/dialect/JsonHelper.java M hibernate-core/src/main/java/org/hibernate/dialect/XmlHelper.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/EnumJavaType.java Log Message: ----------- HHH-16125 fix enums in embeddable types on postgres fixes allowing correct serialization/deserialization of enums includes workaround for StructJdbcType sending us a BigDecimal (need better solution) Commit: bfb0fc6aba511102c527c7eb9547fef42f6645c5 https://github.com/hibernate/hibernate-orm/commit/bfb0fc6aba511102c527c7e... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ArrayJavaType.java M hibernate-core/src/test/java/org/hibernate/orm/test/type/EnumArrayTest.java Log Message: ----------- HHH-16125 fix the encoding of enum arrays to varbinary Commit: 7514f8ad00315557ea597f954c3eb72c598369f0 https://github.com/hibernate/hibernate-orm/commit/7514f8ad00315557ea597f9... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/AbstractPostgreSQLStructJdbcType.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/JsonHelper.java M hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/MySQLEnumJdbcType.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLEnumJdbcType.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/mapping/Column.java M hibernate-core/src/main/java/org/hibernate/mapping/ForeignKey.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java M hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java M hibernate-core/src/main/java/org/hibernate/type/BasicType.java M hibernate-core/src/main/java/org/hibernate/type/SqlTypes.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanJavaType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/EnumJavaType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JavaType.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/internal/JdbcTypeBaseline.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/internal/NamedNativeEnumDdlTypeImpl.java Log Message: ----------- HHH-16125 introduce SqlTypes.NAMED_ENUM to make pg enums non-default and clean up the impl of enums Commit: c91cfdf2f12a3472f52296fc10c20d418e5b6497 https://github.com/hibernate/hibernate-orm/commit/c91cfdf2f12a3472f52296f... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/embeddables/nested/NestedEmbeddableMetadataTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/embeddables/nested/fieldaccess/FieldAccessedNestedEmbeddableMetadataTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/enumerated/EnumeratedSmokeTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/enumerated/mappedSuperclass/EnumeratedWithMappedSuperclassTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/enumerated/ormXml/OrmXmlEnumTypeTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/bootstrap/binding/annotations/basics/EnumResolutionTests.java M hibernate-core/src/test/java/org/hibernate/orm/test/mapping/SmokeTests.java R hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/enums/TestEnumTypeSerialization.java M hibernate-core/src/test/java/org/hibernate/orm/test/sql/ast/SmokeTests.java M hibernate-envers/src/test/java/org/hibernate/orm/test/envers/integration/collection/EnumSet.java M hibernate-testing/src/main/java/org/hibernate/testing/junit4/ExtraAssertions.java Log Message: ----------- HHH-16125 delete/fix a bunch of assertions that constrain implementation details these are bad tests; they don't test observable behavior Commit: 15d20113e75ed7d4895af9df4730ea9a69377faf https://github.com/hibernate/hibernate-orm/commit/15d20113e75ed7d4895af9d... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Boy.java R hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Character.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/CharacterTrait.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/DefaultNamingCollectionElementTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/FunctionTests.java M hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/StandardFunctionTests.java Log Message: ----------- HHH-16125 make tests work with postgres enums Commit: 20b157000cc6869bdaa7b6d67eace7e846c2ac22 https://github.com/hibernate/hibernate-orm/commit/20b157000cc6869bdaa7b6d... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-04-29 (Sat, 29 Apr 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/type/EnumType.java R hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/NamedEnumValueConverter.java R hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/internal/OrdinalEnumValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/package-info.java R hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/spi/EnumValueConverter.java M hibernate-core/src/main/java/org/hibernate/type/descriptor/converter/spi/package-info.java M hibernate-envers/src/main/java/org/hibernate/envers/configuration/internal/metadata/BasicMetadataGenerator.java Log Message: ----------- HHH-16125 final cleanup of legacy enum converters stuff Compare: https://github.com/hibernate/hibernate-orm/compare/eefa1d9365f2...20b1570...