[hibernate-commits] [hibernate/hibernate-search] 900f05: HSEARCH-3669 Rename SearchQuery.fetch() to fetchAl...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 900f05144d92a1e34a3c7650228b465d5af9813b https://github.com/hibernate/hibernate-search/commit/900f05144d92a1e34a3c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-09-17 (Tue, 17 Sep 2019) Changed paths: M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/spatial/genericfield/GeoPointGenericFieldIT.java M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/spatial/geopointbinding/multiple/GeoPointBindingMultipleIT.java M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/spatial/geopointbinding/property/GeoPointBindingPropertyIT.java M documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/spatial/geopointbinding/type/GeoPointBindingTypeIT.java M documentation/src/test/java/org/hibernate/search/documentation/search/query/QueryDslIT.java M engine/src/main/java/org/hibernate/search/engine/search/query/ExtendedSearchFetchable.java M engine/src/main/java/org/hibernate/search/engine/search/query/SearchFetchable.java M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/spi/AbstractExtendedSearchQueryOptionsStep.java M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/spi/AbstractSearchQueryOptionsStep.java M engine/src/main/java/org/hibernate/search/engine/search/query/spi/AbstractSearchQuery.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ElasticsearchExtensionIT.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/search/query/ElasticsearchSearchQueryIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/LuceneExtensionIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/mapping/LuceneFieldAttributesIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/mapping/LuceneFieldTypesIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/bool/BooleanSortAndRangePredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/PhraseSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/SimpleQueryStringSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryBaseIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryFetchIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryResultLoadingOrTransformingIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/FieldSearchSortIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/SearchSortIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/spatial/DistanceSearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/spatial/NestedDocumentDistanceProjectionIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/hibernateormapis/ToHibernateOrmIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/SearchQueryBaseIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/DocumentIdDefaultBridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldDefaultBridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/providedid/ProvidedIdIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/routing/AnnotationMappingRoutingIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/routing/ProgrammaticMappingRoutingIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/AnnotationMappingSmokeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/ProgrammaticMappingSmokeIT.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepositoryImpl.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/SearchResultAssert.java Log Message: ----------- HSEARCH-3669 Rename SearchQuery.fetch() to fetchAll() and .fetchHits() to .fetchAllHits() So that they are not used by mistake, which would be dangerous. Commit: 6569361d86977a7b58663986983c005f61eb1402 https://github.com/hibernate/hibernate-search/commit/6569361d86977a7b5866... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-09-17 (Tue, 17 Sep 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/search/query/SearchFetchable.java Log Message: ----------- HSEARCH-3707 Document more clearly the effect of limit/offset in SearchQuery.fetch Commit: 3ee9e0f8a84b228a87b3c24559da2e4aaba571e3 https://github.com/hibernate/hibernate-search/commit/3ee9e0f8a84b228a87b3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-09-17 (Tue, 17 Sep 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java M documentation/src/main/asciidoc/search-dsl.asciidoc M documentation/src/test/java/org/hibernate/search/documentation/search/query/QueryDslIT.java M engine/src/main/java/org/hibernate/search/engine/search/query/ExtendedSearchFetchable.java M engine/src/main/java/org/hibernate/search/engine/search/query/SearchFetchable.java M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/spi/AbstractExtendedSearchQueryOptionsStep.java M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/spi/AbstractSearchQueryOptionsStep.java M engine/src/main/java/org/hibernate/search/engine/search/query/spi/AbstractSearchQuery.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/RangeAggregationSpecificsIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/TermsAggregationSpecificsIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryFetchIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryResultLoadingOrTransformingIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/AnnotationMappingSmokeIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/ProgrammaticMappingSmokeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/AnnotationMappingSmokeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/ProgrammaticMappingSmokeIT.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchLibraryRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchPersonRepositoryImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/query/impl/HibernateOrmSearchQueryAdapter.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/StubSearchQuery.java Log Message: ----------- HSEARCH-3707 Swap the offset and limit parameters in SearchQuery.fetch(Integer, Integer) .fetchHits(Integer, Integer) Offset, then limit seems more consistent with what's done elsewhere (Spring Data's PageRequest in particular). Commit: 6ced99c42e47e20a71f70758ae547ecc8dd68019 https://github.com/hibernate/hibernate-search/commit/6ced99c42e47e20a71f7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-09-17 (Tue, 17 Sep 2019) Changed paths: M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepository.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchLibraryRepository.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchLibraryRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchPersonRepository.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchPersonRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/service/BorrowalService.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/service/DocumentService.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/service/LibraryService.java Log Message: ----------- HSEARCH-3707 Swap the offset and limit parameters in repository methods of the Library showcase So that it matches the new order used in SearchQuery. Compare: https://github.com/hibernate/hibernate-search/compare/32a1cda975d0...6ced...