[hibernate-commits] [hibernate/hibernate-orm] ec0ac7: HHH-20725 Add test for issue

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: ec0ac7fb2d807b408c94bed1f5c0ee67a1b87442 https://github.com/hibernate/hibernate-orm/commit/ec0ac7fb2d807b408c94bed... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/inheritance/ForeignKeyNameOrmXmlTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/joincolumnfk/Company.java A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/joincolumnfk/Department.java A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/joincolumnfk/Division.java A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/joincolumnfk/JoinColumnForeignKeyNameOrmXmlTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/joincolumnfk/VicePresident.java A hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/joincolumnfk/Worker.java A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/inheritance/Employee.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/inheritance/Manager.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/inheritance/Payment.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/inheritance/Person.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/joincolumnfk/Company.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/joincolumnfk/Department.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/joincolumnfk/Division.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/joincolumnfk/VicePresident.orm.xml A hibernate-core/src/test/resources/org/hibernate/orm/test/schemaupdate/joincolumnfk/Worker.orm.xml Log Message: ----------- HHH-20725 Add test for issue EntityBinder.nestedForeignKey and setForeignKeyNameIfDefined only read the container-level foreign key, ignoring the FK set on individual primary-key-join-column elements. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply(a)anthropic.com&gt; Commit: ddbbf09ad3d4f5f7606ba1a9d50e9c6755961c14 https://github.com/hibernate/hibernate-orm/commit/ddbbf09ad3d4f5f7606ba1a... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/model/internal/BinderHelper.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/MapBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/ToOneBinder.java Log Message: ----------- HHH-20725 EntityBinder, ToOneBinder and MapBinder do not read FK name from individual join column elements EntityBinder.nestedForeignKey, EntityBinder.setForeignKeyNameIfDefined, ToOneBinder.nestedForeignKey, and MapBinder.getMapKeyForeignKey only checked the container-level foreignKey(), ignoring FK names set on individual @PrimaryKeyJoinColumn, @JoinColumn, or @MapKeyJoinColumn entries. Extract the shared fallback logic into BinderHelper.resolveContainerForeignKey() with typed overloads for JoinColumn[], PrimaryKeyJoinColumn[], and MapKeyJoinColumn[], and simplify all four call sites in EntityBinder, ToOneBinder, and MapBinder. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply(a)anthropic.com&gt; Compare: https://github.com/hibernate/hibernate-orm/compare/2cdc54929327...ddbbf09... To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications